Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\))
Subject: Re: [RFC 1/1] drivers/dma/*: replace tasklets with workqueue
From:   Allen Pais <apais@linux.microsoft.com>
In-Reply-To: <353023ba-d506-5d45-be68-df2025074ed6@kernel.org>
Date:   Mon, 25 Apr 2022 17:04:31 -0700
Cc:     olivier.dautricourt@orolia.com, sr@denx.de, vkoul@kernel.org,
        Kees Cook <keescook@chromium.org>,
        linux-hardening@vger.kernel.org, ludovic.desroches@microchip.com,
        tudor.ambarus@microchip.com, f.fainelli@gmail.com,
        rjui@broadcom.com, sbranden@broadcom.com,
        bcm-kernel-feedback-list@broadcom.com, nsaenz@kernel.org,
        paul@crapouillou.net, Eugeniy.Paltsev@synopsys.com,
        gustavo.pimentel@synopsys.com, vireshk@kernel.org,
        andriy.shevchenko@linux.intel.com, leoyang.li@nxp.com,
        zw@zh-kernel.org, wangzhou1@hisilicon.com, shawnguo@kernel.org,
        s.hauer@pengutronix.de, sean.wang@mediatek.com,
        matthias.bgg@gmail.com, afaerber@suse.de, mani@kernel.org,
        logang@deltatee.com, sanju.mehta@amd.com, daniel@zonque.org,
        haojian.zhuang@gmail.com, robert.jarzmik@free.fr,
        agross@kernel.org, bjorn.andersson@linaro.org,
        krzysztof.kozlowski@linaro.org, green.wan@sifive.com,
        orsonzhai@gmail.com, baolin.wang7@gmail.com, zhang.lyra@gmail.com,
        patrice.chotard@foss.st.com, linus.walleij@linaro.org,
        wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org,
        dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <F7470CEE-48F0-4D25-92E2-295787EE6F12@linux.microsoft.com>
References: <20220419211658.11403-1-apais@linux.microsoft.com>
 <20220419211658.11403-2-apais@linux.microsoft.com>
 <353023ba-d506-5d45-be68-df2025074ed6@kernel.org>
To:     Krzysztof Kozlowski <krzk@kernel.org>
Precedence: bulk


>> The tasklet is an old API which will be deprecated, workqueue API
>> cab be used instead of them.
>>=20
>=20
> Thank you for your patch. There is something to discuss/improve.
>=20
>> This patch replaces the tasklet usage in drivers/dma/* with a
>> simple work.
>=20
> Minor nits:
>=20
> 1. Don't use "this patch".
> =
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/subm=
itting-patches.rst#L95
> 2. Use subject prefix matching subsystem (git log --oneline)

 Thank you. Will have it updated.

>=20
>>=20
>> Github: https://github.com/KSPP/linux/issues/94
>=20
> 3. No external references to some issue management systems, change-ids
> etc. Lore link could work, but it's not relevant here, I guess.

We have had other tasks in the past which have carried the links. =
Ideally, I would like to=20
Keep it, I will leave it to the maintainers.=20

Thanks.=