Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 25 Apr 2022 10:16:01 +0200
From:   Sean Nyekjaer <sean@geanix.com>
To:     Peter Rosin <peda@axentia.se>
Cc:     linux-kernel@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: dac: ti-dac5571: add support for ti,dac121c081
Message-ID: <20220425081601.cs42eujnghzxnxgt@Seans-MBP.hinnerup>
References: <b657ebf9-e2e3-6d3f-e7e9-c660e860e54c@axentia.se>
 <6e63f598-ff54-6cb6-8c7d-83e9d6231af0@axentia.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <6e63f598-ff54-6cb6-8c7d-83e9d6231af0@axentia.se>
Precedence: bulk

On Mon, Apr 25, 2022 at 08:02:34AM +0200, Peter Rosin wrote:
> It fits right in as a single 12-bit DAC.
> 
> Signed-off-by: Peter Rosin <peda@axentia.se>
Reviewed-by: Sean Nyekjaer <sean@geanix.com>
> ---
>  drivers/iio/dac/Kconfig      | 2 +-
>  drivers/iio/dac/ti-dac5571.c | 3 +++
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index c0bf0d84197f..d6248b188645 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -417,7 +417,7 @@ config TI_DAC5571
>  	help
>  	  Driver for the Texas Instruments
>  	  DAC5571, DAC6571, DAC7571, DAC5574, DAC6574, DAC7574, DAC5573,
> -	  DAC6573, DAC7573, DAC8571, DAC8574.
> +	  DAC6573, DAC7573, DAC8571, DAC8574, DAC121C081.
>  	  If compiled as a module, it will be called ti-dac5571.
> diff --git a/drivers/iio/dac/ti-dac5571.c b/drivers/iio/dac/ti-dac5571.c
> index 4a3b8d875518..ce542bd8b69e 100644
> --- a/drivers/iio/dac/ti-dac5571.c
> +++ b/drivers/iio/dac/ti-dac5571.c
> @@ -13,6 +13,7 @@
>   * https://www.ti.com/lit/ds/symlink/dac5573.pdf
>   * https://www.ti.com/lit/ds/symlink/dac6573.pdf
>   * https://www.ti.com/lit/ds/symlink/dac7573.pdf
> + * https://www.ti.com/lit/ds/symlink/dac121c081.pdf
>   */
>  #include <linux/iio/iio.h>
> @@ -394,6 +395,7 @@ static const struct of_device_id dac5571_of_id[] = {
>  	{.compatible = "ti,dac5573"},
>  	{.compatible = "ti,dac6573"},
>  	{.compatible = "ti,dac7573"},
> +	{.compatible = "ti,dac121c081"},
>  	{}
>  };
>  MODULE_DEVICE_TABLE(of, dac5571_of_id);
> @@ -408,6 +410,7 @@ static const struct i2c_device_id dac5571_id[] = {
>  	{"dac5573", quad_8bit},
>  	{"dac6573", quad_10bit},
>  	{"dac7573", quad_12bit},
> +	{"dac121c081", single_12bit},
>  	{}
>  };
>  MODULE_DEVICE_TABLE(i2c, dac5571_id);
> -- 
> 2.20.1
>