Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp3287906ioa; Tue, 26 Apr 2022 00:01:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjaTOsqqSUzBT3tZpJkhhTdghcg3Yedevb9/Sk53odbVjwE2asRr6jRVdGHL5tgfgtZzfj X-Received: by 2002:a17:902:8608:b0:158:b827:7721 with SMTP id f8-20020a170902860800b00158b8277721mr21801430plo.149.1650956503760; Tue, 26 Apr 2022 00:01:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650956503; cv=none; d=google.com; s=arc-20160816; b=WIrInLsa17wfxMXDjjVKripkTwlGyXUEmGTl7xdBJixZXtoWSSv5pwGKj9FMR+f+JP gOFSUJwcWbm1jG3mtaGsVToR9RZX26Rrpo4EoNmkGdqJDZpEeWNsM4LkoZinxFE4tgTC 4dShxruebTUkzvF89peHQkwwdf8z/uEow8pp4oUdl8xjlsjvNuoUrMEW+w4vSFRZCLhP wbkorkQEhcCSb6lS+s5MzMdCp5HCvxRBODJ5//thm+0HO0OhdwfTeWoo5tcD5VsILf6Q cFshw6RpyhVHQu9lif1B85BVNn562oOZ/iF9gNJ5KE+Udm6y+UGvLWrpXk/m/aqZRjvd kG8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=igI9veT4r3yAsT8WRErYvhfCgbvbeXys0R8pvG0Otvk=; b=ucpy5HLwXujgd8g15NoT/W+f7NmowEjaKrrw+gcfAf0jSfAxlQQDWcnCwbAZfcE7ve Q1oXloiV68UqhkRT1LFxZiEvN6PJt7i44y8HEDZt4KCOCJbdQAeOccDlmjazpS0zUfn/ B0Kj56fNGpXnhWI5Ijglfx6kQXRLFnmn9tHA0tEV4i0L5ozJ52GkgIX8t4cdIp2Fgdnn Yz23IksVccCcFgNODouTGYcHLNEWRbNKSP8duDFGcF39ag0o64Zzz//5JsHMsxGsrmwr LuyU2F2AiqgqedTo7FlYwLVyzlDYvs4i4zhoVZQDpj70UxnpqC35HVFKD/womrtQoBbm NVcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="fJJ/Pe5g"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q15-20020a63e94f000000b0038295fbcb98si17748890pgj.247.2022.04.26.00.01.28; Tue, 26 Apr 2022 00:01:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="fJJ/Pe5g"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236726AbiDYKjV (ORCPT + 99 others); Mon, 25 Apr 2022 06:39:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234919AbiDYKjQ (ORCPT ); Mon, 25 Apr 2022 06:39:16 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1095FB7C8; Mon, 25 Apr 2022 03:36:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C3790B8128F; Mon, 25 Apr 2022 10:36:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BC36C385A7; Mon, 25 Apr 2022 10:36:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650882968; bh=wkyNxnKYvpuBo7kmCBxnLUwwRMn5XI30arFCVougD+E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fJJ/Pe5gF0UyKVzOXciVE3aqwc6iWwdwdYr988a7lID1iQ8yjBxPZE6CYNvnKBVwI DyfBf6AzVmnP2OUwy1fiUJ59QMW6ySgHu6T5onoZe/2j7hzuMygTzuHrTooWQqCqZY U2zcNMEmgto2jAUNTCmWHt9P4niJptV5mitbJLd8= Date: Mon, 25 Apr 2022 12:36:05 +0200 From: Greg Kroah-Hartman To: Shile Zhang Cc: David Airlie , Daniel Vetter , Wen Kang , stable@vger.kernel.org, virtualization@lists.linux-foundation.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5.10.y] drm/cirrus: fix a NULL vs IS_ERR() checks Message-ID: References: <20211228132556.108711-1-shile.zhang@linux.alibaba.com> <1cc25ebe-2c68-458b-15a2-fc4c80ba2054@linux.alibaba.com> <550e9439-adf6-3df8-41a0-9a7ee5447907@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <550e9439-adf6-3df8-41a0-9a7ee5447907@linux.alibaba.com> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 24, 2022 at 11:27:17AM +0800, Shile Zhang wrote: > Hi David and Daniel, > > Sorry but could you please help to check this issue? > Due to the function 'drm_gem_shmem_vmap' could return ERROR pointers which > will cause the kernel crash due to 'cirrus_fb_blit_rect' only check the > pointer. > > Since the related code has been refactoring in mainline, so this issue only > happened in stable 5.10.y branch. > > @Greg > I think it is probably not realistic to backport the related refactoring > from mainline directly, so I just give this bugfix patch only for 5.10.y > branch. I'm sorry, but I do not have "this bugfix" in my queue anymore, considering it is so old. Please rebase and resubmit. thanks, greg k-h