Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <33da014b-bfb0-a39f-aba7-f469fcb5cfbb@ixit.cz>
Date:   Mon, 25 Apr 2022 16:05:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v3 1/2] dt-bindings: mailbox: qcom-ipcc: add missing
 compatible for SM8450
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Manivannan Sadhasivam <mani@kernel.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
References: <20220425134717.55418-1-david@ixit.cz>
 <6f72be3c-c907-bc7a-6b64-6becfc76934e@linaro.org>
From:   David Heidelberg <david@ixit.cz>
In-Reply-To: <6f72be3c-c907-bc7a-6b64-6becfc76934e@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 25/04/2022 15:51, Krzysztof Kozlowski wrote:
> On 25/04/2022 15:47, David Heidelberg wrote:
>> Adds forgotten compatible and update SPDX header.
> You need to explain what is this "forgotten compatible". It's to vague.
Forgotten by someone who implemented it in driver. Hope that clarify it 
for you and possibly other readers. Btw. qcom,*sm8450* compatibles are 
widely used and fact that `make dtbs_check` noticed it missing here 
isn't suprising..
>
> The SPDX update lacks answer to "why". There is no reason to do it, so
> please explain why it is needed.

Please read https://spdx.org/licenses/GPL-2.0.html (red colored text).

I personally encountered situation, where usage GPL license without 
specific `-only` or `-or-later` caused unnecessary confusion and 
uncertainty.

>
>
> Best regards,
> Krzysztof

-- 
David Heidelberg
Consultant Software Engineer

Matrix: @okias:matrix.org