Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 25 Apr 2022 19:53:49 -0500
From:   Rob Herring <robh@kernel.org>
To:     David Heidelberg <david@ixit.cz>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Manivannan Sadhasivam <mani@kernel.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: mailbox: qcom-ipcc: add missing
 compatible for SM8450
Message-ID: <YmdCnWRu6AgBlsEH@robh.at.kernel.org>
References: <20220425134717.55418-1-david@ixit.cz>
 <6f72be3c-c907-bc7a-6b64-6becfc76934e@linaro.org>
 <33da014b-bfb0-a39f-aba7-f469fcb5cfbb@ixit.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <33da014b-bfb0-a39f-aba7-f469fcb5cfbb@ixit.cz>
Precedence: bulk

On Mon, Apr 25, 2022 at 04:05:57PM +0200, David Heidelberg wrote:
> On 25/04/2022 15:51, Krzysztof Kozlowski wrote:
> > On 25/04/2022 15:47, David Heidelberg wrote:
> > > Adds forgotten compatible and update SPDX header.
> > You need to explain what is this "forgotten compatible". It's to vague.
> Forgotten by someone who implemented it in driver. Hope that clarify it for
> you and possibly other readers. Btw. qcom,*sm8450* compatibles are widely
> used and fact that `make dtbs_check` noticed it missing here isn't
> suprising..
> > 
> > The SPDX update lacks answer to "why". There is no reason to do it, so
> > please explain why it is needed.
> 
> Please read https://spdx.org/licenses/GPL-2.0.html (red colored text).
> 
> I personally encountered situation, where usage GPL license without specific
> `-only` or `-or-later` caused unnecessary confusion and uncertainty.

I don't mind changing these, but please do a tree wide change for all 
bindings, not an 'while I'm here also change X' change.

Rob