Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Wu, Hao" <hao.wu@intel.com>
To:     "matthew.gerlach@linux.intel.com" <matthew.gerlach@linux.intel.com>,
        "Zhang, Tianfei" <tianfei.zhang@intel.com>
CC:     "trix@redhat.com" <trix@redhat.com>,
        "mdf@kernel.org" <mdf@kernel.org>,
        "Xu, Yilun" <yilun.xu@intel.com>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] uio: dfl: add HSSI feature id
Thread-Topic: [PATCH v2] uio: dfl: add HSSI feature id
Thread-Index: AQHYTjZdBoHDFBYOuES9CQIlYPGclaz06tqwgAKlRYOACf1WkA==
Date:   Tue, 26 Apr 2022 02:31:33 +0000
Message-ID: <DM6PR11MB38197992351E559308C8F58185FB9@DM6PR11MB3819.namprd11.prod.outlook.com>
References: <20220412062353.53984-1-tianfei.zhang@intel.com>
 <DM6PR11MB38190E6EEF6DE3EB900290C585F39@DM6PR11MB3819.namprd11.prod.outlook.com>
 <BN9PR11MB548330FAA7EF6B9DAC2F0E76E3F29@BN9PR11MB5483.namprd11.prod.outlook.com>
 <alpine.DEB.2.22.394.2204191048300.5866@rhweight-WRK1>
In-Reply-To: <alpine.DEB.2.22.394.2204191048300.5866@rhweight-WRK1>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.401.20
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4HXTOF1YoKxqflIk/T61er7DTtfZBc57nRryEAXEDOwWVWVyJB0hha95BJ+X?=
 =?us-ascii?Q?em2X4gYLHNEVbiALOS1CBYHAzrRcgX8awvL9YP3nGf5HxtjilKLykT9Q5g5Z?=
 =?us-ascii?Q?G6wa5M46hiThZGjK8jjqvYa70ytYLbVLKKVweWXEBVGcYVrHhEluYV1DV3mP?=
 =?us-ascii?Q?8C2CQZBZyl9ASiczayriyLpoA/sIEUnHXVXcqjeMhhFG0FVbphCQjS2lMkQ/?=
 =?us-ascii?Q?h+qLU+VMzLdUuhVcaE/0InnuAxdYVKkkM5RGCKATPdGR4m14JhmyUWQ7N5kG?=
 =?us-ascii?Q?p3It3YWfu101YWBJAcN/URgRNdJyYJR3D3heDKXYX8j9Di7HRqItNtxo2RAk?=
 =?us-ascii?Q?eHA+UWl7C+ElsbyPTXR7UN3vj/8ywuaX4LyZFrie3Jgy6utdstlBhc+YS5cC?=
 =?us-ascii?Q?jG3b6J2RXXEtjh3k6r4bHhiLJuEQ3jYTQEHuIV8l+kTi2OiKVqLhyijSwqhg?=
 =?us-ascii?Q?vAeXWIXvJnYUX3WnPDMZpupWRBQmWir4V5GDNHJ9QtKkoDUwmduXPyoeSsZU?=
 =?us-ascii?Q?1KivLEid/nPxxM04uuFNv2Kk0NJl6H37dkIzL9u0Psj9GHlCWYUAkNKn6w9L?=
 =?us-ascii?Q?PtlZFsgT84IQGEoDwqjrQ4nNsA3FeD+9+6WnS9q0c/DiYuXUqp359dsn1yqP?=
 =?us-ascii?Q?R8AlyNxlXzHYy7TKn/IaTpqRxwrApPDXw+I6WiGUJ2X/ZRxgD2tke46RatxR?=
 =?us-ascii?Q?Chohu2++X5Dmbq2d6jFqfv6+xha6uZcL1gDmzg6zV3NB+/eW0hAdUy2y5KMt?=
 =?us-ascii?Q?/BzDd9S7sxQJtfXaw3n53UtDp6/06ErP4ik4Q5KFgiBcYQBTZR1UOyg0j7z7?=
 =?us-ascii?Q?p2AKGcyGtYRV5f6AIN5+gUe/tW8NuSgZhgKIdlB+5FtcdmXoXbC5zKnK/I9J?=
 =?us-ascii?Q?z3wEeeMYPKZvIeXECVPRdMtDVdpryNfrEfXc0C25sTEGg7r+LlBSb6IfOZH+?=
 =?us-ascii?Q?v0Y1SQvVIkeFGM00MUnvIY9kFtTv6awO1jjcKDj6jejGP4VbGVSTq56gWYse?=
 =?us-ascii?Q?p5Oo46XIV+rmHDgbybRuNphu7LOn7FDXu3Ng6J7y435nUkyUMxeP+mtTgYrd?=
 =?us-ascii?Q?FRA3mxwonYk7lfw0a6sLUgImgO0iPJQeQEnxzpMn92ZRsf2MHCIQN0xFm3Tk?=
 =?us-ascii?Q?DbAImCA3Zkp3mSIp2YHVESMve270ofNflJwkDCI2Qg+nEeAFCM1XZiofQxGJ?=
 =?us-ascii?Q?VDiTKDXwu9t19wplZjoYP+x48P3AazPsQ5NP/D9dT6vuaIc2vpzgbq8Ziylu?=
 =?us-ascii?Q?Oem90eH9QhtpNvBrDYjGs+HR+iidma6rzSaA04EQ00SR9pr7+Vbtk1P0p7nh?=
 =?us-ascii?Q?Empirg45K2+BFqqgY/U919zsaAT55lQgI2KAy6L2qsBFzCTq5MHiAfdqaRIY?=
 =?us-ascii?Q?ejcZHbOL6UD661HzF0obuk/j9iM9o29u3yaGopi6ONjpA+1SqBR+nWPRtYS1?=
 =?us-ascii?Q?8nc7Ek8on7xh9zKorLVtZ+Wrlc7redrcsSmpeiOViIWdJl9vObwB9cwWNQhk?=
 =?us-ascii?Q?jiAjb7QkGSeGesu57AmUcL1++597V4qOVzCuJPk0MOkWaTQlW7jADo1Zfdc9?=
 =?us-ascii?Q?3OHR+9OPUa4mn3VvqjRr+uitaki5iBqPmqGjGBFiiJMsbG/Oz4PjegVaBHCU?=
 =?us-ascii?Q?9fspKUO4S9JX02eFAMjS9H2xgQqBEukOSk13z4Zat2av/7tlt3wYciZeh683?=
 =?us-ascii?Q?SU6Vi+b2xEHWZAwU911+fGf0EWLVS39/AS5pJSY+9tS9Cw62V9tjLk3QLojg?=
 =?us-ascii?Q?PL8Wp7c3Lg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3819.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13c07491-ab4c-408b-8174-08da272ce153
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2022 02:31:33.8580
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BBst7C+Nmv4DnUKKLgGp9cwIQV+AFrCVtiz6sMhlclX6PI7JinolMmY5GkO40brEUpw5CBFQS478l0wGfxH6cQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3878
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> >>> -----Original Message-----
> >>> From: Zhang, Tianfei <tianfei.zhang@intel.com>
> >>> Sent: Tuesday, April 12, 2022 2:24 PM
> >>> To: Wu, Hao <hao.wu@intel.com>; trix@redhat.com; mdf@kernel.org; Xu,
> >>> Yilun <yilun.xu@intel.com>; linux-fpga@vger.kernel.org;
> >>> gregkh@linuxfoundation.org
> >>> Cc: linux-kernel@vger.kernel.org; Matthew Gerlach
> >>> <matthew.gerlach@linux.intel.com>; Zhang, Tianfei
> >>> <tianfei.zhang@intel.com>
> >>> Subject: [PATCH v2] uio: dfl: add HSSI feature id
> >>>
> >>> From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> >>>
> >>> Add the feature id of the OFS HSSI (High Speed Serial Interface)
> >>
> >> We still don't see any description on what OFS is here, or will OFS be=
 added to
> >> title as well? we don't expect another submission with the same title =
but for
> XXX
> >> HSSI again.
> >
> > This name of HSSI module in dfl feature id table is : OFS HSSI subsyste=
m.
> >
> > How about this tile:
> > uio: dfl: add OFS HSSI device id
> >
> > Add OFS HSSI (Open FPGA Stack High Speed Serial Interface) device ID in
> uio_dfl driver for Intel PAC N6000 Card.
>=20
> Hi Tianfei,
>=20
> In the Platform Designer tool, this IP block is referred to as the HSSI
> Subsystem.  I think we should use the same name here.  Additionally, this
> subsystem is already in use in multiple cards; so I suggest dropping
> any reference to a particular card.

The only concern is that there are 4 HSSI in the feature id table.=20
Without any prefix, it may confuse people.=20
https://github.com/OPAE/dfl-feature-id

>=20
> Matthew
>=20
> >
> >>
> >>> subsystem to table of ids supported by the uio_dfl driver. HSSI
> >>> subsystem consists of harden/soft Ethernet MAC to support various
> >>> ethernet usages and PCS/FEC/PMA direct modes for non-ethernet usages.
> >>>
> >>> We leverage the uio_dfl driver to access the HSSI subsystem on user
> >>> space, because the HSSI subsystem was designed for specific purposes
> >>> and does not fit into the standard MAC and net kernel subsystems.
> >>>
> >>> The Feature ID table of DFL can be found:
> >>> https://github.com/OPAE/dfl-feature-id
> >>
> >> Why you put it here? even this link there is no more descriptions to
> understand
> >> what it is. Or can be removed here.
> >
> > Yes, I agree, I will remove it.
> >>
> >>>
> >>> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> >>> Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> >>> ---
> >>> v2: add HSSI introduction and the git repo of Feature ID table.
> >>> ---
> >>>  drivers/uio/uio_dfl.c | 2 ++
> >>>  1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c index
> >>> 89c0fc7b0cbc..660e1d0bf6b9 100644
> >>> --- a/drivers/uio/uio_dfl.c
> >>> +++ b/drivers/uio/uio_dfl.c
> >>> @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev)
> >>> }
> >>>
> >>>  #define FME_FEATURE_ID_ETH_GROUP	0x10
> >>> +#define FME_FEATURE_ID_OFS_HSSI		0x15
> >>>
> >>>  static const struct dfl_device_id uio_dfl_ids[] =3D {
> >>>  	{ FME_ID, FME_FEATURE_ID_ETH_GROUP },
> >>> +	{ FME_ID, FME_FEATURE_ID_OFS_HSSI },
> >>>  	{ }
> >>>  };
> >>>  MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
> >>> --
> >>> 2.26.2
> >
> >