Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Marcelo Tosatti <mtosatti@redhat.com>, linux-kernel@vger.kernel.org
Cc:     Nitesh Lal <nilal@redhat.com>,
        Nicolas Saenz Julienne <nsaenzju@redhat.com>,
        Frederic Weisbecker <frederic@kernel.org>,
        Christoph Lameter <cl@linux.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Alex Belits <abelits@belits.com>, Peter Xu <peterx@redhat.com>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Oscar Shiang <oscar0225@livemail.tw>
Subject: Re: [patch v12 06/13] procfs: add per-pid task isolation state
In-Reply-To: <20220315153313.997111717@fedora.localdomain>
Date:   Tue, 26 Apr 2022 01:27:32 +0200
Message-ID: <87v8uwzqu3.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Tue, Mar 15 2022 at 12:31, Marcelo Tosatti wrote:
> Add /proc/pid/task_isolation file, to query the state of
> task isolation configuration.
>
> ---

Lacks a Signed-off-by...

>  fs/proc/base.c |   68 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++

> +#ifdef CONFIG_TASK_ISOLATION
> +
> +struct qoptions {
> +	unsigned long mask;
> +	char *name;
> +};
> +
> +static struct qoptions iopts[] = {
> +	{ISOL_F_QUIESCE, "quiesce"},
> +};
> +#define ILEN (sizeof(iopts) / sizeof(struct qoptions))

Reinventing ARRAY_SIZE() just because this isolation muck is special?

> +static struct qoptions qopts[] = {
> +	{ISOL_F_QUIESCE_VMSTATS, "vmstat_sync"},
> +};
> +#define QLEN (sizeof(qopts) / sizeof(struct qoptions))

Ditto.

> +static void show_isolation_state(struct seq_file *m,
> +				 struct qoptions *iopt,
> +				 int mask,
> +				 const char *hdr)
> +{
> +	int i;
> +
> +	seq_printf(m, hdr);
> +	for (i = 0; i < ILEN; i++) {
> +		if (mask & iopt->mask)
> +			seq_printf(m, "%s ", iopt->name);
> +		iopt++;
> +	}
> +	if (mask == 0)
> +		seq_printf(m, "none ");
> +	seq_printf(m, "\n");
> +}
> +
> +int proc_pid_task_isolation(struct seq_file *m, struct pid_namespace *ns,
> +			    struct pid *pid, struct task_struct *t)

This is required to be global without a prototype because?

> +{
> +	int active_mask, quiesce_mask, conf_mask;
> +	struct task_isol_info *task_isol_info;
> +	struct inode *inode = m->private;
> +	struct task_struct *task = get_proc_task(inode);
> +
> +	task_isol_info = t->task_isol_info;
> +	if (!task_isol_info)
> +		active_mask = quiesce_mask = conf_mask = 0;
> +	else {
> +		active_mask = task_isol_info->active_mask;
> +		quiesce_mask = task_isol_info->quiesce_mask;
> +		conf_mask = task_isol_info->conf_mask;
> +	}
> +
> +	show_isolation_state(m, iopts, conf_mask, "Configured state: ");
> +	show_isolation_state(m, iopts, active_mask, "Active state: ");
> +	show_isolation_state(m, qopts, quiesce_mask, "Quiescing: ");

And once you have 10 features with 10 subfeature masks supported, all of
this ends up in fs/proc/base.c just because all of this nonsense is
required to be disconnected from the actual task isolation code, right?

Just because a lot of crap has been dumped over time into that file does
not justify to mindlessly dump more crap into it.

Thanks,

        tglx