Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e30f95c3-ab55-bb1b-75c1-8bd2f91787b5@oracle.com>
Date:   Tue, 26 Apr 2022 11:43:38 +1000
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH v8 01/10] kernfs: Remove reference counting for
 kernfs_open_node.
Content-Language: en-US
To:     Tejun Heo <tj@kernel.org>
Cc:     viro@zeniv.linux.org.uk, gregkh@linuxfoundation.org,
        ebiederm@xmission.com, linux-kernel@vger.kernel.org
References: <20220410023719.1752460-1-imran.f.khan@oracle.com>
 <20220410023719.1752460-2-imran.f.khan@oracle.com>
 <YmLRxWUnF/zflEO2@slm.duckdns.org>
From:   Imran Khan <imran.f.khan@oracle.com>
In-Reply-To: <YmLRxWUnF/zflEO2@slm.duckdns.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlVNUVM4b0NJTllCY3JKYUcxTXRhcnA0MVIxN3RTS2t0VUVtbGNuRmxKQ2Q2?=
 =?utf-8?B?TFRjTDRjYmlvZ0Ywa1lzVDg5WmhMclNzc3JyNUprVkxxOXRwT1ZsUlo2NGFo?=
 =?utf-8?B?UFFnQ1BQTUh2ajg5ZFVZSk1ac1Y5b3RYQTlLNlZZSGt2ZWZOMUZMalhEanhz?=
 =?utf-8?B?ejRENnNkbmdWd2phTXJQK1o3VlRkNDNWaXVhQUxZZVJiRFNlTzZ3S2hQeEg5?=
 =?utf-8?B?WFZnWUk3WHpOaTNTOWs4UUdNME9sYjFVNXUxKzlOVTUwN2VLYTB1enM4bURZ?=
 =?utf-8?B?NVlHQ2RMcUE4Zk9tcU9CSFlTZkJhWTV4a211dUpwZXhkQnZFUnVJc2tBcThI?=
 =?utf-8?B?WDY5cDVyYlF1U1FJM1JMV1J6Q1VnZ0R6NEV1Mk40Tm5mWWk1aVFBeGFtWnp1?=
 =?utf-8?B?U1dkZVVyd3dBY3JyUW1QWVFPTXZEQnlwdm5rSVRMYkMvaHliS2JySmlxb05v?=
 =?utf-8?B?WStuaWNVc1JURlU1RDM0ZVZpcHZoampaNHJzTHRMMVRib1prOUUvNmlpNlls?=
 =?utf-8?B?V2NCd2s1NVc0S2xRcVR6RlByVkVjZUhnQ1RjY3BMRXZaMS9mMXJDSWp6azEr?=
 =?utf-8?B?QmluMjlJZG5XYWdxZzJqSkQ0ZHB5dUdVOTFsckVoQnd4UzdvUzJoSE84d0tu?=
 =?utf-8?B?OEpmQXpjUDd4Sk92V1pGM2lKZW02NnVVbGRscy92Y3FhN2FYYmI4L3ZRclZM?=
 =?utf-8?B?Qm5nUmpoZzF4blRnWVFWaXBJRUNWZlNIS2E4UFhQSjExcU15MHJrVzBwcDBC?=
 =?utf-8?B?OWZFRE4yb0g5ZHFPQS9CbEtTVklHbGxrWThDaFcrajFURlVxTE9pbFpJaDZv?=
 =?utf-8?B?Y3VFZGlmTGxLY2RybnhsTENEc2VGNUdpTndIMmVyMnd3djhpL09Od0s3dVpn?=
 =?utf-8?B?YUR0a3drU0VmSXBDZ2VKak1NQ2hJc1A1MDJUVlBtZWxJOEs1bEd2RVRZOWRs?=
 =?utf-8?B?OFp1ek9PcWxGbmRBUXZlRTdHd2dHdEpSc1dIYnJJWXpmRzMrRzk1NDByZmNY?=
 =?utf-8?B?R2N6dUxhRDVwUTl0YlphTGF0U1pjQ3F6V2VKRlYxTmRzcHFDR3BXazU0bEhr?=
 =?utf-8?B?azNMMUV6blRHTDcrWmtjQitjOFA4eXVrNGdHNDRkTERMWHR4REpiWDNsYjBx?=
 =?utf-8?B?UUNRM2RkZ3pjdFU5QllZQWZKSWpmVENtekVWalFFMXFpMWRoOWpwQmdYYTFI?=
 =?utf-8?B?TGgrYlpPdmtUZ3BWUEV1M2hyODN0SFRZQW5CYkZqbDd4Zjg1N1hTRlFkdi9V?=
 =?utf-8?B?blZIWXNTUHNHSzNoTFhQOVlxRTBrODN2dURTeWhLS1Y3dnk2eUI1YWxFNlk3?=
 =?utf-8?B?NjVVcVVrb2dpZEtoUkRXOWlPczd3c2pmWkJzMG1HdzJka1B2OFJndHNMdFZZ?=
 =?utf-8?B?ZThCQ2kwTXJ3MVA4Uk1GamlIVnRIckVGWklMTnFkQlRTeUJwUjZNdXhNOXpV?=
 =?utf-8?B?N3V4ajFzVzVaTGtZUk1YRDVEaXpDamVKd0YydktQS2VUellYKytiRDRYRHpQ?=
 =?utf-8?B?M1d3S0FoUk9Pc2JMM2kzRHVHZkZhaUtJdjhBKzZ1aGYyMy9zWG1xWHhWVzhn?=
 =?utf-8?B?UjhvbUg2R2drSjd0bkc2TUZmUURYc0N5NmR5NGtGOHNhdGVjSmQ3bXE1eXJu?=
 =?utf-8?B?YUtja2JZWTBLcjdXVGRkMWx1NGZsYS9RY1JCbjZmYnRYTlhWUFBNNXBIeDZJ?=
 =?utf-8?B?RXl1OWNJbUJDK1R0d3NsQmZmZ1dmajdCNnpQcTE4SEs3MFlZeEcwZzlJaWV4?=
 =?utf-8?B?RzBCSVl0YktJSmJMeEc3Q0RKN0MwUUExYXkxK0pKa1hSdnduMEZ1OWNRcm5M?=
 =?utf-8?B?cU43d3g3T2ZtcHpEM3A1UGxFMVJSbk5oMUxlYXFIeGNkUE14bWE2V2pGRWRN?=
 =?utf-8?B?b1hRMjBTbnlxTGJUcWtReTNsTCtWSFBRSWRsaDI3MnlRa0lmdEo4SnViYnNZ?=
 =?utf-8?B?RVZ5Njl0TnpjWDI5eTFBQ2xQc2Q5aldmZVFWaVpuSmRSZEorQ3JnelVUcHVm?=
 =?utf-8?B?MnlleXY3cVBHWUVFSXJCRU5VaDBjbnl3Y1Rreks5NXhHZXlhMjdvOW54bUVI?=
 =?utf-8?B?RDRsb2QvYVVJS1dGUUJXeXJ6clZPNk5vNjZveVBhQXdPS0hkRnNVTUh0NHhW?=
 =?utf-8?B?azdvQktGbG5kZi9QWTJCSVdHYklQbjhBZmxzeVExNForemNYaTBFV00weGdi?=
 =?utf-8?B?VElNTEc5VHJWN2VsVkVnWWlJaW1ReDAyUDBCYjNFK2hFa2R0U2hVZ3BnMHVO?=
 =?utf-8?B?SUYrV1ViZXlvOVArVWpzMGhlSWJTQXJSSHZpTUM2ZGx5QlF1cnBmQjRVM0RI?=
 =?utf-8?B?UXZET0Fab08yZWk0SU9mTU41dlZRQlpXRWpPUGE4RXpiNkt4c1NlYVlRUUFN?=
 =?utf-8?Q?L15dKub4eJLCkYr0=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c18a0f3-9c23-4726-1f2d-08da272633ca
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 01:43:46.1545
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gANSkB1EJsXV1X2RIvWJgdgg0uX9tDFvx7W3XdPmhTYgUwdoc11QECV8cdNqfJ0nEnT31hny2XL4pgZjfn2Sag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5488
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-25_08:2022-04-25,2022-04-25 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0
 malwarescore=0 mlxlogscore=999 phishscore=0 mlxscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204260008
X-Proofpoint-ORIG-GUID: bFEaOO1bP01DRbKk30dV0Jx9ysiUKoiD
X-Proofpoint-GUID: bFEaOO1bP01DRbKk30dV0Jx9ysiUKoiD
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Tejun,

On 23/4/22 2:03 am, Tejun Heo wrote:
> On Sun, Apr 10, 2022 at 12:37:10PM +1000, Imran Khan wrote:
>> @@ -768,15 +765,15 @@ void kernfs_drain_open_files(struct kernfs_node *kn)
>>  	if (!(kn->flags & (KERNFS_HAS_MMAP | KERNFS_HAS_RELEASE)))
>>  		return;
>>  
>> -	spin_lock_irq(&kernfs_open_node_lock);
>>  	on = kn->attr.open;
>> -	if (on)
>> -		atomic_inc(&on->refcnt);
>> -	spin_unlock_irq(&kernfs_open_node_lock);
>>  	if (!on)
>>  		return;
>>
>>  	mutex_lock(&kernfs_open_file_mutex);
>> +	if (!kn->attr.open) {
>> +		mutex_unlock(&kernfs_open_file_mutex);
>> +		return;
>> +	}
> 
> What if @on got freed and new one got allocated between the lockless check
> and the locked check? Is there a reason to keep the lockless check at all?
> 

The only reason for lockless check is to opportunistically check and
return if ->attr.open is already NULL, without waiting to acquire the
mutex. This is because no one will be adding to ->attr.open at this
point of time.
But we can live with just the locked check as well.
Please let me know if you think of lockless check as an overkill in this
case.

Thanks
 -- Imran