Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <097f369b-3f3c-9eb6-a446-24f46e4ec59f@gmail.com>
Date:   Mon, 25 Apr 2022 10:01:58 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: ctcm: rename READ/WRITE defines to avoid redefinitions
Content-Language: en-US
To:     Alexandra Winter <wintera@linux.ibm.com>,
        Wenjia Zhang <wenjia@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>
Cc:     Christian Borntraeger <borntraeger@linux.ibm.com>,
        linux-s390@vger.kernel.org,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <ae612043-0252-e8c3-0773-912f116421c1@gmail.com>
 <3572a765-17b4-b2df-e3d5-0d30485c4c67@linux.ibm.com>
From:   "Colin King (gmail)" <colin.i.king@gmail.com>
In-Reply-To: <3572a765-17b4-b2df-e3d5-0d30485c4c67@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 25/04/2022 09:38, Alexandra Winter wrote:
> 
> 
> On 24.04.22 20:58, Colin King (gmail) wrote:
>> Hi,
>>
>> static analysis with cppcheck detected a potential null pointer deference with the following commit:
>>
>> commit 3c09e2647b5e1f1f9fd383971468823c2505e1b0
>> Author: Ursula Braun <ursula.braun@de.ibm.com>
>> Date:   Thu Aug 12 01:58:28 2010 +0000
>>
>>      ctcm: rename READ/WRITE defines to avoid redefinitions
>>
>>
>> The analysis is as follows:
>>
>> drivers/s390/net/ctcm_sysfs.c:43:8: note: Assuming that condition 'priv' is not redundant
>>   if (!(priv && priv->channel[CTCM_READ] && ndev)) {
>>         ^
>> drivers/s390/net/ctcm_sysfs.c:42:9: note: Null pointer dereference
>>   ndev = priv->channel[CTCM_READ]->netdev;
>>
>> The code in question is as follows:
>>
>>          ndev = priv->channel[CTCM_READ]->netdev;
>>
>>          ^^ priv may be null, as per check below but it is being dereferenced when assigning ndev
>>
>>          if (!(priv && priv->channel[CTCM_READ] && ndev)) {
>>                  CTCM_DBF_TEXT(SETUP, CTC_DBF_ERROR, "bfnondev");
>>                  return -ENODEV;
>>          }
>>
>> Colin
> 
> Thank you very much for reporting this, we will provide a patch.

Thanks for working on a fix. Much appreciated.

> 
> Do you have any special requests for the Reported-by flag? Or is
> Reported-by: Colin King (gmail) <colin.i.king@gmail.com>
> fine with you?
> 

Can I have:

Reported by: Colin Ian King <colin.i.king@gmail.com>

Thank you!

Colin

> Kind regards
> Alexandra