Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Adam Manzanares <a.manzanares@samsung.com>
To:     Davidlohr Bueso <dave@stgolabs.net>
CC:     "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "mhocko@kernel.org" <mhocko@kernel.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "rientjes@google.com" <rientjes@google.com>,
        "yosryahmed@google.com" <yosryahmed@google.com>,
        "hannes@cmpxchg.org" <hannes@cmpxchg.org>,
        "shakeelb@google.com" <shakeelb@google.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "tim.c.chen@linux.intel.com" <tim.c.chen@linux.intel.com>,
        "roman.gushchin@linux.dev" <roman.gushchin@linux.dev>,
        "gthelen@google.com" <gthelen@google.com>,
        Heekwon Park <heekwon.p@samsung.com>,
        Jongmin Gim <gim.jongmin@samsung.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/6] drivers/base/node: cleanup register_node()
Thread-Topic: [PATCH 1/6] drivers/base/node: cleanup register_node()
Thread-Index: AQHYUVRPCSx4CL5jbUm8oG94siTkjq0Buu6A
Date:   Mon, 25 Apr 2022 22:30:57 +0000
Message-ID: <20220425223050.GA147460@bgt-140510-bm01>
In-Reply-To: <20220416053902.68517-2-dave@stgolabs.net>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C1D3122BB7B4C84AA59E81DD72B78789@ssi.samsung.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
CMS-TYPE: 301P
References: <20220416053902.68517-1-dave@stgolabs.net>
        <CGME20220416053912uscas1p2df42c3e74997a1443a9a38450dae89a9@uscas1p2.samsung.com>
        <20220416053902.68517-2-dave@stgolabs.net>
Precedence: bulk

On Fri, Apr 15, 2022 at 10:38:57PM -0700, Davidlohr Bueso wrote:
> Trivially get rid of some unnecessary indentation.
>=20
> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
> ---
>  drivers/base/node.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>=20
> diff --git a/drivers/base/node.c b/drivers/base/node.c
> index ec8bb24a5a22..6cdf25fd26c3 100644
> --- a/drivers/base/node.c
> +++ b/drivers/base/node.c
> @@ -661,16 +661,16 @@ static int register_node(struct node *node, int num=
)
>  	node->dev.bus =3D &node_subsys;
>  	node->dev.release =3D node_device_release;
>  	node->dev.groups =3D node_dev_groups;
> -	error =3D device_register(&node->dev);
> =20
> -	if (error)
> +	error =3D device_register(&node->dev);
> +	if (error) {
>  		put_device(&node->dev);
> -	else {
> -		hugetlb_register_node(node);
> -
> -		compaction_register_node(node);
> +		return error;
>  	}
> -	return error;
> +
> +	hugetlb_register_node(node);
> +	compaction_register_node(node);
> +	return 0;
>  }
> =20
>  /**
> --=20
> 2.26.2
>


Looks good.

Reviewed by: Adam Manzanares <a.manzanares@samsung.com>=