Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp3370119ioa; Tue, 26 Apr 2022 02:09:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQwYdfbYNNkFORoAxi8Cz7+4DdeC2XiCofX+lvMRdSaCjKxFzAsWz9TxYFJgkcWgGMucac X-Received: by 2002:a17:907:3f1c:b0:6f3:98ab:4735 with SMTP id hq28-20020a1709073f1c00b006f398ab4735mr8067374ejc.547.1650964151585; Tue, 26 Apr 2022 02:09:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650964151; cv=none; d=google.com; s=arc-20160816; b=PjyRlSIVFIJncG8Wg0itJG3NnNeaKDRTc0t6EMQqPYftcXdcUCW4GLwC/XNRsmIi+K DBykiraaRpTVyOMFlo4zJtKHvnLHU0dEP5Obj/MGQ6yoN9ZB95wJfdz7gOKshbQPCayO dP3mt0ny7wnexf7v0EUTVoWvWU9+gPH2t/3il/IHyBaCdpeM4ylHIKvKXi97fEXAiU3Y LRB/rpGZOL1f1BpUsBaPOgawPDN/22uBkB8cAjlGbMHWUGlFDvzAd30gkAQ86nIIbm5p gXZN+UrDREJ9MRyNSYHp33kjUbda/3FfCptfFmYuiZ6J2JrIaakIVO/ElAQyTPYX1Gpq nPRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=YtF2I6bZ2CqMK9GSqQlDwN70ct9X7AOPMuRUyJ5XD34=; b=SYtv40eXcIU69xOVBUErVNNVJGSH96m4Q8GG5N9jB0PnFvJqUPqRVzpqY7pN8haV5u pGtaPZbv1VSaCtvi0v/TaR/OXvWpj8bIjinilrijsuxWzclOt94KVGEjYICCXD0L+iOy SgDxX0eSeVNGa04oUBN1MU+7e9Hy5pIm4220+nAxm9442mTmXWKFJNdOEIKHoCAq374z DvKPs2LpjO+4LyZphNZT0TaHFuwlbom0OhN30JRZ+VPQx+xhweDkrP6aRlmXYcHzR42i w8S0s1YYal6zdcI2wwCgMeB71/+pXPAMO3DTwKttSUvjwHr3r6W9gtmbPGuUxGTKfHSd 8VQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2021-07-09 header.b=sYbDhuD0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z7-20020a50f147000000b00425c6ad47edsi8925992edl.291.2022.04.26.02.08.46; Tue, 26 Apr 2022 02:09:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2021-07-09 header.b=sYbDhuD0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239761AbiDZEEI (ORCPT + 99 others); Tue, 26 Apr 2022 00:04:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243660AbiDZED5 (ORCPT ); Tue, 26 Apr 2022 00:03:57 -0400 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D50E12633; Mon, 25 Apr 2022 21:00:51 -0700 (PDT) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23Q3rX19022277; Tue, 26 Apr 2022 04:00:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2021-07-09; bh=YtF2I6bZ2CqMK9GSqQlDwN70ct9X7AOPMuRUyJ5XD34=; b=sYbDhuD06ibuX53ceYl1TpdxTecDYDAYljQAxG0tA/9dVQsSgEyQ3w/3sLBjHGiQ1nIG m/Q+dwEe4+zZgeS1A8FhtsaJ1z7doEqLU0t8o26SoycRjkqhiQFRbfgcDCvsTb8YJyGH SK74kkz32doy/CsgfQX0qn7qJsTWHW4WnyCWn3cmpFW/OQhOhw7BXdnTk3eWq9cHfAa9 xbrrBFni07XURnU48NQ3jfrudz9xavw0A6b67dlbjI4ie5q91Q14fG/qlmK/tcacisJn cSNRkzITq2AQou9N3SDDLBTAJ0q64HgAgW8NWd/CaJuOzB09pprq3BmwZSeqqUgNrQt5 tQ== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3fmaw4d0br-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Apr 2022 04:00:46 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 23Q40RBG029582; Tue, 26 Apr 2022 04:00:46 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3fp5yj3v1a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Apr 2022 04:00:46 +0000 Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 23Q40juP030030; Tue, 26 Apr 2022 04:00:45 GMT Received: from ca-mkp.mkp.ca.oracle.com (ca-mkp.ca.oracle.com [10.156.108.201]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3fp5yj3v10-1; Tue, 26 Apr 2022 04:00:45 +0000 From: "Martin K. Petersen" To: linux-scsi@vger.kernel.org, "James E.J. Bottomley" , Hannes Reinecke , Yihao Han , linux-kernel@vger.kernel.org Cc: "Martin K . Petersen" , kernel@vivo.com Subject: Re: [PATCH] scsi: fcoe: simplify if-if to if-else Date: Tue, 26 Apr 2022 00:00:40 -0400 Message-Id: <165094528687.21993.818175220673009011.b4-ty@oracle.com> X-Mailer: git-send-email 2.35.2 In-Reply-To: <20220408081237.14037-1-hanyihao@vivo.com> References: <20220408081237.14037-1-hanyihao@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: 0wzTlgmboAoNDySwbRc0ekE62d_lRvHP X-Proofpoint-ORIG-GUID: 0wzTlgmboAoNDySwbRc0ekE62d_lRvHP X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 Apr 2022 01:12:37 -0700, Yihao Han wrote: > Replace `if (!is_zero_ether_addr(mac))` with `else` for simplification > and add curly brackets according to the kernel coding style: > > "Do not unnecessarily use braces where a single statement will do." > > ... > > [...] Applied to 5.19/scsi-queue, thanks! [1/1] scsi: fcoe: simplify if-if to if-else https://git.kernel.org/mkp/scsi/c/65db22e505c4 -- Martin K. Petersen Oracle Linux Engineering