Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220425055935.458583-1-starzhangzsd@gmail.com>
 <7558ae3d-a1fa-6c11-cccd-ad0f65cde25b@intel.com> <20220425182456.GL2731@worktop.programming.kicks-ass.net>
 <20220425192856.GG2762@worktop.programming.kicks-ass.net>
In-Reply-To: <20220425192856.GG2762@worktop.programming.kicks-ass.net>
From:   Stephen Zhang <starzhangzsd@gmail.com>
Date:   Tue, 26 Apr 2022 09:23:30 +0800
Message-ID: <CANubcdWq5hN8HSs8KhzhipzzjTver0CafHL6uXfyAEVOtmsS2A@mail.gmail.com>
Subject: Re: [PATCH] x86/traps: add CONFIG_BUG to the use of __warn()
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Dave Hansen <dave.hansen@intel.com>, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        x86@kernel.org, hpa@zytor.com, laijs@linux.alibaba.com,
        lihuafei1@huawei.com, fenghua.yu@intel.com,
        chang.seok.bae@intel.com, zhangshida <zhangshida@kylinos.cn>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> As pointed out by Boris, __warn is actually uncondtionally defined in
> panic.c, the below seems to build.
>
> ---
> diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
> index edb0e2a602a8..ba1f860af38b 100644
> --- a/include/asm-generic/bug.h
> +++ b/include/asm-generic/bug.h
> @@ -21,6 +21,12 @@
>  #include <linux/panic.h>
>  #include <linux/printk.h>
>
> +struct warn_args;
> +struct pt_regs;
> +
> +void __warn(const char *file, int line, void *caller, unsigned taint,
> +           struct pt_regs *regs, struct warn_args *args);
> +
>  #ifdef CONFIG_BUG
>
>  #ifdef CONFIG_GENERIC_BUG
> @@ -110,11 +116,6 @@ extern __printf(1, 2) void __warn_printk(const char *fmt, ...);
>  #endif
>
>  /* used internally by panic.c */
> -struct warn_args;
> -struct pt_regs;
> -
> -void __warn(const char *file, int line, void *caller, unsigned taint,
> -           struct pt_regs *regs, struct warn_args *args);
>
>  #ifndef WARN_ON
>  #define WARN_ON(condition) ({                                          \

Thanks.I will make a new version based on this suggestion.