Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <64ef5a2f-4421-3509-4919-b9c2173a5f17@oracle.com>
Date:   Mon, 25 Apr 2022 12:08:45 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] jfs: remove unused pointer tblk
Content-Language: en-US
To:     Dan Carpenter <dan.carpenter@oracle.com>,
        Colin Ian King <colin.i.king@gmail.com>
Cc:     jfs-discussion@lists.sourceforge.net,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220424161330.1360068-1-colin.i.king@gmail.com>
 <20220425144804.GP2462@kadam>
From:   Dave Kleikamp <dave.kleikamp@oracle.com>
In-Reply-To: <20220425144804.GP2462@kadam>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eitsS09laHlYS0lwMklic0RZN1JGTHN4bzRZRG5wNDFHUXR3QitORGVjYlZn?=
 =?utf-8?B?TlBPanpha0I4RHVBcFFBRTJnQVhyK053Z0I3all6VkxhM0U2WURMcmRXVTdp?=
 =?utf-8?B?dlZyQVM3NTNkZDRQV2Qrd05ZZ1Eyc0RTdGQ5eXd6ZWtHcjVlQUQrWkExWk51?=
 =?utf-8?B?SzF5dStlRnFYdGl0S2I1VTIvNlNDTW43R3RkeDdvTCtnOGlOYUZ3WlV3eHhk?=
 =?utf-8?B?VnhJNURTZnliZ2hhSzM2eUVyRVZzOTFqcE51VEkvei91SFpjMmR3bUViZEJP?=
 =?utf-8?B?MFpMUksvcnFIUXhyMlFNNWNoVnYrd2UxVnRnaEtkNEYyN1hUd3FPMFdjWENN?=
 =?utf-8?B?RDJXU21Ka25DcExaeVZCQU9kKzdWSDlqRDJWQ3NoYXA1NXE4V1JGMlMrMFN2?=
 =?utf-8?B?RnZoTnFzMHcwQTd2U1VBM3A3NW12bFFOKzdQMm53TVV6UzFUMThxN1ZkWGNU?=
 =?utf-8?B?RmZvZE42RDQ2aXdJQ0QvSEZ6RTNhL3B3NGR5VTV0WWNmMHRXZ1A4K2NWTXZ6?=
 =?utf-8?B?cGcxS01MTTRiK3NxQ2VZS1NBM1dZemNpRGwrdTBhL1B3cHM4MlJwd3JvNCtz?=
 =?utf-8?B?K3FwSzdZUWtTR0dQQm92dW1palFqdVB4VFJlbWduUU9CRVMweFhZOWZFVTl0?=
 =?utf-8?B?L255a2o2eG9sSmRXcHo5ejExWTRhVjJSeU1UMkpjeHFHOHhIeitIMDM5K1R3?=
 =?utf-8?B?M1RtUVNMdlZ1STYrdGh2cFIzN1hmSkhxVWxYRHJnblhyTU43czFzbDQ4eHZj?=
 =?utf-8?B?N2owL2NRY3hhR1hEUWNZN2QzMVE0dlN6bjdyZ2lHQm1UVlh2UFR2SGlsL2Zq?=
 =?utf-8?B?NlNZYTgrWk8zaDBvakE3cUtUelhPOUQ3Zk5yODRiUzRMbjRwcFpZRXVYbi9n?=
 =?utf-8?B?cFBDak0xMzFjUk9GMjZtditPUUt4MGV6Z2tsZnh2aUlaR2phbXp2ZFVTcXJZ?=
 =?utf-8?B?Nm9teXVpYXd4VmhuRGczM0Zna0lVUU45cjVmaTZ0L0QybUhKUDcyOHFnSnJi?=
 =?utf-8?B?WUdUR1lRZHdnRGUvK2Nxa1dJNEh2OHFNRFZnaG00UzBicGhOTzhVU09TUVlj?=
 =?utf-8?B?dnBtdWJDVms1c1ZUNzl5TUMrZDZzUzhmN3hEV1JYRkk4Wms2YWtsWDdWaUE0?=
 =?utf-8?B?SXUxTitoRnBDblVpd0xYWTZwd1JUbW5BeWtnbG9sdS9aUUQ2T0dtWE9EdHVq?=
 =?utf-8?B?Y0R0YUtGRkhNK0RNZEFBU1g2aWlud2d0UWd6TlJ1bnFKSkhwWDdRREpJZ25o?=
 =?utf-8?B?c1JqNW5XWXY2K2Y4K1VMbllRQ3ZYWFlHc29pMkJaaS9tMlloNjVvYVpZMHdR?=
 =?utf-8?B?Q09LSm1JZWwrRXU0VXBCNzRWY3FkRld4UGd0blFnSXpud3RkVDJmV2VtSEhP?=
 =?utf-8?B?Sitnc2d3b1ozSmVYS0lWMHpubnFTc2lMRTNKNkRpeVdpMlpVTmpYNlFQRm1k?=
 =?utf-8?B?bSsycDZKZDF4czdCSGM0ZVlZM1Vxc1dVenZOVXlQRHNlUzNTdFNJU0huU0JV?=
 =?utf-8?B?bVM5d0owU3RSdlRnd2ZWQWkxOUNBWXVPYitlTlVFQ1FuV09GMVpHQ09JSVVs?=
 =?utf-8?B?b05QSGRSdFIxaGd3aG11K1p6d05ncS9XTldud2NZQ2MrWWp0Y2dXWVpRa2dX?=
 =?utf-8?B?eWo3TmZ5cmRyUXpKRkZnQk5FcWtrMTdTcTBFM3FJQllmbno4L2lPb29zUGQ1?=
 =?utf-8?B?eFVmb2oxcjdxM0JncUZLaHpCdjRnNmxvODRhYVhabE1SaGZGK25sRWNJR2FT?=
 =?utf-8?B?WUJDTnM2UjVvcU1Ma1NRVnVZQ0dsc2RzdmtLY2s4Nkp4SDhrUVh6cm5SdUxU?=
 =?utf-8?B?Ykh5blVFeHM3cUJCdmswQVdHblkzVm9hS3RZZEJrWU1tbzlIYVhyd3RJRXR0?=
 =?utf-8?B?bFB6OTlGTU9SZkh0L2RicmVMY24ydnR1K3QxTHo3MUdJZkV2cHBaSmUxMmw4?=
 =?utf-8?B?aURNRXE2SWVRaGNEbVBnUGRFbUEydTAxTmtKS2NFeW05QVRpcmlDbjNHclda?=
 =?utf-8?B?Z0xIZEdFOHJLMU9tV3BGTnZFcnZVZGx0VWxQU3lndGw0anh2RnZWWld2dzJj?=
 =?utf-8?B?WVYrTUxDT3VTZUV6bFB4QlRmV1ZLTFJFL1NranFaUEw0L2hHY1F5R0JoczJM?=
 =?utf-8?B?bFppbkZWNW5LUHVIazVHQXpsa2Q1bHRzS2RJSGs1VkkyRDJJb2xmVWRiaFJQ?=
 =?utf-8?B?VTJGbWZRQk5VNzRnQVhnTFg2aTVuLzJpcHNoQU9ZMjYyVm9zazJhWkVNaVVC?=
 =?utf-8?B?QThJVktRd3VXRG8zRFNLL2FiUFI3VFJTckIzQnMxMUhReEdXVExvM2U4eGNv?=
 =?utf-8?B?cU9xOE81S0hlcnJRbFpNRGxoSCtwRXVCc2JsQjVwMG1kbXhJL3c5aXE5a2Ez?=
 =?utf-8?Q?uMSfks5gYWRZPIpY=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb7fcd84-7172-43b5-269c-08da26de42e4
X-MS-Exchange-CrossTenant-AuthSource: MW5PR10MB5738.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 17:08:47.5532
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dX/AHr5XhjfZq2r+aK8sY/T61c/tKrqA2IcdT7B80hb3rY1yve+Dz2nt5kGKNkiJANC+/83yvAyTHeIOi8CITJG+ZO6Wd1j7aBkhSvOMKNc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4611
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-25_07:2022-04-25,2022-04-25 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0
 malwarescore=0 spamscore=0 phishscore=0 bulkscore=0 mlxlogscore=848
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204250076
X-Proofpoint-GUID: jocHWTm0M1Znzx0NJzdUnLy9rvatDSps
X-Proofpoint-ORIG-GUID: jocHWTm0M1Znzx0NJzdUnLy9rvatDSps
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/25/22 9:48AM, Dan Carpenter wrote:
> On Sun, Apr 24, 2022 at 05:13:30PM +0100, Colin Ian King wrote:
>> The pointer tlbk is not used, it is redundant and can be removed.
>> Cleans up cppcheck warning:
>>
>> linux/fs/jfs/jfs_xtree.c:2551:17: style: Unused variable: tblk [unusedVariable]
>>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>> ---
>>   fs/jfs/jfs_xtree.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/jfs/jfs_xtree.c b/fs/jfs/jfs_xtree.c
>> index 3148e9b35f3b..d29979d0a6aa 100644
>> --- a/fs/jfs/jfs_xtree.c
>> +++ b/fs/jfs/jfs_xtree.c
>> @@ -2548,7 +2548,6 @@ xtRelocate(tid_t tid, struct inode * ip, xad_t * oxad,	/* old XAD */
>>   	   int xtype)
>>   {				/* extent type: XTPAGE or DATAEXT */
>>   	int rc = 0;
>> -	struct tblock *tblk;
> 
> This would have caused a build error if it weren't ifdeffed out.
> 
> #ifdef _STILL_TO_PORT
> 
> JFS is an IBM filesystem from OS/2.  Apparently, this stuff never got
> ported?  Probably we could just delete the dead code.

Yeah. Once, long ago, I had dreams of enhancing JFS with shiny new 
function like defragmentation. I think it's safe to say that isn't going 
to happen.

Shaggy

> 
> regards,
> dan carpenter
>