Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net, joe@perches.com, Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH v3] ring-buffer: simplify if-if to if-else
Date:   Tue, 26 Apr 2022 15:06:28 +0800
Message-Id: <20220426070628.167565-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?t0RI95sX7BhARtD/R+mI5YW2CjtxvXb4fxJQJxjnOW0I2hGDoYCbTmDDmYsj?=
 =?us-ascii?Q?xXjVi9jnit7prUYVDBFSNiqpnubFV5grBO86WChZAUtVVg6LVtbQbu5atkTC?=
 =?us-ascii?Q?8sp3b0qzAXJxTa0RC3Xz42qa+2GMwXvTCuFlGU24cclGF2bgPpMix/81AZcM?=
 =?us-ascii?Q?c25Mr4qbXfsRBUd6SWCLGDgPYuRYsdy27P0O9lmJUKXMb4PR8Pi+I1U4f660?=
 =?us-ascii?Q?v0or8VmilMEcF+RggG7ItXNv7T/eDplgnP47w3JJ+lV1yOXlrp/ci381Mu3V?=
 =?us-ascii?Q?dWrkjPmQa+zvLQH8p9vRFlqrNtQSCgAWhztXkpffZpmWsfxeemkIxMdXf+24?=
 =?us-ascii?Q?LWDh0ZNEcC9K821ZOtp6m8F1ck+5WaCgigIlduBwY2Te2CevwuG5+KaRpNLm?=
 =?us-ascii?Q?IIyGMlSJ0lOLMtnjWKbHZUODqOl6YEJQxNoJNGo3eihRma+7etcHhJSqaSHd?=
 =?us-ascii?Q?07SOexW/KZuidny9oML9PEZWG6oxkLTdcNMRW9w3n355cXqaQ3mWXvPIB7ng?=
 =?us-ascii?Q?6sSMKICD2eDgTkARSr+EYXRWz+HrMgb2HALuqwySarmhJl3oT96rULwhgIff?=
 =?us-ascii?Q?7fYfQWuFCViFvJ5JTxPUZ4AZH/EH5qKpmxzC7VcfPDgCPUfmH3fdbPJXoELm?=
 =?us-ascii?Q?fFfyyCQb7vm+LeGxrAEBqTw2CS3jZJ6132AcbGI8ymcT2wA3sw+QqHHSdISS?=
 =?us-ascii?Q?SpoP6og0UyRW1Xke2bjDObK72raP8mmyqevod5BFpi86cqgcTIsA5PwVLfvD?=
 =?us-ascii?Q?CgXn5Emxt12QCr5Z20U0Xxp+Hbu1qzUd4fv+g/0KGNBOnj9yJJfVbSCRzqeJ?=
 =?us-ascii?Q?RVa1Z4rYU7nPjkDj6MpcG2BvX2011b50F0cPdQvK9BvefvBHUZkmNI3TCaR4?=
 =?us-ascii?Q?qr7SLCYzehfmHRocSN/u6dnWT3CPDIiqVz5OSeBWymAniHxW904k82OZvATu?=
 =?us-ascii?Q?lmFEov2Cc9rK/SF0Jt0uFQpRQvrnKDSwfNhn6iJAPoYPU6KFBoGbHW1fbJBx?=
 =?us-ascii?Q?GZNV8dZ2l6xxX/v0lNiJ8TjLszUStLoJ8/2mbfnzjaB4AUzL1og9a/euGSY5?=
 =?us-ascii?Q?Ylz7wzvcx/Ihzl/ZVqzGBubvFSy/JpcFve2USx4+UpVWBQhd4vzYx+TTc9Ss?=
 =?us-ascii?Q?8YkFP3fioydgLiHN3owWOkxcZu+aFW5QoK0rFya1IR9edFEHHNoLgSM6UYW3?=
 =?us-ascii?Q?ckswVeFGDiHWaZkWw+4WlH1jkAskUNsx+/Ez9Aen/VOFtSZQbYOzb8AGsYiL?=
 =?us-ascii?Q?LIuE1As2QBlIX5yrmkufhUJ4Qe4PDU1x0jeq5aNdXgzHmGBACVmKaAMOKxcJ?=
 =?us-ascii?Q?pzAIF+8QxL2BCAMkMYIdK+LOjb8l1TPVCfGLalXHdfqL0cWJ+KcxYNWaNCh0?=
 =?us-ascii?Q?MCyu5VXMOAQPRvxiz/LfAbJWhkcAsPkg+Z37526czxf93DjMXrApFyZKIixK?=
 =?us-ascii?Q?3zfH2GhMV6d0yS1+0K/wfvMV1Cr+MJWcvtt89X4wNGV5mlO7dIQtsRt21VpL?=
 =?us-ascii?Q?scPX1Nidfz9mekIwHmpfJ64c6JTsa32us9OU0wUWIx0zd7WgG/h/KQ1jquPx?=
 =?us-ascii?Q?f+Bv/DBs3AWiv+9LTuloteZZmhq2HJll0dOd5NM4ndDj2Kl3HXVb86v6g76o?=
 =?us-ascii?Q?tNiLCl5abaZCl7B219+IvPUdhM7SIY7OY/SLfRqKBpxDMBIXij1KD05Flrib?=
 =?us-ascii?Q?81mTXMwRFbCa4zhAo6M8yDUx4v3GsdmqllyOlH+Kv8JFB9VPqVPyjkVkpwgr?=
 =?us-ascii?Q?mQJkULluWg=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5205f3d6-85f7-41b2-b4cc-08da2753512e
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 07:06:42.7568
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RImPiTD+l0f0THCLn2tJ7HHp4ppUZx0bkdsQntch8iwWtFDRSQZf27lxNRgFvm8fjVPo8GtHDq8incnSowRG5g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR06MB4437
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Use if and else instead of if(A) and if (!A).

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
Change log:
v2:
- add braces to the if block and make pr_info nicer.
v3:
- keep the original line breakage.
---
 kernel/trace/ring_buffer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index 05dfc7a12d3d..655d6db3e3c3 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -6011,10 +6011,10 @@ static __init int test_ringbuffer(void)
 		pr_info("        total events:   %ld\n", total_lost + total_read);
 		pr_info("  recorded len bytes:   %ld\n", total_len);
 		pr_info(" recorded size bytes:   %ld\n", total_size);
-		if (total_lost)
+		if (total_lost) {
 			pr_info(" With dropped events, record len and size may not match\n"
 				" alloced and written from above\n");
-		if (!total_lost) {
+		} else {
 			if (RB_WARN_ON(buffer, total_len != total_alloc ||
 				       total_size != total_written))
 				break;
-- 
2.35.1