Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754403AbXEHQtX (ORCPT ); Tue, 8 May 2007 12:49:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933691AbXEHQtU (ORCPT ); Tue, 8 May 2007 12:49:20 -0400 Received: from coyote.holtmann.net ([217.160.111.169]:41079 "EHLO mail.holtmann.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933855AbXEHQtT (ORCPT ); Tue, 8 May 2007 12:49:19 -0400 Subject: Re: Getting make net/built-in.o Error with 2.6.21.1 Build From: Marcel Holtmann To: Jiri Kosina Cc: Satyam Sharma , chris@pcburn.com, linux-kernel@vger.kernel.org, bluez-devel@lists.sourceforge.net, netdev@vger.kernel.org In-Reply-To: References: <463FB6B0.3070005@pcburn.com> Content-Type: text/plain Date: Tue, 08 May 2007 18:48:32 +0200 Message-Id: <1178642912.8628.70.camel@aeonflux.holtmann.net> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1863 Lines: 52 Hi Jiri, > > Sure, my aim here was to only solve the _build breakage_ by fixing the > > Kconfig for this module (that used code from another kernel module > > without listing it in its dependencies). If, as you say, the real > > solution is that we should actually be taking out the offending call to > > the other module itself, then please go ahead -- I don't know much about > > the Bluetooth / HIDP subsytem anyway. > > Converting the hid-ff drivers to be also transport-independent is on my > TODO list, but it didn't happen yet. > > Marcel - are you aware of any devices currently supported by USB HID > force-feedback code, which have a bluetooth version, please? I haven't looked at all details for the PS3 controller, but that might be the first one. In theory they can and at some point they will enter the market. > I'd propose the patch below, until I make the usbhid force-feedback code > transport independent. Thanks. > > > > From: Jiri Kosina > > [Bluetooth] HIDP - don't initialize force feedback > > The current implementation of force feedback for HID devices is > USB-transport only and therefore calling hid_ff_init() from hidp code is > not going to work (plus it creates unwanted dependency of hidp on usbhid). > Remove the hid_ff_init() until either the hid-ff is made > transport-independent, or at least support for bluetooth transport is > added. > > Signed-off-by: Jiri Kosina Signed-off-by: Marcel Holtmann Under the condition that you remember to put it back once a generic FF exists. Regards Marcel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/