Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Xiaomeng Tong <xiam0nd.tong@gmail.com>
Cc:     skashyap@marvell.com, jhasan@marvell.com,
        GR-QLogic-Storage-Upstream@marvell.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RESEND][PATCH] qedf: remove an unneeded NULL check on list
 iterator
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1o80ot3yd.fsf@ca-mkp.ca.oracle.com>
References: <20220405004055.24312-1-xiam0nd.tong@gmail.com>
Date:   Tue, 26 Apr 2022 08:38:29 -0400
In-Reply-To: <20220405004055.24312-1-xiam0nd.tong@gmail.com> (Xiaomeng Tong's
        message of "Tue, 5 Apr 2022 08:40:55 +0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wjk/YmkRqfDnOLLS164rOjvu5VKOusVGou18s1nz+fjNVp51+9JGer5nHXhm?=
 =?us-ascii?Q?qh1anRSE0vo2ItB0IDj8wRjAbVyKqFv1uHd+XhYlPqdiZDGnHud454yfEMN5?=
 =?us-ascii?Q?OzrcuIlex8cvEh/MRTGM/53IeHyS7VLUf09p0f40s2YLnFAKsrCB4w6zs2I5?=
 =?us-ascii?Q?FhilwX5SzO+L0dVW3hpKaqFMaAPkASoCHkjGyp2Lg4kCKQpqbqb5h/Pz+zAs?=
 =?us-ascii?Q?zS6ijwTPPK7LWG4ajxVMvBV2vlLZU1CanVll4vvf5OPLiZ8q/UFoYy03TJUx?=
 =?us-ascii?Q?FvhjYDwgWQlhLQM2zFX74YA/wIjWnpZV2QVNn59dVtyCHmo20vfuIbBzKuLz?=
 =?us-ascii?Q?fbXvSo5cBl8nwwPDIrGIs3ZX4h/MT40v3BOnQI9C/9aHu4ibd+o+4k6dzy4r?=
 =?us-ascii?Q?dXsSYJP/89W96/J0t8854UeetaUhuyn+gSEWi57M/DfAKq/tIXSn3V2blCdB?=
 =?us-ascii?Q?U5tZrvU45K5oOFAumqWs4koVdMRzYxzwDTwTID6iDtwfVOa+w8dA5mmTg2YP?=
 =?us-ascii?Q?STonn/b57jscgsK7rHNEJSzcWtZakT0fcdktnElU83UKaiZJGM/6hrqwVCpF?=
 =?us-ascii?Q?UKChxPqN0x7JN1btD/dAr67C5OO/Zc387vt3vwZiY/46/hTAVLJcYcXFTYqm?=
 =?us-ascii?Q?JG+Xy57krFK2YgmWOaL8CKHN0TlJ8raZb1UXMRCoSOxCmotIgLXyEUz2glyK?=
 =?us-ascii?Q?47mUrs3OXMgq73i3KdP59uZeJg5ZgbhYKLF32uBDi0Gw8n5a7IlXX1Fz1CJq?=
 =?us-ascii?Q?38SlnnoKIDQVI4oLOXIh+BfJ4KBCQCnkd/1tnF+HzS1QzmoKiE5pu9HQRNCe?=
 =?us-ascii?Q?ypbUJmFE06AO25fX+mMg75ZOOHT3xj6NFhZvvDLmqQHApU431YnuvyTCG2+U?=
 =?us-ascii?Q?eW7HuBJ46KiYbcrve5fhp2GIdoO3oB47+3f20kntUDV8grfOskJiouHCpQx5?=
 =?us-ascii?Q?6uHT1KLfUvs9NTsx4DnS5qSYjZcGIjQlAuohLtp65LF53SE+FYH2R0vhZkI7?=
 =?us-ascii?Q?hL+vYDfEE7LhIsXB/pvxY3VmelYbUtLK7ZvjzMlRWHUH63IJk7O6LxC6IghA?=
 =?us-ascii?Q?6xMQhmJTId+nNyJV2nauvY+d4rZGILNeOmt2o9hvsJNh4ubWPMaMjorfCXeJ?=
 =?us-ascii?Q?3lMBns9mxYNY6WAy8OlZy5jxGJNoUBpcIdZuCzDX2XP2xzvouAuLedKFdKt9?=
 =?us-ascii?Q?mWx99nlu8LwezcHRFysgG8AtY7KocMZhStyLpba0jHJOf27TytSti7wGOH12?=
 =?us-ascii?Q?QQj8f5x5/r5Ru1taFSs3AIeqF6XuwldD9KVCtb2NoOCBfjzZJLAPhVbFDHoI?=
 =?us-ascii?Q?1njGDss0Yu4rVcLE/Cfua2tV8mw60dNPigkC3hf5QYlyWMO6U1uap4fCc4+Y?=
 =?us-ascii?Q?fvklGVhfvH3hIbE4/nwFSIZOHWk74g5u6gDcxNBVGfuh3CgK42ZPYNy24LzX?=
 =?us-ascii?Q?moqGeKiBO7XdmAm52cwlpuJHAcjPvjXWcrmk9yYBOYP55FBScTG8ZNwp6i7o?=
 =?us-ascii?Q?a22VfgIsocTAfrqvWbYZ1jPXZb42OZQ7EdyJTCJf/YJhSRq5Mglyq8zA2yvL?=
 =?us-ascii?Q?vf1x3ygLNLN4BbAsQjZ3NmyN8ufCrMe4w6PFQa6EP7qB5rb8+9QiOESQlH3d?=
 =?us-ascii?Q?Y3be6LeWNvyRIu/LCziGvm0avC2QK25jeEwcuFABNaJmI8s5YhF4MQTDY4Rs?=
 =?us-ascii?Q?fl6hrVYC4vHHJ0I1/UNTRFLkOihSJQ7CVH/bmzbmOD/HdXh3ewnENx4nnxce?=
 =?us-ascii?Q?E73YQ4rQp/8wxgfCAK4MiaXK+Ch1O2A=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c746f366-857c-4488-1b09-08da2781ac4d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 12:38:32.3219
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LyR8uTCUqXPUsuIMrN4Jd3iDqN9dSepiKBePj+bAXHji4UHtviWZLYUa51eALnmBP0WyADV/2WFDbMP9IlxslaeMJOehV+NYrrL+pyyDEfk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4764
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-26_02:2022-04-26,2022-04-26 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 adultscore=0
 mlxscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxlogscore=573
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204260080
X-Proofpoint-ORIG-GUID: pSfk7pXKvMl0AY94FCXwkGCxgcFslz3Q
X-Proofpoint-GUID: pSfk7pXKvMl0AY94FCXwkGCxgcFslz3Q
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Xiaomeng,

> The list iterator 'fcport' is always non-NULL so it doesn't need to be
> checked. Thus just remove the unnecessary NULL check. Also remove the
> unnecessary initializer because the list iterator is always initialized.
> And adjust the position of blank lines.

Applied to 5.19/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering