Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Andrew Morton <akpm@linux-foundation.org>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        David Howells <dhowells@redhat.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Cc:     Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] mm/filemap: Fix NULL pointer dereference in pagecache_get_page
Date:   Tue, 26 Apr 2022 16:25:48 +0800
Message-Id: <20220426082549.590899-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fk73PeyQcVh5/TrjXIOCRrIa7x0uSShtF4cxddDyzc9aKxtWVP2z6nH1UxgD?=
 =?us-ascii?Q?WWwKr74f2W2ne3D8qb0iWhwD1njIqo+tVNgPlnv9QMaTRMguZAHeoAlhXMvT?=
 =?us-ascii?Q?/JC7ah3iGtezsdE5KbDVi+JsJkcbv56Ear/y8ezkYrSe7oIwzrX3amnMoCOi?=
 =?us-ascii?Q?8Spww3oiCc9kCVU0AHwq3No0opeqC7uVMV+6HBoXap5ZJK6GBCQ0DInoKmb+?=
 =?us-ascii?Q?27gplmriAgVlSmC/WwASh9TvzqTe13u8onDoSnt9F/ZyxNWGehPryfKCa94R?=
 =?us-ascii?Q?QxmNrHHetljcwaI16eMHRp6RGnciNBK6Yjef7cDlKDa+E2i/MrVDBcfo4ogg?=
 =?us-ascii?Q?VK8KcBBM6vpYFVJ/Al6PhPgaSSRvdq+pW1xJrKRaZ9nU7CEjWZF9JD4SURDE?=
 =?us-ascii?Q?8ybQBHyAANZGHlfX7It70ndlWZz8qmy7nuQso4JoB+g09J/5KxGFu5Dt5axh?=
 =?us-ascii?Q?j4mN3lltyANDRZ5GfR/UCGR+0tWs3oEtZfmjlRGfwHSG0q9d00wJaKP1QpO4?=
 =?us-ascii?Q?vcl7eQ7kfLl72YQO1wKeYD4NCHzxmVjXW+Qf71nE99yNtgJqef26qt48/G60?=
 =?us-ascii?Q?BMWC+e6PWjHnKqaI9z07STjsMDxeb/wt2E+TsLXv3PR9ABPY7+Ber3D2l4Bm?=
 =?us-ascii?Q?sgwfGYsFOP88gITsTakA8URWlsGKUa9mbWDvBVgmi2FGPnEG7F9gEmdP0BAk?=
 =?us-ascii?Q?Mp8ojSAuO9i2/qXH0RN2jIWvl2x1p5ArzaHhWUtMpwOX7DdfsTOTmVc9ZDBV?=
 =?us-ascii?Q?caOabmW3MiTLj23ml0sYfw70+hSyT0V8p4ObfAK2tkN8dhM7DKRiSHR8OnjW?=
 =?us-ascii?Q?8PQVJ3C1fjUnOXVKaWrHB5refTFUMT57H8VS+jS00g/+CBnuuSn+bIyYz7Dl?=
 =?us-ascii?Q?iqnPx/8/o/+0WBnSnonRhZbaqIbqtb53m4TUgAB+NYfaJvKtFrN40LV7zpod?=
 =?us-ascii?Q?+75+tRnh5elGIIvl6hzHZxUgr7ojDgrEJf/MmuBuHGQ9qYDMwbdBkDt5+gxX?=
 =?us-ascii?Q?BfT9wzvTiRz9QZFugpAZMLXYk1G+v1HmGgVOqtktNA9o3eg4syURDn5mT/tk?=
 =?us-ascii?Q?1D9mJWwVZ/CTASUyUb4X1VTAE7frAqBH2g16w815iBsTeTECasdXm0O5YR6X?=
 =?us-ascii?Q?NxSdD4KWLMQo9M/JOSobIBWdZIy6kEeSBTjrpA+gwis+M6uJBt+btpByV4fT?=
 =?us-ascii?Q?FFmem12OCaTGeT5NulvBh5eLk+WDxFz7tM+raHp2iur687dEX3Djxxive2RY?=
 =?us-ascii?Q?BfeF8GVKbNBDouv4wZK0LWLJlGLYmfyOyQMzanzU0Ga3NB5UnbreevlWS/pl?=
 =?us-ascii?Q?EJNTyyLPDPtx0YSE4tFzMRXkRm/oqvNhbd/FuG37X1ScDp1k+8i+BSB/SExu?=
 =?us-ascii?Q?qUX/8NXtzWSX/YLTtFHkrzZ3jPhgs8zYT75ielE48Lt/eeqxxt5ycahpSsS6?=
 =?us-ascii?Q?FrLIa3iixc3QQFuRaL5l0xSr1UGjjv5fLWR3AhFlpTxlG9GUhoZglIOtCRr7?=
 =?us-ascii?Q?W4EwC9CNAWe9b0CM6vgbVgIb8DiN0Z5ZiT96IRowXl1kNzDMntYqmn/xFnSz?=
 =?us-ascii?Q?MRKb4X9Pf/sx3DG1XdQOmrZgGZWbkfA7b5vBZLDGq/u+IJgBt2SBAFc2a5uB?=
 =?us-ascii?Q?g+MZ39yuN3gB8L+lYC9LJwh1AmdWCVeilhnVMTpXG7a+2pvWZV8nw/dxIQmy?=
 =?us-ascii?Q?fprL3PziTwL4W45SKnHylu/Yd3V37z6FL+P1O6U2jZ1VW8SafsJqhZhRDgVy?=
 =?us-ascii?Q?xkQZE6Lpjg=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cdec9c02-e6d4-4b3a-8996-08da275e6a72
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 08:26:09.5615
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /25ix0cXy5j2yhGsjdwyfW0ECH/BVw8g9IrdXtlmvm4sFy2N81B5jNnNvU8lG1fW8dtPl5PGsVwxN13ee3YNLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB3952
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck error:
mm/folio-compat.c:128:17-21: ERROR: folio is NULL but dereferenced.

'folio' would be NULL when getting a reference to a folio failed.
Add a NULL check before dereferring 'folio'.

Fixes: 3f0c6a07fee6 ("mm/filemap: Add filemap_get_folio")
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 mm/folio-compat.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/mm/folio-compat.c b/mm/folio-compat.c
index 46fa179e32fb..54b17c1246c4 100644
--- a/mm/folio-compat.c
+++ b/mm/folio-compat.c
@@ -124,7 +124,9 @@ struct page *pagecache_get_page(struct address_space *mapping, pgoff_t index,
 	struct folio *folio;
 
 	folio = __filemap_get_folio(mapping, index, fgp_flags, gfp);
-	if ((fgp_flags & FGP_HEAD) || !folio || xa_is_value(folio))
+	if (!folio)
+		return NULL;
+	if ((fgp_flags & FGP_HEAD) || xa_is_value(folio))
 		return &folio->page;
 	return folio_file_page(folio, index);
 }
-- 
2.35.3