Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <63deb092-4002-d798-410e-1db2081f0ef8@arm.com>
Date:   Tue, 26 Apr 2022 11:38:19 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] xtensa: enable ARCH_HAS_DEBUG_VM_PGTABLE
Content-Language: en-US
To:     Max Filippov <jcmvbkbc@gmail.com>, linux-xtensa@linux-xtensa.org
Cc:     Chris Zankel <chris@zankel.net>, linux-kernel@vger.kernel.org
References: <20220425180540.880632-1-jcmvbkbc@gmail.com>
From:   Anshuman Khandual <anshuman.khandual@arm.com>
In-Reply-To: <20220425180540.880632-1-jcmvbkbc@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Max,

Thanks for the patch. Just wondering if you ran with different config
options (which might impact test case selection) on/off during testing ?

- Anshuman

On 4/25/22 23:35, Max Filippov wrote:
> xtensa kernels successfully build and run with
> CONFIG_DEBUG_VM_PGTABLE=y, enable arch support for it.
> 
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
>  Documentation/features/debug/debug-vm-pgtable/arch-support.txt | 2 +-
>  arch/xtensa/Kconfig                                            | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/features/debug/debug-vm-pgtable/arch-support.txt b/Documentation/features/debug/debug-vm-pgtable/arch-support.txt
> index 83eafe1a7f68..ff21a83abe62 100644
> --- a/Documentation/features/debug/debug-vm-pgtable/arch-support.txt
> +++ b/Documentation/features/debug/debug-vm-pgtable/arch-support.txt
> @@ -27,5 +27,5 @@
>      |       sparc: | TODO |
>      |          um: | TODO |
>      |         x86: |  ok  |
> -    |      xtensa: | TODO |
> +    |      xtensa: |  ok  |
>      -----------------------
> diff --git a/arch/xtensa/Kconfig b/arch/xtensa/Kconfig
> index 2ed897299f19..903b910ebc10 100644
> --- a/arch/xtensa/Kconfig
> +++ b/arch/xtensa/Kconfig
> @@ -4,6 +4,7 @@ config XTENSA
>  	select ARCH_32BIT_OFF_T
>  	select ARCH_HAS_BINFMT_FLAT if !MMU
>  	select ARCH_HAS_CURRENT_STACK_POINTER
> +	select ARCH_HAS_DEBUG_VM_PGTABLE
>  	select ARCH_HAS_DMA_PREP_COHERENT if MMU
>  	select ARCH_HAS_SYNC_DMA_FOR_CPU if MMU
>  	select ARCH_HAS_SYNC_DMA_FOR_DEVICE if MMU