Date: Tue, 8 May 2007 19:26:55 +0200
From: Haavard Skinnemoen <hskinnemoen@atmel.com>
To: "Antonino A. Daplas" <adaplas@gmail.com>
Cc: linux-fbdev-devel@lists.sourceforge.net,
       Andrew Victor <andrew@sanpeople.com>,
       Linux Kernel list <linux-kernel@vger.kernel.org>,
       Patrice Vilchez <patrice.vilchez@rfo.atmel.com>,
       Nicolas Ferre <nicolas.ferre@rfo.atmel.com>
Subject: Re: [Linux-fbdev-devel] [PATCH] atmel_lcdfb: AT91/AT32 LCD
 Controller framebuffer driver
Message-ID: <20070508192655.08b1d649@dhcp-252-105.norway.atmel.com>
In-Reply-To: <1178574017.4674.30.camel@daplas>
References: <463F3388.7020102@rfo.atmel.com>
	<1178574017.4674.30.camel@daplas>
Organization: Atmel Norway
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 941
Lines: 28

Hi Antonio,

Thanks for the feedback. I'm just going to reply to one of your
comments and leave the rest for Nicolas...

On Tue, 08 May 2007 05:40:17 +0800
"Antonino A. Daplas" <adaplas@gmail.com> wrote:

> > +static int __init atmel_lcdfb_init(void)
> > +{
> > +	return platform_driver_probe(&atmel_lcdfb_driver, atmel_lcdfb_probe);
> > +}  
> 
> Is this intentional?  Why not platform_driver_register()?

Yes, it's intentional. This way, the atmel_lcdfb_probe function can be
__init since it doesn't need to be referenced from atmel_lcdfb_driver.
Saves a bit of memory at run time.

The downside is that hot plugging won't work, but that isn't very
relevant for on-chip devices anyway.

Haavard
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/