Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp3683264ioa; Tue, 26 Apr 2022 08:10:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1FJIlji5Qrwhcsl+XudEsxSAl+WIgU0fJgXpJNzkJVsPKVe/5LrpuhgKT0mV/GMUjdZhe X-Received: by 2002:a05:6870:9a17:b0:e9:3d1:f91a with SMTP id fo23-20020a0568709a1700b000e903d1f91amr8240472oab.44.1650985836093; Tue, 26 Apr 2022 08:10:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650985836; cv=none; d=google.com; s=arc-20160816; b=u6GduAlNwcrO5qpb5gt8km/+QqHK7kP6yBLA+bXinrAaraU2OVCHuiaRHdOIKAGsRV F+75LU5Vv9+9d3D0bEiniWq0rs1TUujqbyi6lx6lwXFp20Ok7bfc9tTRelDweF8SufIF EvDX/YNrWhjrhzbq8J1iBva/nlB78k8hir+Sej5JF3yfjXiz6U2Bo7XlanZKD2N30vDi ebnQbrHPnlT+ay2eUND1KCrFxYIc5654S3xi0lSP7Y3itC2jFOaIzLvpItL5dU60NDyN v+TsVGz+8i1qwBmJ93yGnN6+uMdI2FYPnWImnV/BDMxKK1e96bXsOKGkKnI63l17gH1N tdug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=OltiVbQlP4SImNFq1PB70ZwN2RbNXJqOfdKUeHRpMQM=; b=jSXlmQ12m4wKuo3mDyzb31Na6SOt/BfXx3xFId8A1pwn52gIJbA35vdxp4ClOk6CsO gKdRH6dAr5Q1i5QlgPy6uqaId/mPVe5EQyUDXyX+MeeuDQdw/hsVEuc5xahteAagJdeY Q4oot6CsZ22sTGLEu1frrYZj0drKJ16A5KM2fzMkOq/tOyWefkY2B4CBL8u3yVCVu6av B79dqkpqGaX1RDZQLdlp3gugFY9HTECY4G4dCp2Ww1NrcZ3SjvTFLAg3rDcu/H9DOqus IMH+3n0jLyhx4eKGXLDqDxhD0WzYk0RmkqFaxUOC2vRJ5w21Lw/0Sc1xkbh21UGHzqEj NRLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="V6/rD1Zg"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w8-20020a056830144800b005e9ac708d09si10360677otp.227.2022.04.26.08.10.20; Tue, 26 Apr 2022 08:10:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="V6/rD1Zg"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345972AbiDZIxl (ORCPT + 99 others); Tue, 26 Apr 2022 04:53:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345843AbiDZIji (ORCPT ); Tue, 26 Apr 2022 04:39:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C792E793B8; Tue, 26 Apr 2022 01:32:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 08485617D2; Tue, 26 Apr 2022 08:32:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18C87C385AC; Tue, 26 Apr 2022 08:32:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650961926; bh=aN26knkQ3uIvvm0WQL2I229Lj/DG+/cm/IpczxzF+LU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V6/rD1ZgKo2ggXD0UIOJzU5bwnuZ3cLpgzFhh6WBH1k1qAXfT27CrH8jZmcM5+C3C oSacURcDxTOO7bAwpxK7qPqRzoAk8O7kH/EVyc4kBeZl6IjK8FLeynw2Oj7OE0BPfP ltaFANwArIn3wRHjIhxqzQDvCHzPWSazu1puo1R0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Allen-KH Cheng , Rex-BC Chen , Mark Brown , Sasha Levin Subject: [PATCH 5.10 15/86] spi: spi-mtk-nor: initialize spi controller after resume Date: Tue, 26 Apr 2022 10:20:43 +0200 Message-Id: <20220426081741.645860860@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220426081741.202366502@linuxfoundation.org> References: <20220426081741.202366502@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Allen-KH Cheng [ Upstream commit 317c2045618cc1f8d38beb8c93a7bdb6ad8638c6 ] After system resumes, the registers of nor controller are initialized with default values. The nor controller will not function properly. To handle both issues above, we add mtk_nor_init() in mtk_nor_resume after pm_runtime_force_resume(). Fixes: 3bfd9103c7af ("spi: spi-mtk-nor: Add power management support") Signed-off-by: Allen-KH Cheng Reviewed-by: Rex-BC Chen Link: https://lore.kernel.org/r/20220412115743.22641-1-allen-kh.cheng@mediatek.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-mtk-nor.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-mtk-nor.c b/drivers/spi/spi-mtk-nor.c index 288f6c2bbd57..106e3cacba4c 100644 --- a/drivers/spi/spi-mtk-nor.c +++ b/drivers/spi/spi-mtk-nor.c @@ -895,7 +895,17 @@ static int __maybe_unused mtk_nor_suspend(struct device *dev) static int __maybe_unused mtk_nor_resume(struct device *dev) { - return pm_runtime_force_resume(dev); + struct spi_controller *ctlr = dev_get_drvdata(dev); + struct mtk_nor *sp = spi_controller_get_devdata(ctlr); + int ret; + + ret = pm_runtime_force_resume(dev); + if (ret) + return ret; + + mtk_nor_init(sp); + + return 0; } static const struct dev_pm_ops mtk_nor_pm_ops = { -- 2.35.1