Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <604ea061-c566-e032-67cf-9bc622aa76ae@gmail.com>
Date:   Mon, 25 Apr 2022 17:06:19 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] selftests/resctrl: Fix null pointer dereference on open
 failed
Content-Language: en-US
To:     Shuah Khan <skhan@linuxfoundation.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Shuah Khan <shuah@kernel.org>, Babu Moger <babu.moger@amd.com>,
        Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
        linux-kselftest@vger.kernel.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220424211536.1373878-1-colin.i.king@gmail.com>
 <04a35a47-d83a-67a1-5ed4-ba314c6e1ecf@linuxfoundation.org>
From:   "Colin King (gmail)" <colin.i.king@gmail.com>
In-Reply-To: <04a35a47-d83a-67a1-5ed4-ba314c6e1ecf@linuxfoundation.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 25/04/2022 16:51, Shuah Khan wrote:
> On 4/24/22 3:15 PM, Colin Ian King wrote:
>> Currently if opening /dev/null fails to open then file pointer fp
>> is null and further access to fp via fprintf will cause a null
>> pointer dereference. Fix this by returning a negative error value
>> when a null fp is detected.
>>
> 
> How did you find this problem and how can it be reproduced? Is there
> a case where test fails to open "/dev/null"?

Found with static analysis, cppcheck. Open on /dev/null is unlikely to 
fail, but it's good to fail reliably rather than have a SIGSEGV :-)

Colin

> 
>> Fixes: a2561b12fe39 ("selftests/resctrl: Add built in benchmark")
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>> ---
>>   tools/testing/selftests/resctrl/fill_buf.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/resctrl/fill_buf.c 
>> b/tools/testing/selftests/resctrl/fill_buf.c
>> index 51e5cf22632f..56ccbeae0638 100644
>> --- a/tools/testing/selftests/resctrl/fill_buf.c
>> +++ b/tools/testing/selftests/resctrl/fill_buf.c
>> @@ -121,8 +121,10 @@ static int fill_cache_read(unsigned char 
>> *start_ptr, unsigned char *end_ptr,
>>       /* Consume read result so that reading memory is not optimized 
>> out. */
>>       fp = fopen("/dev/null", "w");
>> -    if (!fp)
>> +    if (!fp) {
>>           perror("Unable to write to /dev/null");
>> +        return -1;
>> +    }
>>       fprintf(fp, "Sum: %d ", ret);
>>       fclose(fp);
>>
> 
> thanks,
> -- Shuah