Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Borislav Petkov <bp@alien8.de>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Adaptec OEM Raid Solutions <aacraid@microsemi.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org
Subject: Re: [PATCH 01/11] scsi: aacraid: Fix undefined behavior due to
 shift overflowing the constant
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq15ymwwnmq.fsf@ca-mkp.ca.oracle.com>
References: <20220405151517.29753-1-bp@alien8.de>
        <20220405151517.29753-2-bp@alien8.de>
Date:   Mon, 25 Apr 2022 23:05:11 -0400
In-Reply-To: <20220405151517.29753-2-bp@alien8.de> (Borislav Petkov's message
        of "Tue, 5 Apr 2022 17:15:07 +0200")
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXRYNlVQN25CUnd5c1Fzblh4bzJJaWt1RTUwZHFFa1RTUXJjUldwTkZXRnVY?=
 =?utf-8?B?WHVaUTkxd1AxTzJNeVpEVzdNOENKRGxlMHRTT2VWMEdjZGFoVnR3NUFxb0xK?=
 =?utf-8?B?cWVNOUp6QnZVcjVWd0tsUnQ0WVFXN0h1TXE4eGZydXJTTEI1RWFtcEdHVHkw?=
 =?utf-8?B?ZFBrODJ3YXRtakkzKzZOWGU4QmhHbFhzSHNsN0hpWCtLUUk5Tm9pcExJbDQv?=
 =?utf-8?B?Nkprd3BKMmxTTlcwQnJzRWtUNDd2MnBrSXFCd3EyQjAvUVpJNW5JVUV0Vklq?=
 =?utf-8?B?dG9NSlZMcDhhZzB5N2hpU1lLMERqNXZNV2NEdXh4bHkyeG9sYTI1U1FZSG54?=
 =?utf-8?B?L1RWL1ZIazUxY1VYU0xlZVJBSEhpbWI3ajh4SjQvTnZYSDZHVzZBVG9BWVdv?=
 =?utf-8?B?RTVHUWFybllpWHk2Rk5jTW5hakl0ZWFBYVJPSXlVRzRmblNEMXFtV2RpcDdy?=
 =?utf-8?B?NVRuOEluQXFWTlkrTHJxajZmWTlSMmMvOHRwa3BUaDhQSzQwSGQ0cE8xTU4w?=
 =?utf-8?B?NlpRbyszSFZhK0FKY0xGWHJGd1FRb0xvUXV2YzVQM3E4M2ZFdkYzZW1GbEZQ?=
 =?utf-8?B?N0oxbkNJOCt6NjU4clVuSHJ3NlFKN3p1R3RpcnE4cjZFTWxQcDBhQ1IrUkUx?=
 =?utf-8?B?SnRYenlBeWViZkdIbmU4S1ZSYUwxUGFHeGFndElQZ1g2VytNZGxYNG81OWFz?=
 =?utf-8?B?TXVLNjg1cU1HazVQdFpGZUY2YXJxWGJEbUM3Z1RWcmxoQ0xTR2JFWWRCdVpq?=
 =?utf-8?B?S2s1UStSZWl6N2hLTW9TcnR2RWRQTU15MlZlS0ZaaTdzZjhPTTY0TWFyeUpX?=
 =?utf-8?B?VlJmMGxNbkppeStEVDFON3VTNG9CTmJzK2Q2THl5TzBlSVNPM09xYkZCbkZ6?=
 =?utf-8?B?RFFCbmZSaXVJNUZISDBTdzJoOUFRR1RSMzZxbjVHVnN4ZDhxM1UvR0lLdGhF?=
 =?utf-8?B?cVh0VTNyd013VDdnZi9OTGJWNDA5aHUxcDExejAwUHpWWEEzUFpzMWwvb3Jq?=
 =?utf-8?B?QUxmSkdMeHZ6L3ZUVjR3alVYa3V4bkdvYlFUcVRrRC84N2M0cVpFSnpCS0pz?=
 =?utf-8?B?dHp4WlEyQjRwZ2NWNmE1RXRneUdoYkEzLy9ucHhiM0NBYzhrL2ZvT3FaYmxS?=
 =?utf-8?B?Qm9XMC9hWmRITGFvTThaMmwzOXE5QWhOZ1NPSVluZVBvV0RXRXJjTWtpWHBv?=
 =?utf-8?B?ZndCMzI1Sk9HenZMT3B1emRvOHVHWi93dnZQV2ZuN1dhcTFYV2N2ZnJDWUZX?=
 =?utf-8?B?ZEtJTWNrcnR2aVc1c3VFdVNaZ1I3dFBac052L1FTT1hWRm5ZWjlGNWwrSkto?=
 =?utf-8?B?Q1FLWW1laXh4SFQ0cVAxb2VGUTUxRlpxaHVqVWxIMzZpVUVId1RxMVlzOEFq?=
 =?utf-8?B?M01TYzhVa24zUTZoSjZDaUdCYUVmb3dNcitYTktKRTRnVEpPZCs1bGtnbUZN?=
 =?utf-8?B?R3ZVSFlGZFQ3M3VQaXJoczNPNmhuc2c0enhPWFpnQVZCQXE1YlpVSytCZi81?=
 =?utf-8?B?NTJOQ1E5b1BxbWVDaGhyVTlvQ3VVcTYvTjF6TEh3UDdSZWJ1elRRcTNyaVBF?=
 =?utf-8?B?a3dacUMySkFHQ0FSKzl6ZGIrUWhKdGxGUjNlbGhnN2Q3Rk90T3FKT0F3QmZx?=
 =?utf-8?B?S0x4RzdXWk9XZkt4bmJQbGp1bGlUN3ZiRi9YMnlzNGNUNGo0WFpGbitaRmU1?=
 =?utf-8?B?S2hZb09qd2J2aU8yTlNGdkJvUUVwR2VBNCtWM2xZd3N4bGFwVE5MMUV3Vzkz?=
 =?utf-8?B?Rk5iWFd3NHNxUFdoRGRmTDVMR3ZaTDczYUduZ28yV1lYUml4OTZ2YWNTZ2hm?=
 =?utf-8?B?c0txQk5rSTcxV3hLSTFMRjZVYUw5SDFFRDBWKzNuTzYxd2E1Nk1UQzJJUzU3?=
 =?utf-8?B?QWxHT2VaODdubkdHNURPZElheFhiT0pnRWJ6Q3F1NnNpeDFkQzdON2FWZ295?=
 =?utf-8?B?SHlHZ04rS1k0bHFKc2JuRFVtbmF0V0dyVnVENDFOdWg1ZG1XQ1k3QkJpRGhP?=
 =?utf-8?B?ckdvcnRGYjZkNEVuVG9GTnplRjFhbjBMeVVXYU1UQjZHczdDRmU5MmVyVU1v?=
 =?utf-8?B?RU55VXd6M0ZDdWFNMWcvSWJRTW5NWUU4WEc3NU9TdVJGbzVBc2h4djF0a3lG?=
 =?utf-8?B?eCtvSDRLa3ZncHM0aGtCRFRVZG1MdDcrUVZVTVQvVGVIcDczZkFXbUR1bDhJ?=
 =?utf-8?B?WjNpaWdoZ0h1d3FSSjRuMm15bUk1SHMwNWFjTGhrNzdrbnoweXRJQlpJVGJk?=
 =?utf-8?B?NVI3WS8xNkk0blJiTVFhSGdhSE93dGFvcVdzZTVqQ0YvZ3BjMTdYRXdTSkhO?=
 =?utf-8?B?cEFvVUMxdHo4MmNLSDdIeXlOQzRTaUY1U3VXRC9ldlRXZndlaCtCdW8rQkY0?=
 =?utf-8?Q?/r26HG1FnfuCrydM=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf2a1217-874b-4557-ae40-08da273194e7
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 03:05:13.3777
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AVMD1eYNJeBrn4+fGPR+H1J55ukW3P6EmsGK9z4zA9KO6EvBSnyIrZwEVmbvUEnAdc5vCHCUbA4/1MFHZvBaW8kzAWYnmKMzeNRKgAf4+/Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR10MB2833
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-25_08:2022-04-25,2022-04-25 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=685
 suspectscore=0 malwarescore=0 adultscore=0 spamscore=0 mlxscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204260018
X-Proofpoint-ORIG-GUID: gG1QY2fbBQRn_FQlHbaeg_fYwAOQ7pc2
X-Proofpoint-GUID: gG1QY2fbBQRn_FQlHbaeg_fYwAOQ7pc2
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Borislav,

>   drivers/scsi/aacraid/commsup.c: In function =E2=80=98aac_handle_sa_aif=
=E2=80=99:
>   drivers/scsi/aacraid/commsup.c:1983:2: error: case label does not reduc=
e to an integer constant
>     case SA_AIF_BPCFG_CHANGE:
>     ^~~~

Applied to 5.19/scsi-staging, thanks!

--=20
Martin K. Petersen	Oracle Linux Engineering