Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Adam Manzanares <a.manzanares@samsung.com>
To:     Davidlohr Bueso <dave@stgolabs.net>
CC:     "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "mhocko@kernel.org" <mhocko@kernel.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "rientjes@google.com" <rientjes@google.com>,
        "yosryahmed@google.com" <yosryahmed@google.com>,
        "hannes@cmpxchg.org" <hannes@cmpxchg.org>,
        "shakeelb@google.com" <shakeelb@google.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "tim.c.chen@linux.intel.com" <tim.c.chen@linux.intel.com>,
        "roman.gushchin@linux.dev" <roman.gushchin@linux.dev>,
        "gthelen@google.com" <gthelen@google.com>,
        Heekwon Park <heekwon.p@samsung.com>,
        Jongmin Gim <gim.jongmin@samsung.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/6] mm/vmscan: use node_is_toptier helper in
 node_reclaim
Thread-Topic: [PATCH 2/6] mm/vmscan: use node_is_toptier helper in
        node_reclaim
Thread-Index: AQHYUVRPhFduil0j7kuBgiP9pteKmq0Bu1OA
Date:   Mon, 25 Apr 2022 22:32:17 +0000
Message-ID: <20220425223217.GB147460@bgt-140510-bm01>
In-Reply-To: <20220416053902.68517-3-dave@stgolabs.net>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <20BE6FE238A73040961B01F8E3D668AB@ssi.samsung.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
CMS-TYPE: 301P
References: <20220416053902.68517-1-dave@stgolabs.net>
        <CGME20220416053914uscas1p1552442654a37adcda208d5fec86ec1de@uscas1p1.samsung.com>
        <20220416053902.68517-3-dave@stgolabs.net>
Precedence: bulk

On Fri, Apr 15, 2022 at 10:38:58PM -0700, Davidlohr Bueso wrote:
> We have helpers for a reason.
>=20
> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
> ---
>  mm/vmscan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 1678802e03e7..cb583fcbf5bf 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -4750,7 +4750,7 @@ int node_reclaim(struct pglist_data *pgdat, gfp_t g=
fp_mask, unsigned int order)
>  	 * over remote processors and spread off node memory allocations
>  	 * as wide as possible.
>  	 */
> -	if (node_state(pgdat->node_id, N_CPU) && pgdat->node_id !=3D numa_node_=
id())
> +	if (node_is_toptier(pgdat->node_id) && pgdat->node_id !=3D numa_node_id=
())
>  		return NODE_RECLAIM_NOSCAN;
> =20
>  	if (test_and_set_bit(PGDAT_RECLAIM_LOCKED, &pgdat->flags))
> --=20
> 2.26.2
>


Looks good.

Reviewed by: Adam Manzanares <a.manzanares@samsung.com>=