Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jens Axboe <axboe@kernel.dk>
To:     chaitanya.kulkarni@wdc.com, shinichiro.kawasaki@wdc.com,
        yukuai3@huawei.com
Cc:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        yi.zhang@huawei.com
In-Reply-To: <20220426022133.3999006-1-yukuai3@huawei.com>
References: <20220426022133.3999006-1-yukuai3@huawei.com>
Subject: Re: [PATCH] null-blk: save memory footprint for struct nullb_cmd
Message-Id: <165094029875.72509.3390339725421776639.b4-ty@kernel.dk>
Date:   Mon, 25 Apr 2022 20:31:38 -0600
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Tue, 26 Apr 2022 10:21:33 +0800, Yu Kuai wrote:
> Total 16 bytes can be saved in two ways:
> 
> 1) The field 'bio' will only be used in bio based mode, and the field
>    'rq' will only be used in mq mode. Since they won't be used in the
>    same time, declare a union for them.
> 2) The field 'bool fake_timeout' can be placed in the hole after the
>    field 'error'.
> 
> [...]

Applied, thanks!

[1/1] null-blk: save memory footprint for struct nullb_cmd
      commit: 8ba816b23abd2a9a05705f3d00b8653f8be73015

Best regards,
-- 
Jens Axboe