Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp3908341ioa; Tue, 26 Apr 2022 12:07:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxMlvVcENm5fHrpYB/Fk+w6LcYmAhKLPsy1NTmlM2h7GAePnuM/8hT0ELAkmB3vjaA6q7Dk X-Received: by 2002:a17:902:e80e:b0:15d:4397:2874 with SMTP id u14-20020a170902e80e00b0015d43972874mr2638931plg.54.1651000056549; Tue, 26 Apr 2022 12:07:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651000056; cv=none; d=google.com; s=arc-20160816; b=iZCAys0bcy6Os+pUd6TJ6CFzdw5M9vs24ue1ZC7QGsVll6Kiur0I9hAZnN8bih2KQ/ UslBU0iQpJ3bDLk7FfR64rIXbN4r5rBQC7YJrygGuPud9/rz6A6P/73YcUaeBiJMUH7C o1ft9zdREZ9ShR3yQHFznlemLVms4HaUU6ZUVoOV/JnQnthaR+rPJldZnxY0Ns52OrPz MoRlv/9VK4jeYFIO5I3WOZ/i2NBv5MTYi7aV8S8A29TFMeNAPokdALPN7pBHIyEf+XSa EhG7RiaNDSg7Gwd5sUf7zuOTWAOudb6Sc6dWWQzt2H7ajsJ7NgPydCeV6FhElvpz1vlJ BvLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fJVIOir9pYVZXp1y+IctxeJXK1IaTzfSYCtBh1wsWjE=; b=IRjNJX/lShWB8TMcJx1LUh2C92zdLuSwk3+mapi5DHeW0R7YPrKSNGJLcf6lyJHkjK ohdcKm82NvAP9PT+enlw5MS+cxtU+DLrFQfjMtX842Iz/zL2nuIzImkxTJazT/H6mtxW BZ/oONPsUk+tTuL+e4SkLXph/toVE41xgmesNYyfiRAvbYfQbRAvXvNweLkHfoDVnwOH S4qBj+LIdqs+B12Zm2oe+876okYZ8rF4JjXUKYRxf1SoiJBBscYVQ0xDXttmT1VNLKvP uvheLTIXI0w5kz8hGBbtONdflf1HQYbUr+7YNMSdzOM1SZwSdIQlInrMcCzTWQ/zTal/ atUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Pod5LRnM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w19-20020a63fb53000000b003aa619b8bb2si19384610pgj.294.2022.04.26.12.07.00; Tue, 26 Apr 2022 12:07:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Pod5LRnM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344803AbiDZI2t (ORCPT + 99 others); Tue, 26 Apr 2022 04:28:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344768AbiDZI1n (ORCPT ); Tue, 26 Apr 2022 04:27:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4663612C8C8; Tue, 26 Apr 2022 01:23:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A9CE961806; Tue, 26 Apr 2022 08:23:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB678C385A0; Tue, 26 Apr 2022 08:23:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650961426; bh=XO+htxcasVjIz8LtHd+6NBfz45Ayc74nohNSB2FcCHY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Pod5LRnMUePi1qEHRA14UCWdd2GVEuHsTyuNFt1ojhaHirdFHQOs4PhBwwaXWf+jW M+BdlIGS+NTTA4WNMuOry52FosAH/lj7UdV5Z+22CovCao/kC7KTxYZ9mFiENBk1xo JhELfZWKaqyiOWcA1PiWOC9i7mDf0LrYTLcr0Taw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Abaci Robot , Jiapeng Chong , Hans de Goede , Sasha Levin Subject: [PATCH 4.9 09/24] platform/x86: samsung-laptop: Fix an unsigned comparison which can never be negative Date: Tue, 26 Apr 2022 10:21:03 +0200 Message-Id: <20220426081731.647075021@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220426081731.370823950@linuxfoundation.org> References: <20220426081731.370823950@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiapeng Chong [ Upstream commit 0284d4d1be753f648f28b77bdfbe6a959212af5c ] Eliminate the follow smatch warnings: drivers/platform/x86/samsung-laptop.c:1124 kbd_led_set() warn: unsigned 'value' is never less than zero. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Link: https://lore.kernel.org/r/20220322061830.105579-1-jiapeng.chong@linux.alibaba.com Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Sasha Levin --- drivers/platform/x86/samsung-laptop.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c index 8c146e2b6727..4664d3e191c8 100644 --- a/drivers/platform/x86/samsung-laptop.c +++ b/drivers/platform/x86/samsung-laptop.c @@ -1125,8 +1125,6 @@ static void kbd_led_set(struct led_classdev *led_cdev, if (value > samsung->kbd_led.max_brightness) value = samsung->kbd_led.max_brightness; - else if (value < 0) - value = 0; samsung->kbd_led_wk = value; queue_work(samsung->led_workqueue, &samsung->kbd_led_work); -- 2.35.1