Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp3908412ioa; Tue, 26 Apr 2022 12:07:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJySyPShUDQ1J0jMXBGPN47t44MLk4XW5oY47mCwdMRXkSySSalDKsbIDLptxr3xJ3ZbwC/8 X-Received: by 2002:a05:6870:d353:b0:e1:9304:e807 with SMTP id h19-20020a056870d35300b000e19304e807mr10240418oag.70.1651000061761; Tue, 26 Apr 2022 12:07:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651000061; cv=none; d=google.com; s=arc-20160816; b=p4VpknVC1pXknoOqFgCRwzlJJ2qylfP6ydZhtLxqOGiGywXsi4M9f8178NlxIGTCcw ASvTjvksO5z1Z620ntG6lVntlSgDegT2LIGJ0vKbxFP18hg9PuyaRVYeXla8WU2aPJ3F JeQ5WiAZAjCk7t1a4Euz96jAVruhtnpkkcga5qOE8damQ9dyDe4PR02SMPKl0iRwf/oh +SSCb4kURky1AHvuW9ugYzr8vhMy4vJ8K4ndqPBe6iIu+YWyHsvuLW/3eO0Rhr/+M8Kw lMm34YJgfLUdrM9IQZ3Wp6mBho5yL0v+GAdvoH+rVDZ86K4hVBDQ9F/AbzDw6FXzGyPR KV7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=5zRT5sllSsaGeFvu1yaUlRoHxNiWR89igSrOyjo1FG4=; b=Ag0JH/aoxEyrWSHK51UZgxI5V0qJ1eaS8VIvF5dtrVPDcl0vt/nT6Zhqvf71kOO0hI UNTrSP0lGeolk4JWuRFq/CNOPBfC+448gcyHpJYZSF0Wxm1WX+ou/D1DfUYdhgfqgTRK 4vKeAD9eOSRlLajqxYbI/vQVeMB+Z1IdDhjSdCkXr1E4hfO9qrY6iPll0FGuYEsO41fF oZ+qPUezUoxiLK6V1hewmR7Pc8Lu9PpvPSo+uW5R6EX3QbwhzL+dlfGJczkkcESKCU2x DXxzJKu9BKIOA5+bMFI/0FMfeuhwnEni5ShTD6xG7cD/uG6TJUJmI9C8f8SUzEdoQAVk Rx2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="AfK1/zrk"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r18-20020a056870581200b000e1def29ca9si4884784oap.137.2022.04.26.12.06.59; Tue, 26 Apr 2022 12:07:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="AfK1/zrk"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351007AbiDZNhv (ORCPT + 99 others); Tue, 26 Apr 2022 09:37:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245118AbiDZNhu (ORCPT ); Tue, 26 Apr 2022 09:37:50 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB1C93D1D5 for ; Tue, 26 Apr 2022 06:34:42 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id g23so15346525edy.13 for ; Tue, 26 Apr 2022 06:34:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=5zRT5sllSsaGeFvu1yaUlRoHxNiWR89igSrOyjo1FG4=; b=AfK1/zrk/APNctf5T9jianFlu/dOwBeL60VvN0e/AUy20xraPdotq4gHXNjA82CwJr ASxbJYqu/egWXvhpdKoCATOneKWXEB28QPFqU/ljIv7xIVAyep8++QsrKalLELi38q10 K0gVVa4FyK1t8583z4ZcRnHTJDFCo4aXPEOnCMQPKOVFVeYZy3rM/h2kAQSa7PPkoHke gXsnm8Yy78EAhDlPM8YcMa30cLGqmBSUZGqsijkjXNayacWiKkU1T55DciCPfdIoS15v /r8zAhYkcEExrX6vnIyglxCze6PJY288k25AKszUJPG1oADUV5q4y7/jD/hKEuA12URa AyFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=5zRT5sllSsaGeFvu1yaUlRoHxNiWR89igSrOyjo1FG4=; b=CrtQHo/FsWA4xfc1qCqGmx6bRYjdVfe+r6Q0lQdnnZ2RZC1uHNGmXTmYytAFv55RJp jndOIl8TfVb9ckqy+dP0u/qDASWyjI2pA4kDowO/7h6lNx1fMmTLHfUVF/bDxDcN17W4 Bl4EZ3Aj/6fLr9gpE2ebkhDqUtNn8TvOPUXdIQBI1uOV+Hc44ZrCvLkOKjibuXK2Vqps t0pfF1JxTtvLdGcmwbIkYzOxS3TWtnSFmOtBq/09UqTiN5paovMXs5Oq0Afn62a+uLYZ dG7o/WhW0yT/19bPZe2h8ZkQt+rX7toKQHMOW9/y5fbK9KpcC7EZqWnCOqSB9byFw4gt iiJw== X-Gm-Message-State: AOAM531sJAh4ieXy1i8/k0ftUwjkZLujRmcgcXDRTq9dwy3FRoFTnzo6 /9XJCtJkQE3ftKPy17Wb0Sp/bQ== X-Received: by 2002:a05:6402:27cb:b0:423:d386:42be with SMTP id c11-20020a05640227cb00b00423d38642bemr24839191ede.227.1650980081504; Tue, 26 Apr 2022 06:34:41 -0700 (PDT) Received: from [192.168.0.251] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id lf5-20020a170907174500b006f3806fc9cdsm3416854ejc.39.2022.04.26.06.34.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Apr 2022 06:34:40 -0700 (PDT) Message-ID: Date: Tue, 26 Apr 2022 15:34:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v5 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding Content-Language: en-US To: "Hawkins, Nick" , Rob Herring Cc: "Verdun, Jean-Marie" , "joel@jms.id.au" , "arnd@arndb.de" , "openbmc@lists.ozlabs.org" , Wim Van Sebroeck , Guenter Roeck , Krzysztof Kozlowski , "linux-watchdog@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20220421192132.109954-1-nick.hawkins@hpe.com> <20220421192132.109954-7-nick.hawkins@hpe.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/04/2022 15:21, Hawkins, Nick wrote: >> How is this h/w controlled? I'm guessing it's part of the timer? If so, you don't need this node. A single node can implement multiple functions. > > It is associated with the timer because of the shared register set. Based on feedback from Krzysztof I need to create a child node for gxp-timer. I therefore will remove this file and move gxp-wdt to the hpe,gxp-timer.yaml as a child node. I have impression my feedback was about mapping entire address space, not few registers of watchdog: https://lore.kernel.org/all/c6309ed8-6e74-67d3-304a-f5399d16cc37@canonical.com/ However later during talks it turned out that the address space is heavily shared. Nick, BTW, do you see my comments in the email I linked above? This v5 makes the same mistake. We talked about this already, so please make note of comments you receive and implement them. Best regards, Krzysztof