Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <debc3ad7-221e-c615-435e-0ddced9c6276@amd.com>
Date:   Tue, 26 Apr 2022 17:13:21 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH 3/6] perf/tool/amd/ibs: Warn about sampling period skew
Content-Language: en-US
To:     Robert Richter <rrichter@amd.com>
Cc:     peterz@infradead.org, acme@kernel.org, mingo@redhat.com,
        mark.rutland@arm.com, jolsa@kernel.org, namhyung@kernel.org,
        tglx@linutronix.de, bp@alien8.de, irogers@google.com,
        yao.jin@linux.intel.com, james.clark@arm.com, leo.yan@linaro.org,
        kan.liang@linux.intel.com, ak@linux.intel.com, eranian@google.com,
        like.xu.linux@gmail.com, x86@kernel.org,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        sandipan.das@amd.com, ananth.narayan@amd.com, kim.phillips@amd.com,
        santosh.shukla@amd.com, Ravi Bangoria <ravi.bangoria@amd.com>
References: <20220425044323.2830-1-ravi.bangoria@amd.com>
 <20220425044323.2830-4-ravi.bangoria@amd.com>
 <YmfE6wIA1Dbet1nX@rric.localdomain>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <YmfE6wIA1Dbet1nX@rric.localdomain>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MlcyZHVnTlRiaFR2a1VYdnFHcWw4d1M5WStyUXkxdFF3cXpSRmtMVDNQRUxy?=
 =?utf-8?B?VHFUZGZ2ZXU3cUMrWVFyVlZVUWRWT0k3WGo5QS9ZM293aGZJRTh0cC9Ld044?=
 =?utf-8?B?SDlQc0xUa3lTRzNIVXVxY0NWbkpmalZyOVpzdXNqZTRUeU10WjVud3NJOWpO?=
 =?utf-8?B?ZWRMVzBVdkJULzRIUEJRN290dEtmS1J0T1psemZDWFNnaUJ4SC9OZU02VnZY?=
 =?utf-8?B?WWxpR2wrSzRXckNHbFdVaUZMYnduaFlZTkw3eDdNcVA0TTVwUTJGSG9ibGMz?=
 =?utf-8?B?OExrcnd2b1JaRmdETU1pSWlaRHI0dDRMSS9yZXFvRzZ5YllFTUl5MXR2dEp1?=
 =?utf-8?B?WkExOUN4SldwWktlbkQ3aCtMZWF6UWY2SkN3bnMvaWdtbkdXNmhTbDJDVktN?=
 =?utf-8?B?YnpBS2JSbTZKMGowOWNTY0daVmNKTVhRSlUvQjFsVGVNamQzL1p0RnhPbFVJ?=
 =?utf-8?B?bnUzUFdzVldZNWlLTlo2elYwbkNSMzQ5Vk8yTmttTTh0SlQ3K1J3dWtWWEJV?=
 =?utf-8?B?ZEVMQ3lJVXNxQzdNcmwwcGtjTmxoLzJhTVM3dDgyWkFtbjFyM3NZSHpGSnhT?=
 =?utf-8?B?Sk9PeXYvRE5MV1dUN1lBMWdsYkFIMDFmWVBJVjI5YWtaQ3dxSUlQUjdNVzlR?=
 =?utf-8?B?dE5wS1RCNklkelJWMExuWkgzTEVSWThNRzZOOXorYVNJN3pwT0VKc0pWMGhz?=
 =?utf-8?B?dHB2SVpxRlhxd3RKMnVvTnVMVnFVQ2hQWjlHeUNGOFE1b2JOejBrMnVJUFFO?=
 =?utf-8?B?UmM1Rmw5LzMrVmZidXZyYW1tNmpudTR6cWlIbkRhTzIzUXR1UFQ0MnZXY1gr?=
 =?utf-8?B?cDhtME5aVXM1T3ljaUNJTWdJdDIrRlBOMU9VQWdSYkxHT3FlL1Y2MGJVdjFI?=
 =?utf-8?B?TU5KcDc4OXkva05rVzBkWjFEbmh0Q21sSkgxVnpVdVFFM1dySlFaSFRCTkFk?=
 =?utf-8?B?QkRielJ6M25acnVwMFNoM1Q3c0gxUzJVR1M2azZMenFRblBIQVZESjVlL0g5?=
 =?utf-8?B?WFVydDc3NzlnT2tjK0dud3JYc3llbzFncFd3Tllua1VYamZBQWlFVVRMQk9l?=
 =?utf-8?B?SWdvMUJPNGdFTkNka3pISE5mdWtPNHhVMFlTZDl2VFRBWnc4MHlWTUdJOXVs?=
 =?utf-8?B?TTc3Q1FreXo3M1NnNlNkb2JwRHJZdjFsc2xrY0hLLzZpbXVWSlJqMXY0NTg3?=
 =?utf-8?B?ZnBVdE00dWFhZUdPOGlndlhXSXJvcndHSjd0SkpWOFloWmJoTnFOSkNxZEQz?=
 =?utf-8?B?TEtRcDZ2cXRaaktESC9oMDRHR1A5RjZWcENTRGNQS1JjSWNqai85NlJCVUV0?=
 =?utf-8?B?WkJCRzMvT3JHU3dDZGhyK2xTZXBDUDloNjg5V0R4dWN6cFQ1TnJJVnRpTmtY?=
 =?utf-8?B?L3V5MUlRMWZFbzh6MTlzYzRwaG9jM1BwTDl6Z01iZ3E0NUZ1Qm9lTFVWK2Nz?=
 =?utf-8?B?WVdkWExFOWJqK1d5azduR2tSZkY5U3pBTy9aeC9zcm8zRy9Pa1BicEtMTXlw?=
 =?utf-8?B?Y3FDMnNwWElyeHA5RDRSbThBOE9aWVhoYUpWYjdrN081dXh4eDRQTktrMThR?=
 =?utf-8?B?aUxsUi9WdWlmODhMSHFmWFRwcUUzRFV0NDdZd1dSUHJ3VDBCeVIyNmpFZkhV?=
 =?utf-8?B?S3lPbk1aQXZSMzI5RkFKd25uR0d1NnRDWlRvbU1JVjRtRlJoNy9yWG5SZEMy?=
 =?utf-8?B?RTRwcFZpa2NMNzl4YUtpUEF3ZjB5NVpHWUdmYmJYS2x2Y0hpeWZJUHRBRGJB?=
 =?utf-8?B?VmxNTm5qdFFxbWtibDRDQUo3aEJ5S0x4MXVtbTFNMjFXNkgxRENBdkJsQjVq?=
 =?utf-8?B?ZzF4d00zUHZqY2hOSFVqdWtUalg4STdOelBQTWJwUkxHYThpOE1qQnhxQ1lO?=
 =?utf-8?B?aHJLdlN2YSthRDExU0NTZHhZVVRpaEJYUEFUOEQyNXl6bk9wbDVvMU1iVVdZ?=
 =?utf-8?B?QTRxa1BNVmhVOTJGaUREbGtrVDBlUXI0NjM0czM4bUtEYTJRSnJVMjNOTW1T?=
 =?utf-8?B?dDBMRlF4d1FlYXNaR2lvUHVOcmgyZHg3NGJ2ODNHMXlBbncvcUs4QTFNMGlj?=
 =?utf-8?B?Z0Vad0pXejlrYWY0aGxzbDNWSXlpNGF4RFFFNnpsRVdEdHNiMVZteXVEZlRn?=
 =?utf-8?B?SkFzWGVwWDRpRlovdHJwNVA4WHV6bjhhZmdYbFA0d1A3VlZRZHVXakJYRWha?=
 =?utf-8?B?Ym1GTXlWMFpieWJFYXBqcktsbTJIQXRjVnA5VjR5dSs0OU9Cako3ZUc5OXFa?=
 =?utf-8?B?MXBXaTFQMHltQlRWM0VhU09lZkMvYThCTzRJU0d1OGU5dEhnQmphdXk5Wlgw?=
 =?utf-8?B?SUMxTWI4Q0ZTd2FkdVhodm9aYUFSdWlhMkNxbW54Ky9DREFxSGY4Zz09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ce68d2e9-cb7c-448a-18e9-08da2779fe97
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3053.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 11:43:34.6562
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XpoBRymOrc4yjX4BzxkrLO09hAsei9zc6leKENOnI4lTuzzy8ht7shVcU07Hvvl0e5hvAo6VIMidOF81JU3nKA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4012
X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 26-Apr-22 3:39 PM, Robert Richter wrote:
> On 25.04.22 10:13:20, Ravi Bangoria wrote:
> 
>> @@ -29,3 +31,32 @@ void arch_evsel__fixup_new_cycles(struct perf_event_attr *attr)
>>  
>>  	free(env.cpuid);
>>  }
>> +
>> +void arch_evsel__warn_ambiguity(struct evsel *evsel, struct perf_event_attr *attr)
> 
> Have an 'ibs_' string in the name?

No, this is not ibs specific. Any arch can define it's own version.

> 
>> +{
>> +	struct perf_env *env = evsel__env(evsel);
>> +	struct perf_pmu *evsel_pmu = evsel__find_pmu(evsel);
>> +	struct perf_pmu *ibs_fetch_pmu = perf_pmu__find("ibs_fetch");
>> +	struct perf_pmu *ibs_op_pmu = perf_pmu__find("ibs_op");
>> +	static int warned_once;
>> +
>> +	if (warned_once || !perf_env__cpuid(env) || !env->cpuid ||
>> +	    !strstarts(env->cpuid, "AuthenticAMD") || !evsel_pmu)
>> +		return;
>> +
>> +	if (ibs_fetch_pmu && ibs_fetch_pmu->type == evsel_pmu->type) {
>> +		if (attr->config & (1ULL << 59)) {
>> +			pr_warning(
>> +"WARNING: Hw internally resets sampling period when L3 Miss Filtering is enabled\n"
>> +"and tagged operation does not cause L3 Miss. This causes sampling period skew.\n");
>> +			warned_once = 1;
>> +		}
>> +	} else if (ibs_op_pmu && ibs_op_pmu->type == evsel_pmu->type) {
>> +		if (attr->config & (1ULL << 16)) {
>> +			pr_warning(
>> +"WARNING: Hw internally resets sampling period when L3 Miss Filtering is enabled\n"
>> +"and tagged operation does not cause L3 Miss. This causes sampling period skew.\n");
> 
> Avoid duplicate code. You could move it to the end of the function and
> early return if the config bit is not set.

Sure.

Thanks,
Ravi