Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp3937222ioa; Tue, 26 Apr 2022 12:53:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzeCmOiyu8kZU+H1cM7/4tDddR0zq5UXzercmfddqMhjTOkqCyJvFTbzwnbZJwzsP/4baCI X-Received: by 2002:a17:906:d20c:b0:6f3:9901:bc08 with SMTP id w12-20020a170906d20c00b006f39901bc08mr10627263ejz.351.1651002803702; Tue, 26 Apr 2022 12:53:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651002803; cv=none; d=google.com; s=arc-20160816; b=DJqOZOyTJ8JppbqSd2OM7UeJKslMCbn9mWUW9D/Qyr32ojWCYDjVJuWocbwAdN+t50 sPq3empldLL9CXhNiGnwDAMB/kG+WEToPoC1mk6EaAd7cMpIziuMfiIjjBxpCnGy7bbT 0+izJsrajaP0VFmyCXeQL13pg0FqnghaowZu6fVavcUS+ppRrpBqpUMEkpNwHsMHPgpV PiBu0yxoxdCNzg5P1UVEuPzysQJVCmPRJZA/u1QfZq63dlNSMzWsE5Gmk86d2dKwJIey Z4DXiknzYSvnJ9hBTr7shLHV1wXihsPfXplshaZ9TH5AsSIBOxZoPwcyGVH3Ag89ogWm HwHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=MuX/i65eoab2R1GDPteoQzzrBhngM5ml0tRuEj+H5Fs=; b=kQFVZkimVG7TM4hAhUEkKFHn4/R1rk9f5CCDcVbplA43yX7dI3n4aN5uS3eTBADPz8 gnAG3uEFkBolLXvi11xSWATKutMZhRo4tUhMSpDsOMH0xYJq4Gjsx8umvuHk4QSmTRhn mbP1+c15l7vWCDW73EZnXUN76cW6JduUQm4ATiRL0twWW6FwdffTN6C5sGBoIrZWeB3s tb+fh7ptm2UUowQ24CMrd4ji3I1VauslOvaRHrUotrh/tNzYhIgZoZTBoFwmqNbnDGSe Is570yHilX5hc7NEOkQnFwgzZHCxQfo411PJ1DokKJ0tvXWL13gxTegafqoNahzw4AGf FkTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VGnUSzvp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p23-20020a17090628d700b006e7a69dc149si15820757ejd.431.2022.04.26.12.52.45; Tue, 26 Apr 2022 12:53:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VGnUSzvp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236976AbiDZKlj (ORCPT + 99 others); Tue, 26 Apr 2022 06:41:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349129AbiDZKiY (ORCPT ); Tue, 26 Apr 2022 06:38:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7250C205D6; Tue, 26 Apr 2022 03:23:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A6FC3615E6; Tue, 26 Apr 2022 10:23:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C616C385AC; Tue, 26 Apr 2022 10:23:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650968614; bh=GAFHWrRIu1P19LIfbXyeLRj1eBKZa239YK7sEvIi+RY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VGnUSzvpzGg8dDdMMQB1U5MvLq3h5EHltXkDwYKYHmIjVRLRWmMc5r31xP4zVkX95 mHkVDDg6AjveWQzJ17ieUFn1cjNdWbQFZpyhGtTWEJrwLBl5B5uH8YuPHW5P/YSj5V vx/1hknF7Ko9e71Doz7JXBZJpgAtq0jsn4wNnzh8= Date: Tue, 26 Apr 2022 12:23:30 +0200 From: Greg Kroah-Hartman To: Daehwan Jung Cc: Mathias Nyman , "open list:USB XHCI DRIVER" , open list , Howard Yen , Jack Pham , Puma Hsu , "J . Avila" , sc.suh@samsung.com, Krzysztof Kozlowski Subject: Re: [PATCH v4 4/5] usb: host: add some to xhci overrides for xhci-exynos Message-ID: References: <1650964728-175347-1-git-send-email-dh10.jung@samsung.com> <1650964728-175347-5-git-send-email-dh10.jung@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1650964728-175347-5-git-send-email-dh10.jung@samsung.com> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 26, 2022 at 06:18:47PM +0900, Daehwan Jung wrote: > Co-processor needs some information about connected usb device. > It's proper to pass information after usb device gets address when > getting "Set Address" command. It supports vendors to implement it > using xhci overrides. There're several power scenarios depending > on vendors. It gives vendors flexibilty to meet their power requirement. > They can override suspend and resume of root hub. > > Signed-off-by: Daehwan Jung > --- > drivers/usb/host/xhci.c | 6 ++++++ > drivers/usb/host/xhci.h | 4 ++++ > 2 files changed, 10 insertions(+) > > diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c > index 5ccf1bbe8732..8b3df1302650 100644 > --- a/drivers/usb/host/xhci.c > +++ b/drivers/usb/host/xhci.c > @@ -5555,6 +5555,12 @@ void xhci_init_driver(struct hc_driver *drv, > drv->check_bandwidth = over->check_bandwidth; > if (over->reset_bandwidth) > drv->reset_bandwidth = over->reset_bandwidth; > + if (over->address_device) > + drv->address_device = over->address_device; > + if (over->bus_suspend) > + drv->bus_suspend = over->bus_suspend; > + if (over->bus_resume) > + drv->bus_resume = over->bus_resume; > } > } > EXPORT_SYMBOL_GPL(xhci_init_driver); > diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h > index 3a414a2f41f0..5bc621e77762 100644 > --- a/drivers/usb/host/xhci.h > +++ b/drivers/usb/host/xhci.h > @@ -1947,6 +1947,9 @@ struct xhci_driver_overrides { > struct usb_host_endpoint *ep); > int (*check_bandwidth)(struct usb_hcd *, struct usb_device *); > void (*reset_bandwidth)(struct usb_hcd *, struct usb_device *); > + int (*address_device)(struct usb_hcd *hcd, struct usb_device *udev); > + int (*bus_suspend)(struct usb_hcd *hcd); > + int (*bus_resume)(struct usb_hcd *hcd); > }; > > #define XHCI_CFC_DELAY 10 > @@ -2103,6 +2106,7 @@ int xhci_drop_endpoint(struct usb_hcd *hcd, struct usb_device *udev, > struct usb_host_endpoint *ep); > int xhci_check_bandwidth(struct usb_hcd *hcd, struct usb_device *udev); > void xhci_reset_bandwidth(struct usb_hcd *hcd, struct usb_device *udev); > +int xhci_address_device(struct usb_hcd *hcd, struct usb_device *udev); You do not use this function in this change, why include it in here? Please reorganize your patch series to only include what you need for each step, as-is it's kind of out-of-order and might not build at each step along the way (or it might, it's hard to determine...) thanks, greg k-h