Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 26 Apr 2022 17:39:31 +0200
From:   Fabien Parent <fparent@baylibre.com>
To:     Neil Armstrong <narmstrong@baylibre.com>
Cc:     Andrzej Hajda <andrzej.hajda@intel.com>,
        Robert Foss <robert.foss@linaro.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Hermes Wu <hermes.wu@ite.com.tw>,
        Allen Chen <allen.chen@ite.com.tw>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/bridge: ite-it6505: add missing Kconfig option select
Message-ID: <20220426153931.suiuc7o53dt6s2es@radium>
References: <20220426141536.274727-1-fparent@baylibre.com>
 <fd02a183-bcaa-86a8-8a13-52a9ddb374d5@baylibre.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="273566twpnhexmyw"
Content-Disposition: inline
In-Reply-To: <fd02a183-bcaa-86a8-8a13-52a9ddb374d5@baylibre.com>
Precedence: bulk


--273566twpnhexmyw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 26, 2022 at 05:29:31PM +0200, Neil Armstrong wrote:
> On 26/04/2022 16:15, Fabien Parent wrote:
> > The IT6505 is using functions provided by the DRM_DP_HELPER driver.
> > In order to avoid having the bridge enabled but the helper disabled,
> > let's add a select in order to be sure that the DP helper functions are
> > always available.
> >=20
> > Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
> > Signed-off-by: Fabien Parent <fparent@baylibre.com>
> > ---
> >   drivers/gpu/drm/bridge/Kconfig | 1 +
> >   1 file changed, 1 insertion(+)
> >=20
> > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kc=
onfig
> > index 007e5a282f67..2145b08f9534 100644
> > --- a/drivers/gpu/drm/bridge/Kconfig
> > +++ b/drivers/gpu/drm/bridge/Kconfig
> > @@ -78,6 +78,7 @@ config DRM_ITE_IT6505
> >           tristate "ITE IT6505 DisplayPort bridge"
> >           depends on OF
> >           select DRM_KMS_HELPER
> > +        select DRM_DP_HELPER
> >           select EXTCON
> >           help
> >             ITE IT6505 DisplayPort bridge chip driver.
>=20
> http://lore.kernel.org/r/20220403151637.15546-1-rdunlap@infradead.org als=
o select DRM_DP_AUX_BUS,
> can you check if this is really neaded ?

Oops, I didn't notice that patch.

Anyway I can successfully link with the following config:
CONFIG_DRM_ITE_IT6505=3Dy
CONFIG_DRM_DP_AUX_BUS=3Dm
CONFIG_DRM_DP_HELPER=3Dy

But I cannot with the following config:
CONFIG_DRM_ITE_IT6505=3Dy
CONFIG_DRM_DP_AUX_BUS=3Dm
CONFIG_DRM_DP_HELPER=3Dm

This suggest that DRM_DP_AUX_BUS is not required for that driver.

Fabien

>=20
> Neil

--273566twpnhexmyw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEQyJHfU3UNW7IG61XVJKc6g3CeAAFAmJoEjIACgkQVJKc6g3C
eABeHw/7Bt/VLgszCCzYH9pHOhqbs7jTipFBxg57jmdYMy+fhgNCwW6meNpvuZ5k
IvAQNMY4CvdwV44bk8KWjGOKgQwu4Y5Ck30Qmy+IARf2h2VaIfmu17/viczdOmkr
gbIRC99eX30uHQWRAXqyn4taRD2OR54eo7PgoqKx8AKD5rRWqlDUPUEDGXO8QE+Q
RYl/DVfv1/SyZHkxuMrsYcJrWfalX7ZuSn5kVu3iOllaDL77XtbXglrc5+Udhc4b
Q5JrgWsSfzQrdx7CYg+Jsg0YLfweE81QHqzztAYGzFg/v8BueApy8k4NKjqF2qTw
nlUmoLTHQCyicwOrDwd+auZcurokQNAaLbiCA8hDkzd9bUNDjz/1wyG0xatxCB5W
2rL1zyHIX1S+rugza5FwDQGCUHMDaF9gkNZ2gqVM9SOsnyK5J/kYHtSGoqtb8Afw
CqHLJ7qd8GinTpUIV0IpjL032Dw9rBA+CblzE4mOJx/DCuMBw9HremiI7oNJxkls
P4nFXS8CEo9mrKkYtG454ADgCYAmtJOBfIspG5LpaY2Z48sy1E0jM7W6HYa8sdBt
7aq1Ly0oNT3Il3k1qZrMsQDpSzKFI3cxeFH8eaaJiZ/YYklyFCa/cuk7QGw1HoBY
kgmyzgcEXck4nrxLD1ic3bcqWOg4acME1mp9UvuUB0Ify+1WOvA=
=FNMT
-----END PGP SIGNATURE-----

--273566twpnhexmyw--