Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp3949022ioa; Tue, 26 Apr 2022 13:09:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyd6cFTmRldJVrHkFoH8u1/d7SVz2Lfu3ZBFm3wJl6Lkf4VhxKBmtBBJ5Z+THN5R0wrFJto X-Received: by 2002:a17:906:2652:b0:6f3:a042:6b51 with SMTP id i18-20020a170906265200b006f3a0426b51mr8981883ejc.565.1651003795481; Tue, 26 Apr 2022 13:09:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651003795; cv=none; d=google.com; s=arc-20160816; b=ZA2pnYdSWt4KKS4yWTHh+w7gLh12rZoY9aasCSaXaWsRCy/mxKSQ0nMYdl412ClmKX Bt27FNOLOwVfib4AKx3Gmo8hqJLPNKV/DmGgXHDITq809D35KsxEJx9b1UFIaOIOksmU aF2Oh5KJ6B+5zWJYaEmN1Rd+3C9EY2gmP2QxxAWlwHDYrjV8DlW0yIxWy83D2mqVt0Kh NSi/9fj46RfmhaxS8caK5pzsFc+eLgb80MfBsTi8mqy7Huoo+Tv8euyFOkDgxz+wH4U5 FxdRFNcP9V76oXdUv2hDFzb0Sd4hQfxrqsyl92buDCh7YOZrZ1rNN8FY0dbJ65tcXJYY /S5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=2YT11j0pfLJE+F2REOUghkL1CZq9cStLl9GNM/QelNE=; b=Z5y0lbssR20Y1V9sSHmibP5FB8TSPt8KxVYhY3hXA97na1JTceSK5c9TSZB3FB9Kcf u1u0OxiRlJ8ZQYgUBC3qmuV54qxK5Dv3uu3Eq8fDN5CmRcwOag1TIK5QGzykG98KCsuu nBH5PXAnpTmC8PkjCyiTbwoE83fWke1NtAyhcLmP80hMNsCUIu31c8KmjPfn8Vt/eqIZ dUrWiK43aU5YDP9CLxJalBEVN2wOB8NxcnvH8p+yF4nAhVnbJhKexMVrV4IGfY9m7VDI 4oPoZKLl0ihHVxE+u//IsvXVPQPCxZskw58pZBM+huW4z3Iq71K7+eKFRvq/qatIxzCP 6PRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=cL4mWgRS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cb17-20020a0564020b7100b00425b6b8e8afsi10400905edb.399.2022.04.26.13.09.19; Tue, 26 Apr 2022 13:09:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=cL4mWgRS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346390AbiDZIyp (ORCPT + 99 others); Tue, 26 Apr 2022 04:54:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345456AbiDZIlG (ORCPT ); Tue, 26 Apr 2022 04:41:06 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AB3D157DE4; Tue, 26 Apr 2022 01:33:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DFAE6B81CAF; Tue, 26 Apr 2022 08:32:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42721C385A4; Tue, 26 Apr 2022 08:32:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650961977; bh=XC/PxJ890NE8IKU5ycw5MBJnxf3y3mMFkwqlK2hnpFw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cL4mWgRStF5NsVgwdFFOqOKA7Gk+mDtduePrqWoeDOZefJ30rV3GSXF7DfGGOj6Ww /I/SjtwxUiEJhwHblEL4aJZS3ebJfAiXZZqRv0u25gsNMG1vPGuastlMAGXQY7lKvv 4DUaqfyWsQcfGJzIIezlZSEPOqU0PBIt8utDhKSY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bernice Zhang , Dave Jiang , Vinod Koul , Sasha Levin Subject: [PATCH 5.10 30/86] dmaengine: idxd: add RO check for wq max_transfer_size write Date: Tue, 26 Apr 2022 10:20:58 +0200 Message-Id: <20220426081742.078041062@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220426081741.202366502@linuxfoundation.org> References: <20220426081741.202366502@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dave Jiang [ Upstream commit 505a2d1032ae656b0a8c736be110255503941cde ] Block wq_max_transfer_size_store() when the device is configured as read-only and not configurable. Fixes: d7aad5550eca ("dmaengine: idxd: add support for configurable max wq xfer size") Reported-by: Bernice Zhang Tested-by: Bernice Zhang Signed-off-by: Dave Jiang Link: https://lore.kernel.org/r/164971488154.2200913.10706665404118545941.stgit@djiang5-desk3.ch.intel.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/idxd/sysfs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c index 5bf4b4be64e4..51af0dfc3c63 100644 --- a/drivers/dma/idxd/sysfs.c +++ b/drivers/dma/idxd/sysfs.c @@ -1098,6 +1098,9 @@ static ssize_t wq_max_transfer_size_store(struct device *dev, struct device_attr u64 xfer_size; int rc; + if (!test_bit(IDXD_FLAG_CONFIGURABLE, &idxd->flags)) + return -EPERM; + if (wq->state != IDXD_WQ_DISABLED) return -EPERM; -- 2.35.1