Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220426161658.437466-1-mailhol.vincent@wanadoo.fr>
In-Reply-To: <20220426161658.437466-1-mailhol.vincent@wanadoo.fr>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Tue, 26 Apr 2022 20:56:02 +0200
Message-ID: <CAK8P3a2ZUfpWiHh6yeAy3fFP8k5BcE8crkis7Savxhdym1e-FQ@mail.gmail.com>
Subject: Re: [PATCH] linux/find: ignore -Wtype-limits to reduce W=2 warnings
 by 34% tree-wide
To:     Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc:     Yury Norov <yury.norov@gmail.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Apr 26, 2022 at 6:16 PM Vincent Mailhol
<mailhol.vincent@wanadoo.fr> wrote:

> +__diag_push();
> +__diag_ignore(GCC, 8, "-Wtype-limits",
> +             "GENMASK(size - 1, 0) yields 'comparison of unsigned expression in < 0 is always false' which is OK");
> +

Are you sure gcc-8 is the correct version to check for? If older
versions had this
already, you may have to add the magic bits in the compiler-gcc.h header.

Otherwise, this looks sensible to me.

      Arnd