Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>, Mark Brown <broonie@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com>,
        D Scott Phillips <scott@os.amperecomputing.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc:     Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] arm64/sme: Fix NULL check after kzalloc
Date:   Tue, 26 Apr 2022 19:30:53 +0800
Message-Id: <20220426113054.630983-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6y9KiYsHn3ljFF2mtWyBbr1zACPcUqQn8rZyzWYBFlODBQ6+ZAmE5NCbr4YP?=
 =?us-ascii?Q?vTeRu9nB+RDVj6isIYcrAbyqCKDfUDP2Bah7KgV1UO04tdbr/tOBPv2UjaM7?=
 =?us-ascii?Q?09GTQCcNvHr61/iSM4rwUX7pEZDkQOVlfA+yGE3ySC43bFhtXMdjymhnILps?=
 =?us-ascii?Q?zUnxuxrCJfYbKKwXndRVMQPaie9D62jc3LgwESI+UuE4t1lKhePsfj7kxJTX?=
 =?us-ascii?Q?mw68aCeezLl1bcdErlkFJbdgxvHJqqLQbAJOLYR4QCH2wbZywTADI/VG4tDR?=
 =?us-ascii?Q?bQUpRxNq6V7bP/EOo2vAHjtLbRlkDHhnvv2G3Sl2+IvNWmXsBnnjFHu61SS5?=
 =?us-ascii?Q?dnG/wF24vb0ApFXyv+kvFQJ5taEFebePyR/cyVbZUnKBZEmuy7XaPb0Uh7os?=
 =?us-ascii?Q?dEVNWXW26E6XvETJwZTpAUmhG64ZQMAyIhMox/b7cxm1/VF3nnX7jOjVGrbT?=
 =?us-ascii?Q?D1a9JDpB0/v1OY8A2hF6f2F8F3O7gN2SbXteUn4ryHuSK2drOtls3a5lsc0A?=
 =?us-ascii?Q?zRvkV3x6kiLQAi5tIPo6bSMwuBsinNSZbYkhqh7jYvohUXN9kjdcCmVzLmfq?=
 =?us-ascii?Q?opDnXxmEjmw22/4Nl0raFD5XfWaAvMYLv37HHNnAxpYfm/nhd2NwM2O/UY/t?=
 =?us-ascii?Q?sj4t14F/pw7Nry6Qe7Ty3YrQOsx7hOF7S4OXTTh3+qw5Ch6cd682bumfagE6?=
 =?us-ascii?Q?InhplDFtjAyK3Pz9aJG7j0IsWQ7FhCfxgPUoetw4WzjakZYhlNEixhz5ynO/?=
 =?us-ascii?Q?zeHE6R1tbHET+P/MjB8zhStAQiAoHHUwe5h3LnrxItSzw4pUi7zcA4d8btoI?=
 =?us-ascii?Q?SX1+O5UWmOe1szxsk8s9O0sJ3pUr0a9QuNgRbr14nM3L0v17+uc1a0stPiUG?=
 =?us-ascii?Q?ig2DxcvIWlQgTmOV0XvHtys70dbGs9eoAZGyAliMsoZNM36XfF3gsmEqrEMJ?=
 =?us-ascii?Q?ivZZ2CzfXT2MTEoEJCW2wBJrLj0b/ODTf1tzvdDtH3URggX9mmbvXqej6I98?=
 =?us-ascii?Q?T+CV0Cs/fyKxXmIDXaAJLvTLzHsW67IPTUlUhBtGQ5z2HrAatvCH+FrjX9CE?=
 =?us-ascii?Q?jZCR1ZvUW27+Fjs1eTvsKfYzvV3G5YJVXSuV6elbs0B/h7xiGWqPzZhBPmvm?=
 =?us-ascii?Q?OuxO03VkxN/5xKYvFpVLFfq7tjfMSeJxUFWFwgKkecpqCNELXxKvHna0FkYf?=
 =?us-ascii?Q?RRjY5ZAmFiRED60wzN2bnqVq8a1htr6ZNNlgJQwckT7+s5QbJDT5TH8lDpN7?=
 =?us-ascii?Q?InL6lJCaugXJw1omR3dlOaX6QHp8KZKGQvJbdOpkcvb81f+CuWmv8YP2zXln?=
 =?us-ascii?Q?DKoTxRmQARHie+f0XFZrZ+Z06w7+P0NyWa+MdcTxWgZUqPcnvtswpISa+fge?=
 =?us-ascii?Q?kWZK9cAkOBomdWrdwPzLoWAO93kro/X2ZFGhYY/aT64T0n6FSm3uHJcnsbkn?=
 =?us-ascii?Q?Z5dT2hrQB6zyXTyv524VrBvy0cWHzpaHBJ0r2WXLltdE7ANeoYY9PDsaE2F/?=
 =?us-ascii?Q?kDe5qduDEt9kfibcSelIez3LoWQNFzk5v3tYs21gUN4gQj1Ckl+dCwApcbb8?=
 =?us-ascii?Q?sJUx+iRNuKHyqSXYoFDdnfYDhQxblFw8cZaySzQsT+qOdv1cwhp+HOrH3yvD?=
 =?us-ascii?Q?xyyZXxeHQb5Os+kDGg6QFfNF9hEvcv6moSqbEn/p0L36c4ycknm24n//NwLF?=
 =?us-ascii?Q?RyP97c5PEHiclVscy8n2g5ihcNvV4TyM/ZXA+4xqZKwabiXtA1u8O1+vmbiW?=
 =?us-ascii?Q?xIto4iF8nA=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d574488-b1cf-4df7-8d3a-08da277847bc
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 11:31:18.2256
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L5rTAPWcqb+IwiNN/qtL903Exh80oVKIMNtlPpCmey30OUpoa3eeCLk5NqHzcHGUsJt+yUJTSWCjrqD3riCPXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB4897
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck error:
./arch/arm64/kernel/process.c:322:2-23: alloc with no test, possible model on line 326

Here should be dst->thread.sve_state.

Fixes: 8bd7f91c03d8 ("arm64/sme: Implement traps and syscall handling for SME")
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 arch/arm64/kernel/process.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c
index 99c293513817..9734c9fb1a32 100644
--- a/arch/arm64/kernel/process.c
+++ b/arch/arm64/kernel/process.c
@@ -321,7 +321,7 @@ int arch_dup_task_struct(struct task_struct *dst, struct task_struct *src)
 	if (thread_za_enabled(&src->thread)) {
 		dst->thread.sve_state = kzalloc(sve_state_size(src),
 						GFP_KERNEL);
-		if (!dst->thread.za_state)
+		if (!dst->thread.sve_state)
 			return -ENOMEM;
 		dst->thread.za_state = kmemdup(src->thread.za_state,
 					       za_state_size(src),
-- 
2.35.3