Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp4290477ioa; Tue, 26 Apr 2022 23:45:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxq1WDstNYnVk81kLN9TdOJN7d5y3enIrvZrH7GHosISNdaOjleMvQnFavAKG0pAWgXHAs8 X-Received: by 2002:a05:6a00:1903:b0:4fa:fa9e:42e6 with SMTP id y3-20020a056a00190300b004fafa9e42e6mr28303932pfi.1.1651041914758; Tue, 26 Apr 2022 23:45:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651041914; cv=none; d=google.com; s=arc-20160816; b=vGk1KWQEZ6KpJ3qH6TgnNCez+5LZ05yjSxLxVd+Ktyu/9F5RdwH/Eekkegh71ijZwd OpOtfGX9goWcQx2UDmnvfWDtgshknCJupXQYJm2FqFudtM2BHGW9pEJigKmQtF5rLwj8 88AmcnTlt6cx131Bbm6FMigK/+SAxAIAQmGDAGX3xJeeQ30VDTQtSuboXP65QUiqbuQ+ V+RaibW0SddQaPuPR8OlDJjtIJrulFuYD/q952cMskYeEJd3zQF34OgC/H6RqzaWRblr Y9VeO7VaLPmJ43xUlHz5nfR8FJA6OUtkt4GkI6pEJav/WqlWjChHTT5yVOv7sdRqwueu LKMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=TcUup7BbhOhWodjT1NO0TdH9pu6NKquD8AwJ4hV9Hu4=; b=BIiq+iv8RY8rRSyS3/t2BglIG7C73V4r3rof1LphQOIZt4YRosNZ1uP3XImpc84tGv A3UNPuNqbG+a5rZat0Xto3Ts3bubOoQpYb6YS+Ij3Z8ld85W3HUVMEo4a0WnPZxqtpgI kfngEPze1rk0gMJx4esNTL0cIDmt6Z5wlODDlrteSXsQJwijkGSu7F6mpk76ecaa5ets lHzVEfCvLhRMFRD+UDh3B5+Gbo/xn4vcnOVvSzPlCrsUA1VEOlC01OZSG8Wnlw/Tgd+p 33iUwKYbyNuf1goMR/+TThQhWSy0cWILp3Nf9IfgGrzDXdAjRlmffJDhN9j/pVtw08nt 4BNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=P0xgsIIs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f20-20020a63f114000000b003ab7a19db31si657089pgi.347.2022.04.26.23.45.01; Tue, 26 Apr 2022 23:45:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=P0xgsIIs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346420AbiDZIpB (ORCPT + 99 others); Tue, 26 Apr 2022 04:45:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345483AbiDZIjK (ORCPT ); Tue, 26 Apr 2022 04:39:10 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45A5813FB57; Tue, 26 Apr 2022 01:29:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E4E77B81A2F; Tue, 26 Apr 2022 08:29:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 417D3C385A0; Tue, 26 Apr 2022 08:29:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650961794; bh=M1sk34xlYCQpQot+7xmeV9IzI73vVdZ8Sw1Ikj2J5Cc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P0xgsIIsElaDQyOUb+LE+dTO+wxIWIOrsliyWiPK+cpysMs2VGK/5UERF7gTgTkE7 ql1cHTDE0WlBWKtZEcXQB+pjlFdWcnaHlXbW5QHe7RTdsi4jti96DQs+1Ftf34ppdz F2fNtbnMDF3SMPE/iBFq/nAG2kTJ2fyPe+jSaUR8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Zeal Robot , Lv Ruyi , "David S. Miller" , Sasha Levin Subject: [PATCH 5.4 31/62] dpaa_eth: Fix missing of_node_put in dpaa_get_ts_info() Date: Tue, 26 Apr 2022 10:21:11 +0200 Message-Id: <20220426081738.118345525@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220426081737.209637816@linuxfoundation.org> References: <20220426081737.209637816@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lv Ruyi [ Upstream commit 1a7eb80d170c28be2928433702256fe2a0bd1e0f ] Both of of_get_parent() and of_parse_phandle() return node pointer with refcount incremented, use of_node_put() on it to decrease refcount when done. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c index 7ce2e99b594d..0a186d16e73f 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c @@ -506,11 +506,15 @@ static int dpaa_get_ts_info(struct net_device *net_dev, info->phc_index = -1; fman_node = of_get_parent(mac_node); - if (fman_node) + if (fman_node) { ptp_node = of_parse_phandle(fman_node, "ptimer-handle", 0); + of_node_put(fman_node); + } - if (ptp_node) + if (ptp_node) { ptp_dev = of_find_device_by_node(ptp_node); + of_node_put(ptp_node); + } if (ptp_dev) ptp = platform_get_drvdata(ptp_dev); -- 2.35.1