Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp4295526ioa; Tue, 26 Apr 2022 23:55:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJza1J9ajUmJg49gaB4KI3nFhXyvxyd/0GUHtTgxog5xDK0oZU/zAmrrlwLKRdpchIjoIS5p X-Received: by 2002:aa7:8094:0:b0:505:b544:d1ca with SMTP id v20-20020aa78094000000b00505b544d1camr28511407pff.26.1651042524289; Tue, 26 Apr 2022 23:55:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651042524; cv=none; d=google.com; s=arc-20160816; b=U9ZrNuaSDGAIjjpDwWgdB9UWxIcNTB5PMsYiQF+JXhmpPRWqkZclVfvl6HsTmnhYy8 WJf4rC8Mitjv4IaaflshRmAZ/BTIyjjosxhR8dRHzDqibpxPJIIKrcj1heVbpyEfAVWi WtMKnuDLOO7sncxYh3r+dysnEYU0J9fbknoqFuCuUns3jMmIB3O/ZrtOrLoJqPjh7Ola cFOvSyTFdhX+d3AZfyEWpnhM4apKWmwylBGD1Ulec6M0gHJnluVrh5P6VaWD3j5jbDTl d5Jdc4A/WBWx4L3qutDGymnH6SbC6/Kyre89DZmwgRo2jkfmVsYyFxwhpf0bFUjlPS/8 Vq3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=sLV+m1erS6OoJMXxq2uxk4q+tgv0MNjUO7KZnTcsFYQ=; b=uNGsHOXg1vhq6ZSRLIxo0q+BwBIiMAlaNR7sel1UAuqqnGMCtojXwaqGBYhoGRFJsD L+s3ajb27owcW8p61Jcj4YbNbYuLlT3aRK9YEU2o/GONMmcl9/mmj1g3uvthYaj7044P mop/oR/Iw5wZSgFtwDPzwwe51kF6/5JS22jRUZN+zw4jXFYlEe+ltuUXkW7AYSzOGpn1 Uygxy23dxa7OwxYxGrzEKZovd4TT94Jljj/ea2uOrJywMUGJMunD/lS/bjMqaUut5pb2 UHlvm3gc3KEoxTFZkf8ZQoggObqPoCXVI1wTObEXT+aKc8pKuN84fD7K8iXwvH7ommj2 g90w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DaLBDPZH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u5-20020a654c05000000b003aa315dba0dsi619823pgq.670.2022.04.26.23.55.10; Tue, 26 Apr 2022 23:55:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DaLBDPZH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346106AbiDZIyI (ORCPT + 99 others); Tue, 26 Apr 2022 04:54:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345825AbiDZIjf (ORCPT ); Tue, 26 Apr 2022 04:39:35 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC10A78FF2; Tue, 26 Apr 2022 01:31:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F1522B81CF9; Tue, 26 Apr 2022 08:31:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53305C385A4; Tue, 26 Apr 2022 08:31:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650961914; bh=bcOTZJMicACjWXiZfXi+DQEm7lArO/AWDfEHBhtc7QE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DaLBDPZHa/b8Vg5qIdJF7S0XKDQ2B7f0tW4Xi9VRZZZTGUUtUIrPGh29S+EMfW3DS 9E51Qn+ipimMVIm1DWz9Xart+Slw8lcbXSBa4b25r4EUBYd3pY8J75Yewpbm8tvSJO YRixkBWoWD/3BgRqlKtG7tVCZdikUKbfak0C2XDQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Mark Brown , Sasha Levin Subject: [PATCH 5.10 11/86] ASoC: msm8916-wcd-digital: Check failure for devm_snd_soc_register_component Date: Tue, 26 Apr 2022 10:20:39 +0200 Message-Id: <20220426081741.533033818@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220426081741.202366502@linuxfoundation.org> References: <20220426081741.202366502@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit e927b05f3cc20de87f6b7d912a5bbe556931caca ] devm_snd_soc_register_component() may fails, we should check the error and do the corresponding error handling. Fixes: 150db8c5afa1 ("ASoC: codecs: Add msm8916-wcd digital codec") Signed-off-by: Miaoqian Lin Link: https://lore.kernel.org/r/20220403115239.30140-1-linmq006@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/msm8916-wcd-digital.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/msm8916-wcd-digital.c b/sound/soc/codecs/msm8916-wcd-digital.c index 9ad7fc0baf07..20a07c92b2fc 100644 --- a/sound/soc/codecs/msm8916-wcd-digital.c +++ b/sound/soc/codecs/msm8916-wcd-digital.c @@ -1206,9 +1206,16 @@ static int msm8916_wcd_digital_probe(struct platform_device *pdev) dev_set_drvdata(dev, priv); - return devm_snd_soc_register_component(dev, &msm8916_wcd_digital, + ret = devm_snd_soc_register_component(dev, &msm8916_wcd_digital, msm8916_wcd_digital_dai, ARRAY_SIZE(msm8916_wcd_digital_dai)); + if (ret) + goto err_mclk; + + return 0; + +err_mclk: + clk_disable_unprepare(priv->mclk); err_clk: clk_disable_unprepare(priv->ahbclk); return ret; -- 2.35.1