Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <7f459ca6-0564-7206-adb2-6abc01c95a6d@redhat.com>
Date:   Tue, 26 Apr 2022 11:46:08 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH V3 6/9] virtio-ccw: implement synchronize_cbs()
Content-Language: en-US
To:     Halil Pasic <pasic@linux.ibm.com>,
        Cornelia Huck <cohuck@redhat.com>
Cc:     "Michael S. Tsirkin" <mst@redhat.com>,
        linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org, sgarzare@redhat.com,
        eperezma@redhat.com, lulu@redhat.com, tglx@linutronix.de,
        peterz@infradead.org, paulmck@kernel.org, maz@kernel.org
References: <20220425024418.8415-1-jasowang@redhat.com>
 <20220425024418.8415-7-jasowang@redhat.com>
 <20220425040512-mutt-send-email-mst@kernel.org> <87a6c98rwf.fsf@redhat.com>
 <20220426045050.4697c833.pasic@linux.ibm.com>
From:   Jason Wang <jasowang@redhat.com>
In-Reply-To: <20220426045050.4697c833.pasic@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2022/4/26 10:50, Halil Pasic 写道:
>>>> +static void virtio_ccw_synchronize_cbs(struct virtio_device *vdev)
>>>> +{
>>>> +	struct virtio_ccw_device *vcdev = to_vc_device(vdev);
>>>> +	struct airq_info *info = vcdev->airq_info;
>>>> +
>>>> +	/*
>>>> +	 * Synchronize with the vring_interrupt() called by
>>>> +	 * virtio_ccw_int_handler().
>>>> +	 */
>>>> +	spin_lock(&vcdev->irq_lock);
>>>> +	spin_unlock(&vcdev->irq_lock);
>>>> +
>>>> +	if (info) {
>>>> +		/*
>>>> +		 * Synchronize with the vring_interrupt() with airq indicator
>>>> +		 */
>>>> +		write_lock(&info->lock);
>>>> +		write_unlock(&info->lock);
>>>> +	}
>> I think we can make this an either/or operation (devices will either use
>> classic interrupts or adapter interrupts)?
> Right, for virtqueue notifications. I second Connie's motion!


Will do this.

Thanks


>