Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 26 Apr 2022 17:48:16 +0100
From:   Cristian Marussi <cristian.marussi@arm.com>
To:     Etienne Carriere <etienne.carriere@linaro.org>
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Sudeep Holla <sudeep.holla@arm.com>,
        Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH v3] firmware: arm_scmi: support optee shared memory in
 optee transport
Message-ID: <YmgiQmeQSkglljEl@e120937-lin>
References: <20220425085127.2009-1-etienne.carriere@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220425085127.2009-1-etienne.carriere@linaro.org>
Precedence: bulk

On Mon, Apr 25, 2022 at 10:51:27AM +0200, Etienne Carriere wrote:
> Adds support for tee shared memory in optee scmi transport. When using
> tee shared memory, scmi optee transport manages SCMI messages using
> msg protocol (from msg.c) in shared memory, whereas smt (from shmem.c)
> protocol is used with static IOMEM shared buffers.
> 
> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
> ---
> Changes since v2:
> - Select configuration switch ARM_SCMI_HAVE_MSG when
>   ARM_SCMI_TRANSPORT_OPTEE is enabled.
> - Don't consider tee_shm in invoke_process_smt_channel() since
>   this function now assumes TEE shared memory is not used for SMT
>   based channel.
> 
> Changes since v1:
> - Remove call to scmi_rx_callback() in scmi_optee_send_message().
> ---

LGTM

Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>

Thanks,
Cristian