Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 27 Apr 2022 00:52:34 +0200
From:   Francois Romieu <romieu@fr.zoreil.com>
To:     Wells Lu <wellslutw@gmail.com>
Cc:     davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org,
        netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, p.zabel@pengutronix.de,
        pabeni@redhat.com, krzk+dt@kernel.org, roopa@nvidia.com,
        andrew@lunn.ch, edumazet@google.com, wells.lu@sunplus.com
Subject: Re: [PATCH net-next v9 2/2] net: ethernet: Add driver for Sunplus
 SP7021
Message-ID: <Ymh3si+MTg5i0Bnl@electric-eye.fr.zoreil.com>
References: <1650882640-7106-1-git-send-email-wellslutw@gmail.com>
 <1650882640-7106-3-git-send-email-wellslutw@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1650882640-7106-3-git-send-email-wellslutw@gmail.com>
Precedence: bulk

Wells Lu <wellslutw@gmail.com> :
[...]
> +int spl2sw_rx_poll(struct napi_struct *napi, int budget)
> +{
[...]
> +	wmb();	/* make sure settings are effective. */
> +	mask = readl(comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
> +	mask &= ~MAC_INT_RX;
> +	writel(mask, comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
> +
> +	napi_complete(napi);
> +	return 0;
> +}
> +
> +int spl2sw_tx_poll(struct napi_struct *napi, int budget)
> +{
[...]
> +	wmb();			/* make sure settings are effective. */
> +	mask = readl(comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
> +	mask &= ~MAC_INT_TX;
> +	writel(mask, comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
> +
> +	napi_complete(napi);
> +	return 0;
> +}
> +
> +irqreturn_t spl2sw_ethernet_interrupt(int irq, void *dev_id)
> +{
[...]
> +	if (status & MAC_INT_RX) {
> +		/* Disable RX interrupts. */
> +		mask = readl(comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
> +		mask |= MAC_INT_RX;
> +		writel(mask, comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
[...]
> +		napi_schedule(&comm->rx_napi);
> +	}
> +
> +	if (status & MAC_INT_TX) {
> +		/* Disable TX interrupts. */
> +		mask = readl(comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
> +		mask |= MAC_INT_TX;
> +		writel(mask, comm->l2sw_reg_base + L2SW_SW_INT_MASK_0);
> +
> +		if (unlikely(status & MAC_INT_TX_DES_ERR)) {
[...]
> +		} else {
> +			napi_schedule(&comm->tx_napi);
> +		}
> +	}

The readl/writel sequence in rx_poll (or tx_poll) races with the irq
handler performing MAC_INT_TX (or MAC_INT_RX) work. If the readl
returns the same value to both callers, one of the writel will be
overwritten.

-- 
Ueimor