Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp4370341ioa; Wed, 27 Apr 2022 02:11:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8JM2sLwcS4q5bN5eFc+TpQC3ussBkhlQwyckNAPP/31QTvFdSFdFiGvsEbbNEXAzspLzf X-Received: by 2002:a17:903:2444:b0:15d:281d:87 with SMTP id l4-20020a170903244400b0015d281d0087mr10780171pls.9.1651050698270; Wed, 27 Apr 2022 02:11:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651050698; cv=none; d=google.com; s=arc-20160816; b=EZTGtLAu0IKLnIx3XG/N9DeoHLxoHKFr3OqA/YgCGN8siCxyyGCUBkbrMq6DTAH4UI CKavX/orD4jZfP14Pc2HU1zMMHoKcVodDInBlCm9mjCvvrFDWYiOFqSvoJ9zcht1QJ/7 Jstr6ChVEUaohTbUo/cdP+KxvyGW0qd77+lBO/AZcnVxmVxYR/bVPzAJ4lcNrvRMI9iM 1hisjr0yUvbvS+0swPUTEyhrNSb/IwK5f0KQJcJi4CrVl/kGXNHptsOwGunxwGmcHQya xqokCwhUpKA8GQe4L/R1Rt59/BJiWO7qBy0+avItF8Izr0oOZe+hMqVshfHN9Dp3Qu+o vs0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=KMQsvzJ5VuMOPuBnH+dQf/vlRQxi5wCpYK/os3PuYGs=; b=Fh5efx3nWkvfyYOzg4QIjgkyDf/r831vqfyCqs5abWjTSuNMlULn5LfoAluTnbPTka wxofm3hYc9EQ74x3cK0UwuPYGF2qSmAZ6prmKpS5CpveMuxT8oNMGp2CjjYMTFzRnMG+ e8fs9UvD/a7llWKxny/zJgBsATW+itQRROGVhXz2bZsH0huFvrL0oQ2ff677yb9UawYx GYUA+o3XsR8QBLWMlg62NI7pgqeFycNiD5NIIv3HvhWqH5HdAQOcW8IiJ+sj7ax7Wtim huhaINUilX1t1LE0fE60JMTs3FgkOtzyic0SipLdebL7LnRtn2h9zhBjb4cCU7yZwRMg GOGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@igalia.com header.s=20170329 header.b="X5amV1/S"; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id u22-20020a056a00159600b0050822e94cefsi872702pfk.369.2022.04.27.02.11.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 02:11:38 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=fail header.i=@igalia.com header.s=20170329 header.b="X5amV1/S"; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E6E432010E2; Wed, 27 Apr 2022 02:02:23 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350466AbiDZNC4 (ORCPT + 99 others); Tue, 26 Apr 2022 09:02:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350476AbiDZNCG (ORCPT ); Tue, 26 Apr 2022 09:02:06 -0400 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DFAB180712; Tue, 26 Apr 2022 05:58:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KMQsvzJ5VuMOPuBnH+dQf/vlRQxi5wCpYK/os3PuYGs=; b=X5amV1/S6PMGm9SMCIZJLYLDnm yMnFdUCZ/ukuBffqkdybr3YCGePmMWZv2vSIGIzHIpebAyX2utmufI9clXjGlphf8G0iFaaDJ7Flx Lo2pgSk93kvzWusWONBgx02kXzkRCzeB3QBzkOjV17RpW4XmgTi49hoAuiYVcFlwip9Y7DoFjAYtv dWjCjFBuodSPgNvBCQ7iQUoPRxEZO5LDn8vgtUDJuf5g58MFvewO4mIubwBg5aThxEBZAUOM1E2Vp 6twuj2brt6kmx0aS+Hne/dSfYTmC2tSqHvqO6oyNXkHyj/YVaqE5ANSbLt9FmnG7uSusMFe1z3ix4 S9hrqQOg==; Received: from [165.90.126.25] (helo=mail.igalia.com) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1njKmC-0004lu-8R; Tue, 26 Apr 2022 14:58:44 +0200 Date: Tue, 26 Apr 2022 11:58:30 -0100 From: Melissa Wen To: Juan =?utf-8?Q?A=2E_Su=C3=A1rez?= Cc: Colin Ian King , Emma Anholt , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/v3d: Fix null pointer dereference of pointer perfmon Message-ID: <20220426125749.5i5nbtlcvwvmhzfh@mail.igalia.com> References: <20220424183512.1365683-1-colin.i.king@gmail.com> <890f6416ab37e40c929d95a8b4dcc8feb3dfb4d1.camel@igalia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="du4ctwa34t2th2i2" Content-Disposition: inline In-Reply-To: <890f6416ab37e40c929d95a8b4dcc8feb3dfb4d1.camel@igalia.com> X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --du4ctwa34t2th2i2 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 04/25, Juan A. Su=E1rez wrote: > On Sun, 2022-04-24 at 19:35 +0100, Colin Ian King wrote: > > In the unlikely event that pointer perfmon is null the WARN_ON return > > path > > occurs after the pointer has already been deferenced. Fix this by > > only > > dereferencing perfmon after it has been null checked. > >=20 >=20 > Good catch! >=20 > Reviewed-by: Juan A. Suarez Applied to drm-misc-next. Thanks, Melissa >=20 >=20 > J.A. >=20 --du4ctwa34t2th2i2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEd8WOo/JViG+Tu+XIwqF3j0dLehwFAmJn7HYACgkQwqF3j0dL ehy8tQ/+Ky3MiJludVLn1UxomYXaF+PMsaoMN6FFFM0mRo9oXAhI3iftu3gDNxwv ukhuJncOwu6Vdrz4PYK5ZkawyU9LoQH8fgMHOw+Pm7viMAV/6aGrB9jnrwRvoYZQ q6FPBa7rKQyvuZujQkm4+vkNr4jSJCDiwdLR2VVSPsLpCm4ttNKPPTaAx8mR9QVB k+4XFMluWtiqkX8eU61Igi43WavCuc/OS1XaiVrS/43DLSMIx2BpsMALFygWmplo mZ1N8aiJfO1IoQpmv0TgB/8XOC6s6VkQ7l0yekEwPto1TJrDlc3xY3He+sLAjq08 m/FF+zYJ72BCFK5pEaf5LCeQfnptVQVScfkiGkSYC2w+gPC9wmV/ZCbCZHPZ8JVp c1cMqaNzJq0edkBoa4wnWVeftZykddN51JyjGnE3uS4wxeO70OXbgFBX97tAL3F8 XNruI80NdPpoSjT+9BcOBqpZHqRe/ODrnXTeKlITeFEstNQagknuqtVHBT2idHX7 ntJxJWQitefSx0meBsk1dvxJgCpEvoY+HEvSZT+127WjTbVnCxP8J1bvthCU/O5l dnN5QoTzQJr67WVK2O+xCvA9e20srRnPEcnUjRK2F0+GGqbi2Dv8FM1Exh/iR56/ WOfHk5CD8+ofK4H90XLF/VjWZTE+2HzfBa7yZOGb40Xq7lEiiI4= =WLJW -----END PGP SIGNATURE----- --du4ctwa34t2th2i2--