Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <9c951fe6-d354-5870-e91b-83d8346ac162@intel.com>
Date:   Wed, 27 Apr 2022 09:49:02 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] irq_work: Make irq_work_queue_on() NMI-safe again
Content-Language: en-US
To:     <ryabinin.a.a@gmail.com>, Dmitry Vyukov <dvyukov@google.com>
CC:     <bigeasy@linutronix.de>, <qiang1.zhang@intel.com>,
        <peterz@infradead.org>, <akpm@linux-foundation.org>,
        <andreyknvl@gmail.com>, <ying.huang@intel.com>,
        <akpm@linux-foundation.org>, <kasan-dev@googlegroups.com>,
        <linux-kernel@vger.kernel.org>
References: <20220426134924.736104-1-jun.miao@intel.com>
From:   Jun Miao <jun.miao@intel.com>
In-Reply-To: <20220426134924.736104-1-jun.miao@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b0lGK2k4N3FzZ3dKemcra0JLOUswMDEzMDhPMnNuNzFqb2U4TFBWb3JFd0xJ?=
 =?utf-8?B?TmhPaGZGZlN2bERmSmQ5Q2pQWkQwWkpmMDFuMWlmcHg0SFFxajRoM0phSncx?=
 =?utf-8?B?dzRSWlE2RmtkaUxvNWliRTdjUitzUlRHQ3k1MkMyVTRYU2pTMDlieGpCajZu?=
 =?utf-8?B?bDV2OHVCZjdrZ21aeGI5SjB3Ly96TURkeU1Xb2tLaHBQdFRZY0RkSk5rd1U2?=
 =?utf-8?B?SnZlL1EvUmJaUllCYmVyVmhWOUNmVzRrMW92NG8rS2JtMzRvclYyeTZkc2U5?=
 =?utf-8?B?Rm5RYnpEa3JnRmNXOWk4UEdIT2dJTHdOemV2aitDWGRCL3NoN3pCZXhsVXNt?=
 =?utf-8?B?VituN2J0R1dvRkNJQ0hRUVdyVk95TDhBYzFiQzNvRDk0SkxJWENpbEtoanVG?=
 =?utf-8?B?SWllRWMvVmJUMjc2c1ZUYzBIMEJ2U2J5S21tM2FlUUczMjNvR3ZzQkg1NW1S?=
 =?utf-8?B?ZlRTaGRFOFpOMHNoVERCQU9NbEpJVzVmcWgwSldjZUVlRnVDQk9mbGpzM3pm?=
 =?utf-8?B?aG5ZRkpGMFFjQUcrbjdwKy9UOFUwUTByQ09JYS8xZzdma0lyNUlFMkZqYnBx?=
 =?utf-8?B?bzV3KzZocXMwK0FRTTJ2YUdzMmFyTnVZYzFzVGtRbU5vSk03bTN0akV2RG4w?=
 =?utf-8?B?cyszcEVBYTBqL3lRbFJEM0x5djFBSEpwczIzNDlySTI3K0JvY2Z6VUIzQUtU?=
 =?utf-8?B?YzlOR3RmM0dyMWplOGFoVXYyUHlYTkNXazdobXg5OXhNTkhUMjNZK0FXUFV5?=
 =?utf-8?B?encvVFRyZ21lZlJ2VE05YlJKOU1BdWo2cU1mT3JQTnVLTVZ0R21wRDhjd3hx?=
 =?utf-8?B?M3B6a3lMWlVRS0orbm95ZGY5WDdPaXJPN0FzWDVUSWN0WXlBeU5hSjA5eGZW?=
 =?utf-8?B?d2NiZTlwOEM1Q3hIQ2QvUlBpcGdjalNqTm40MWJERVJ2czJFV0FoTllCUjUy?=
 =?utf-8?B?TnVxdGNMM3dtcERrUmJXV0NUTEQ2MEJNTGhtS2VPRjdPTEdXMHZvOW5rckkz?=
 =?utf-8?B?NXhLY3V0T0ZkOE1KcXdsU0cyaDdNYjNzL05aZzBCNnQyejdNdFlIU2x2Ymxi?=
 =?utf-8?B?TEU4Z1FPNzRzbmdzenZ0NkFIUXV0RlVyWDVwRVV2T21PSWk5Q0RrMXArRlpN?=
 =?utf-8?B?RERVZXdPMUhMZnNwbGkxMHpiOWRtdDhkK0QyWFlRTHliYlZhek5lWG5MUkQ0?=
 =?utf-8?B?NW9PQzlmcG5tZ1NPNU5YUHpucXE0SklxYjMyK2FwcFdVZDJBV2dnSWJQaGdN?=
 =?utf-8?B?eTJESzZxN0F5NlhZYS9JY2VTMzV6bHEwUjJ6WG5CK2xhK0lsUDVZaHc2STdO?=
 =?utf-8?B?REdLWStENE1oeHIvaVRvbUxLcEw0c2VHZ0NnejhhcGdIUDE2UmEyNHl2RWxr?=
 =?utf-8?B?WU9kVTQxcHhUNUFTeFFNSGFQVFc1V2NFaDJ6U3Y1R2YxTWtsZzVsenpDQmFS?=
 =?utf-8?B?NW1CVkpRUE9UcVdDRWZTUTQ3Zm9qY3ZDcVFIc0NvK1VzdkZRYUs0NVNicXNm?=
 =?utf-8?B?L0VSeENnZmhsZUJuU1kwZnBoWjExK0k1SGxlTm8zZW5PWXdZcDZFVzVkRSsz?=
 =?utf-8?B?bVh5T2pZV0lrQ1NHRmYxWWUvb083amxLN1hWdlRzSjQ2TXhhSWJZQktGSjJv?=
 =?utf-8?B?bEo2OXRFV3ZCbmxOZnBwb1RrcGJuRGdPTFBlYUYyQkM1WEd1NE5HNFlzbzNp?=
 =?utf-8?B?VElIclc3VzZjTkp3U09uUW9nc3pTUjdjc3FzUFFKdXBaN3B2aERyWjFqcUpj?=
 =?utf-8?B?M1dFM0dtVVdYSUlyQ2Rzb1NoN1RaZk5pRmZZWlpRWVZLcUorZ2lFNzRFcTBx?=
 =?utf-8?B?Z0t3SWRoQXVMNDRYT0RMZ0xnbUQxY0ZYS0VOeUs1ZzdJTU1zdXg0eUtTQ2tK?=
 =?utf-8?B?OXdIS0NaNzZpMTlvSTUydW9YM1Rwamg5blBHV3JYV1FoeEYvK1UzaGh2bWNP?=
 =?utf-8?B?ZzNZeGk2M085N0h5VlV5eGhVc2FHUUtVbWlPelFWTjBEL0ptUWtQWmdBZ1JR?=
 =?utf-8?B?TmFNdnBwdXYwQUxHYWxUbStLWnFkTUl2MWdrSW5LS3RrRnZPOG94bkUwdGlu?=
 =?utf-8?B?SWRiWmJ3LzVyeGpVVjdnVEdkR2Z4ZXU5amhRb0NEU2VNWDhPbXpHV1J6b3Jw?=
 =?utf-8?B?MldzenJuUlBhVll2NnFFeEhqYkQzT1BrTFRhS0k1ankxK3NuOUJ6em96L3FO?=
 =?utf-8?B?aWdhTlhjcWJ1L3IzSUZWVEdNTXVDaHhLMXptNkpKV1JTN2dIUmNFWUVKeVB4?=
 =?utf-8?B?UVVLc1phNklIblJ2ZjBaUkhuK1V1bmtVMmY0TWR1WUJXU0JFc21VTFRHZWd3?=
 =?utf-8?B?bzlwSEQ4cERnS0krekx0M2hEaEt3S1J1TmY1b1dWVUh5N0pieWtNdz09?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d8e9879b-b6ca-4434-891b-08da27f01850
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4739.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 01:48:58.3036
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n0nbghUb37gXqkO8E0Poyr9PVsesHxbG1ujcyKeIci5cpxvY1e1LtLBYcgnE+pve5FzS3cIXTcXukBoFKpzn1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB4113
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Add  To/Cc : KASAN/MEM , since I only used the scripts/get_maintainer.pl 
to irq_work.c file.

Thanks
Jun Miao


On 2022/4/26 21:49, Jun Miao wrote:
> We should not put NMI unsafe code in irq_work_queue_on().
>
> The KASAN of kasan_record_aux_stack_noalloc() is not NMI safe. Because which
> will call the spinlock. While the irq_work_queue_on() is also very carefully
> carafted to be exactly that.
> When unable CONFIG_SM or local CPU, the irq_work_queue_on() is even same to
> irq_work_queue(). So delete KASAN instantly.
>
> Fixes: e2b5bcf9f5ba ("irq_work: record irq_work_queue() call stack")
> Suggested by: "Huang, Ying" <ying.huang@intel.com>
> Signed-off-by: Jun Miao <jun.miao@intel.com>
> ---
>   kernel/irq_work.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/kernel/irq_work.c b/kernel/irq_work.c
> index 7afa40fe5cc4..e7f48aa8d8af 100644
> --- a/kernel/irq_work.c
> +++ b/kernel/irq_work.c
> @@ -20,7 +20,6 @@
>   #include <linux/smp.h>
>   #include <linux/smpboot.h>
>   #include <asm/processor.h>
> -#include <linux/kasan.h>
>   
>   static DEFINE_PER_CPU(struct llist_head, raised_list);
>   static DEFINE_PER_CPU(struct llist_head, lazy_list);
> @@ -137,8 +136,6 @@ bool irq_work_queue_on(struct irq_work *work, int cpu)
>   	if (!irq_work_claim(work))
>   		return false;
>   
> -	kasan_record_aux_stack_noalloc(work);
> -
>   	preempt_disable();
>   	if (cpu != smp_processor_id()) {
>   		/* Arch remote IPI send/receive backend aren't NMI safe */