Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp4376042ioa; Wed, 27 Apr 2022 02:21:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/y+jg9rS06SXXlIps7Z0j5AmD9chie49tih62BIxVWlBadH7XpoGFwdbYsv63ZcIHuG0p X-Received: by 2002:a17:903:24f:b0:15c:e3b8:a640 with SMTP id j15-20020a170903024f00b0015ce3b8a640mr21849665plh.5.1651051304593; Wed, 27 Apr 2022 02:21:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651051304; cv=none; d=google.com; s=arc-20160816; b=Me9Y7eg7TrXnd+HmL2ThKH/N+PdGmhzNRFB/AIt2N4b7vkqEK3wnhHRW/8PnXig2ou CAs5S7Zo4ReHxum8Gc7O96D5XDAbC9p2AlWy/cfSepMUPEiWXwDbCmULKa7OJHsMJ/5G W7RSoLXhPSuIwkfAGiFJpDIqQsOZDZFO5YfBAeRHBdPuPCnJom2vzVMTWqKYXkUkRYwq FUX+LWDCEvc3RJpvUVpdpj5r5ep5K/jYrW+uQIresVc1C41KHoFRjJNPfUBwKes917fh t57Bk9RjiGHjn9ini5oCp1k+ip6xfAbzh33ZGbiYB1Fd8h0JfxyUbr7xYMo0E4/6rRZ8 Hcjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=V8j+ApuhrVcYnVlPobN1VewHu/EF7NxDXwY1ULnuq08=; b=xDrkRIi7tI7sCerzEqiRjaPDHuupvUCs6S6e2EMLUcprcIU7Am7tLzY5De3tLP9AIn k7DDdoVvBSWqFY4SsTYSu90IIZ9+9qEKmp5vrHXK6ORuPY0KsXJvG66hHTiuHgUt/1go rlveWjNMnYIlcKxatd1TGfQJVhddHmB2eT1scIRqGX3P9Dkbu5MV4z2SOHK3bckX5mzk IegQGNUH9F6CwmAMeIlYPVPcT+ZE1/V2qUUJOtwChVZ54uN3gHGCBUmSpOw2MabPIotd 6vm/UHtn2WZMkShC07fu4i9J73LzUsdPkNQRz7fXkGkWpFHIAxosdYzu4YlBo8d0PhZa JpDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=4a6o9kmL; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id t15-20020a63f34f000000b003a2b277a404si967575pgj.503.2022.04.27.02.21.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 02:21:44 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=4a6o9kmL; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9CB98234639; Wed, 27 Apr 2022 02:07:29 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359227AbiD0IDk (ORCPT + 99 others); Wed, 27 Apr 2022 04:03:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359225AbiD0IDg (ORCPT ); Wed, 27 Apr 2022 04:03:36 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62DEB641C for ; Wed, 27 Apr 2022 01:00:25 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id a15so920009pfv.11 for ; Wed, 27 Apr 2022 01:00:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=V8j+ApuhrVcYnVlPobN1VewHu/EF7NxDXwY1ULnuq08=; b=4a6o9kmLcL/jkiy0Jg/MgTc0lYxm4t3iRJ4AnDL1xOyQ3rd323oW1Z/8MCW2/lopNN ubh+4T3AH/xBgBka1C8MWM99p6m/Ro2yVDloX4o9kDPaYHnPtq+L1TFxBwZoz5EuLgmj BG25nxSCEBXu4qGY/Uvm6lvldWGcdfcRciJxAM/tWa11jfBOyjfw3iUFlA00DPsRHJeA bwCzsN2gR0bnCZf3FH8dgCpcLvVJm5g+fJqV5HB6VnA5/UnvaXxfXssAxXkG29YtyLZP 6ijEkZa1k+bJTH0P01fxbFBcc1zkK/B21B8qdfgVPCifj622mYoR+O9jWRKagoKfJV9v xeuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=V8j+ApuhrVcYnVlPobN1VewHu/EF7NxDXwY1ULnuq08=; b=5Opy15X53qXTDPvi4GcBPbTlXWd5uXJVC7SVEc8bHhSWSvxYOqSpfPAPwOKF66BZip 1yWJTc6hWqqcdUx8h0xPNsLS3LglvACP/etzG0aERQL1bo/Ym0PJBJUoUVz8UAmFNkaO pb+G+y+gx48EywWhWOpQDKN78HRxMoYoiFv5WUZ9vy6Exi0fX+Kt5enqlE8UUNpuP3UQ +lc2ue/69NRXLM4Tym61FMIwGAfCX4Ax5+fX+ujP/piLAji470x1qpoClzp3kW3Gd9U1 p877QHOzQfe9PQZ2boFQ8T/y3Y7qU0aE4f51oBpPepC0RNpNJbPgHEJZHjNELiN+rvE0 i2hQ== X-Gm-Message-State: AOAM531rgymiKDjYSKlMe0QWqcXZ/YlL0LHsMWBe2nkKnNPMu/utOwrf eBRzXLswglMbaEXwNPJ4vQ6LUg== X-Received: by 2002:a63:8b4a:0:b0:3ab:255c:ff8e with SMTP id j71-20020a638b4a000000b003ab255cff8emr13031330pge.285.1651046424899; Wed, 27 Apr 2022 01:00:24 -0700 (PDT) Received: from localhost.localdomain ([240e:390:e6b:6b80:9d6d:7735:8291:b65d]) by smtp.gmail.com with ESMTPSA id u2-20020a62d442000000b0050d404f837fsm9543380pfl.156.2022.04.27.01.00.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 01:00:23 -0700 (PDT) From: Hao Jia To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com Cc: linux-kernel@vger.kernel.org, Hao Jia Subject: [PATCH v3 0/2] sched/core: Avoid obvious double update_rq_clock warning Date: Wed, 27 Apr 2022 16:00:12 +0800 Message-Id: <20220427080014.18483-1-jiahao.os@bytedance.com> X-Mailer: git-send-email 2.32.0 (Apple Git-132) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These two patches are about the kernel scheduler: patch 1: fixed the issue that kernel may trigger WARN_DOUBLE_CLOCK warning. patch 2: removed some no longer needed comments in the deadline scheduler and cleaned up the code. Thanks for suggestion from Dietmar Eggemann & Peter Zijlstra. v2->v3: - Modify some descriptions and errors in the commit information. - Fixed a bug that might trigger the WARN_DOUBLE_CLOCK warning in migrate_task_rq_dl(). - Add Reviewed-by: Dietmar Eggemann for patch 2. v1->v2: - Added double_rq_clock_clear_update inline helper to clear RQCF_UPDATED of rq->clock_update_flags. - split into two separate patches. [v1] https://lore.kernel.org/lkml/20220418090929.54005-1-jiahao.os@bytedance.com/ [v2] https://lore.kernel.org/lkml/20220422090944.52618-1-jiahao.os@bytedance.com/ Hao Jia (2): sched/core: Avoid obvious double update_rq_clock warning sched/deadline: Remove superfluous rq clock update in push_dl_task() kernel/sched/core.c | 6 +++--- kernel/sched/deadline.c | 13 ++++--------- kernel/sched/rt.c | 5 +++-- kernel/sched/sched.h | 31 +++++++++++++++++++++++++++---- 4 files changed, 37 insertions(+), 18 deletions(-) -- 2.32.0