Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Manivannan Sadhasivam <mani@kernel.org>,
        Hemant Kumar <quic_hemantk@quicinc.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jeffrey Hugo <quic_jhugo@quicinc.com>,
        Bhaumik Bhatt <bbhatt@codeaurora.org>,
        Paul Davey <paul.davey@alliedtelesis.co.nz>,
        Kees Cook <keescook@chromium.org>, mhi@lists.linux.dev,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] bus: mhi: replace snprintf with sysfs_emit
Date:   Tue, 26 Apr 2022 20:58:59 +0800
Message-Id: <20220426125902.681258-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NM9dLQ00ZWF3Uh1EJuz8JdgufcjObakqrOinor9ttVj8hp40F0d8SUFgns9Y?=
 =?us-ascii?Q?233hRvHnMq+mM8xeZ1CQ4HuqHLJrh2DDah9ycwZvYTM96uW1BrXwPgnshv05?=
 =?us-ascii?Q?M/BqXJt9n7Ov+j86RosVCQKRaxP8TaKnpCkxifkXriLoMlWYauB0sYZLuM46?=
 =?us-ascii?Q?72eWUMakMr+M0zKQEpL7lRUtKWwqWxyyzr3jKk5cb+jiuEt48r1x4qku18aV?=
 =?us-ascii?Q?iUpEgDreFCNon3Yme3DBnYBomKci8oGLaADj2vKvYLgNdgrTdACGznwGEm+Z?=
 =?us-ascii?Q?yQsDEfiPhvwFPZTkHlqPp2Dxtg8vv6Q6SyDJdt3N2etpl5H+nKWusJlQTfOB?=
 =?us-ascii?Q?/GQmPvsBPQKL/D7Z8M9VCwOd99gqoI4k4qhWZxRSvJB0OauNzApDf69bMZDI?=
 =?us-ascii?Q?+u1WcAL0X3kiA3qGmTWIk8NZlIBhNKWlZR77IoP6BpHDwyE8k92c8fJXgb1B?=
 =?us-ascii?Q?mdB29V8pR0umlH+GAGdWlJePivbGBuHH45Ou6KZZypvZ2GIIPiMx+FjlEbXg?=
 =?us-ascii?Q?fJdGsbavES9ggOJRWlLI+C55Xnl7mCIItaMAOy2ni7wX5wiMcYhOL/4BUcCk?=
 =?us-ascii?Q?rNgFP7vec1XdmKzieSa4pQJAT2zoJz2qJSC/kwwfQX336oWgrHPRYlnhUVgV?=
 =?us-ascii?Q?ENDeUKX6WLUvrFMaCJjj8tf1+ylJKdvkn03D8Rbj+FrHkzpZvNF6Cr9z8ipo?=
 =?us-ascii?Q?wDewmYlsmskhcHphbyVJ9ifUPhDpDHxzmqqvvpUUFZPwGJwjN4ohHDnblVIJ?=
 =?us-ascii?Q?lB9nTSqCSBb6nxJpTbqauHxc78MM54Izj2Wm91kPu6vp7Z+tRi/CpxbsqB8n?=
 =?us-ascii?Q?/iWBCKJsg0kzpUiJL6PjmytdmuahNuKdXdfw/h54BfmGC6M7F0zzBUFIv1Cv?=
 =?us-ascii?Q?WB7lTKMRru9RldQxQTLqJ/v1vymI2eD3CKqMkEGWfOgVtE68UNgl/kwBavL2?=
 =?us-ascii?Q?zPjqck7kjBl+7QvKuyftPZNTPe4oHn8RN+/H1t8d6iD26o69Asuqs6YzzTgE?=
 =?us-ascii?Q?x+Ft8klW2mqb7HDPUwkZUX/25aFJ5vHbUG+z+3HzOLwtmC3CiFyl+stUZxV3?=
 =?us-ascii?Q?tLiJem7ZOJ+bttBVbWHJoqQHxaRYs4cezW5Ky4eGecba/TMYqUh2kYX+lBVm?=
 =?us-ascii?Q?Lk2yzNmDIwNZIIGia/je1PwuWyRIDdmkjWYPt+wiIxGkxUsUeRuiVMUcXxxG?=
 =?us-ascii?Q?5C5rqwl0VOpXmq3UkeOlvJg4jv7Zw/QVuqRXF6cbWclTn4WAkuDJi7A4T3x7?=
 =?us-ascii?Q?z5T6IBYc6f/qRd0DKs1+EnVXy31q5J9iXDsSecDrZS0UhyopC/+NU3KGxJON?=
 =?us-ascii?Q?02Ny6RzHsqVR8RzHM956kVydq/ngQrtOfXRbGKiquN24j+BC13W/vJO1sm2C?=
 =?us-ascii?Q?zxoCyz247zWbv9CEs5TGRO9rvhTE66GGEZ5MLnbiN+Msg26iHMSZZMoN++BN?=
 =?us-ascii?Q?TaVp6u20g4eGi9uttvDjfNpMUxBqKeDXJL/lGjoGGwRWE/If6fMTpDPlij6C?=
 =?us-ascii?Q?2HsSszh5AIXxNih/SckTa4END2GKpqhsGW+dKXJNnWqyuzQV5FdzaBGwVQLG?=
 =?us-ascii?Q?A6SUjaNG6/Sm0gbo7kdKt8EsAN3vhGaswSko7rAtNy5xSmKrluPNxjYyxYC7?=
 =?us-ascii?Q?W9BfKhVJDxyOHfYuVls0zi32sjAGAjIL7r3cuWLfZLQ7jPckdVaGV2PZFu29?=
 =?us-ascii?Q?2Q/wjrdY0aM+b4qC3Gpp0Pc/lzQEGyOl60KS1XMYRFHzdQWRb/eQL37WCEPJ?=
 =?us-ascii?Q?Up819VlzpA=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3ff2ce49-545a-42f2-662a-08da278496d9
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 12:59:24.8842
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hzH+bTUDl+oZqqUH6TAu5kTuLc3igfmyTtyYDTIluVgdAOuSTreXvqg6I8CCQNE/j3v7r/8OGDtpRDWrPLix/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2692
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./drivers/bus/mhi/host/init.c:89:8-16: WARNING: use scnprintf or sprintf

Use sysfs_emit and sysfs_emit_at instead of snprintf.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/bus/mhi/host/init.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/bus/mhi/host/init.c b/drivers/bus/mhi/host/init.c
index cbb86b21063e..c137d55ccfa0 100644
--- a/drivers/bus/mhi/host/init.c
+++ b/drivers/bus/mhi/host/init.c
@@ -86,7 +86,7 @@ static ssize_t serial_number_show(struct device *dev,
 	struct mhi_device *mhi_dev = to_mhi_device(dev);
 	struct mhi_controller *mhi_cntrl = mhi_dev->mhi_cntrl;
 
-	return snprintf(buf, PAGE_SIZE, "Serial Number: %u\n",
+	return sysfs_emit(buf, "Serial Number: %u\n",
 			mhi_cntrl->serial_number);
 }
 static DEVICE_ATTR_RO(serial_number);
@@ -100,9 +100,8 @@ static ssize_t oem_pk_hash_show(struct device *dev,
 	int i, cnt = 0;
 
 	for (i = 0; i < ARRAY_SIZE(mhi_cntrl->oem_pk_hash); i++)
-		cnt += snprintf(buf + cnt, PAGE_SIZE - cnt,
-				"OEMPKHASH[%d]: 0x%x\n", i,
-				mhi_cntrl->oem_pk_hash[i]);
+		cnt += sysfs_emit_at(buf, cnt, "OEMPKHASH[%d]: 0x%x\n",
+				i, mhi_cntrl->oem_pk_hash[i]);
 
 	return cnt;
 }
-- 
2.35.3