Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 26 Apr 2022 13:43:24 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Subject: Re: [PATCH v1 0/2] acpi: Remove acpi_release_memory()
Message-ID: <Ymfa3F83zxgqD2pk@kroah.com>
References: <20220425114544.37595-1-heikki.krogerus@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220425114544.37595-1-heikki.krogerus@linux.intel.com>
Precedence: bulk

On Mon, Apr 25, 2022 at 02:45:42PM +0300, Heikki Krogerus wrote:
> Hi,
> 
> It seems there never were and there never will be actual devices that
> expose the UCSI ACPI mailbox interface. There are now PD controllers
> that support the UCSI interface, but they do not use the ACPI mailbox.
> 
> So there is no point in mapping the mailbox with ioremap(), we can
> just use memremap(). That should make it possible to also remove the
> function acpi_release_memory(). That function was only there to make
> it possible to use ioremap() in the UCSI ACPI driver.
> 
> thanks,
> 
> Heikki Krogerus (2):
>   usb: typec: ucsi: acpi: Map the mailbox with memremap()
>   acpi: Remove the helper for deactivating memory region
> 
>  drivers/acpi/osl.c                 | 86 ------------------------------
>  drivers/usb/typec/ucsi/ucsi_acpi.c | 19 ++-----
>  include/linux/acpi.h               |  3 --
>  3 files changed, 4 insertions(+), 104 deletions(-)
> 
> -- 
> 2.35.1
> 

Look good to me, Rafael, want me to take this through the USB tree?  Or
if you want to take it through the USB tree, here's my reviewed-by:
either is fine with me.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>