Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp4388295ioa; Wed, 27 Apr 2022 02:43:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBGf/JzxjCw8cMHJcKf8lVR2zthqE5xRC+InV/3rNOBapZ5Fq/HHmu2AtJ1RZld2p6xd/3 X-Received: by 2002:a05:6a00:2442:b0:4fd:8b00:d2f with SMTP id d2-20020a056a00244200b004fd8b000d2fmr28972594pfj.39.1651052618534; Wed, 27 Apr 2022 02:43:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651052618; cv=none; d=google.com; s=arc-20160816; b=VcWgBZUa800V08Loa9EHIDcdxHgQO1J77OcP/427p9I8gfD38qtJnfiKcSP1Hx9PwU wYGtqTuvIbZhO3053FeOeYnLcnP/4Havp/mmrP2TL31RGRN56Pb1EC+mLjeCJnHTvdTC zWIYCF8/V0eey/b1er1S4pqpulgFjh/S4Eg5C3O3vfZiXou2YamkdcjuxQPwwR9cuB6V 5r7lXej2cvT+qOFZfzqkgSLHtdfT3yyWXgZ9K9kaaZIHgtNzS+n7MEO+1kHUb52R6jX3 zrcBiFUqnFIcItRhjq7wWjRYryyyjv8oiJw0p/no831fqPj8R1wE2Y+cXX4B3dmuCGET cvPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=PEo4D4bdSYpeDMz9JZm7KkOWj6DXC/CIJId7e4HzmSk=; b=PPxR2f/2F3ldYqKdcCAxyaB1zesyzANvmP02XVSbufmNsLPDDW4qb1Wa9OZyZS/cez BpqMJDWrz/Hm5bTBVKTUixY28wtRxujaMUTezj6H2D7d3QBahZBrHr16lrOxXUxOTg6P pp21yf8WlOnRY81CLsl/aRGToxl14pQfIA4itMG5Kr5CRsW60Zwt6mrOS4zsUh17APCB usAfbxTu6mHnrSVvqMsMee2GbPSbzOGHckbhorzgsmvTtGhBm6864TIBD7NXMUNXaekX dVpnDxv6C65lMMCCpYi6ZmVlWUN1RitPqO9XW85akjY5OloHrS2Fo0Ehin1aHXQy2qN2 Cptw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=b3Gu0eY7; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id kb17-20020a17090ae7d100b001cba40415easi4933515pjb.72.2022.04.27.02.43.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 02:43:38 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=b3Gu0eY7; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E015627AAAC; Wed, 27 Apr 2022 02:18:26 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355414AbiDZV37 (ORCPT + 99 others); Tue, 26 Apr 2022 17:29:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355398AbiDZV36 (ORCPT ); Tue, 26 Apr 2022 17:29:58 -0400 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 938A532EDB for ; Tue, 26 Apr 2022 14:26:49 -0700 (PDT) Received: by mail-pg1-x532.google.com with SMTP id x12so2856149pgj.7 for ; Tue, 26 Apr 2022 14:26:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PEo4D4bdSYpeDMz9JZm7KkOWj6DXC/CIJId7e4HzmSk=; b=b3Gu0eY7U5IQHGKcfdYMdQxoneUyHYN6t0ILw1/E5N15QRMokh322X81jWZmTc+9IN o7obfkEb//U9xX33jM5h/00zEKC1nWBwDuzxk34hDB+b5CvdIcheHOPjrbZXY+Ff0uCJ wubvdiaCoFgqVsbUy9/tOxBs9sPae45FmhO58= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PEo4D4bdSYpeDMz9JZm7KkOWj6DXC/CIJId7e4HzmSk=; b=2uowisXPy2xdLqdff02efC5SUOOa9GC+6ffYZdjVaeelYCZEqz0qgVgL5r6pavqRe8 Y/CVa7FIkBeprRCz7VFEUUC8DTC83DBsoWqbelmRokZxyK74Rjytycra+4RLzh92NoXM UQ7qIzCR/RcIvVpZwun+OyrmwA+N49KX7+QhKatAP7L6GbuBGDnwextoZb/ZA2yjxg3n 1y1+xHn3ybaPUL1fSSQYWzIgTny39/Xkzre5jBDZhIeOSjqLYH+JzuG1FxxA6LITBj6U WEeZJW4K7tNOJlxAbZ/70jeYLN7K8PCbBVrJZl5T5bP6hx+zQ1QEBJ7wGRtbILUrHK9i gRcQ== X-Gm-Message-State: AOAM5305msOowHVcraHOvGctoQj/iH/X0g1ML5c4CIHZ7mx7V6v3pr9h KQcMJXIMHtu6OuonziiK+5Nv/4tf8ZwQ9A== X-Received: by 2002:a05:6a00:15d2:b0:50c:e283:f701 with SMTP id o18-20020a056a0015d200b0050ce283f701mr26396606pfu.23.1651008409110; Tue, 26 Apr 2022 14:26:49 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id t9-20020a63b249000000b003aae4f10d86sm11358167pgo.94.2022.04.26.14.26.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 14:26:48 -0700 (PDT) Date: Tue, 26 Apr 2022 14:26:48 -0700 From: Kees Cook To: Wan Jiabing Cc: Manivannan Sadhasivam , Hemant Kumar , Greg Kroah-Hartman , Jeffrey Hugo , Bhaumik Bhatt , Paul Davey , mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bus: mhi: replace snprintf with sysfs_emit Message-ID: <202204261426.FC012A74C7@keescook> References: <20220426125902.681258-1-wanjiabing@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220426125902.681258-1-wanjiabing@vivo.com> X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 26, 2022 at 08:58:59PM +0800, Wan Jiabing wrote: > Fix following coccicheck warning: > ./drivers/bus/mhi/host/init.c:89:8-16: WARNING: use scnprintf or sprintf > > Use sysfs_emit and sysfs_emit_at instead of snprintf. > > Signed-off-by: Wan Jiabing Reviewed-by: Kees Cook -- Kees Cook