Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   "Wang, Zhi A" <zhi.a.wang@intel.com>
To:     Jason Gunthorpe <jgg@nvidia.com>
CC:     Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
        "intel-gvt-dev@lists.freedesktop.org" 
        <intel-gvt-dev@lists.freedesktop.org>,
        Christoph Hellwig <hch@lst.de>
Subject: Re: [PULL] gvt-next
Thread-Topic: [PULL] gvt-next
Thread-Index: AQHYWUN8Agog0QB2HUW+VGhdlmLDqK0CWPcAgAASO4A=
Date:   Tue, 26 Apr 2022 16:58:33 +0000
Message-ID: <e245c195-fdb0-32c4-dcfb-8ff49bc3a63c@intel.com>
References: <c5cf6773-e7a2-8ba8-4cde-0bb14007bc6b@intel.com>
 <20220426155318.GQ2125828@nvidia.com>
In-Reply-To: <20220426155318.GQ2125828@nvidia.com>
Accept-Language: en-FI, en-US
Content-Language: aa
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?+U5gBwLHte85IIgQdeX15afOnjFf63e2WZXgyx/5sdhmMp76K1rHDKM3?=
 =?Windows-1252?Q?GqUPeF3g0k+eBqQE+WrO48qqw9lNYyReIoDPVuz0Pfj5elSRq8Sy0HKX?=
 =?Windows-1252?Q?oMmcwZa4QJqGgwk04SbyP6TqXM4TOban6bXQKOwnuujjsCGOgZCnpAKi?=
 =?Windows-1252?Q?yrSHFaLTO+IoMo4KyjClN1XRPXl/Ut3EVkY/dmXOPz9cIngMk6Jm98dw?=
 =?Windows-1252?Q?bQ1d7MKOvO8wilVgL69RUmKYtLZYcRSRcWsOX1iv3S1vfhoHpzBHG3bD?=
 =?Windows-1252?Q?gJaL2fXvq8tUdf3jwafFzzm8SUBk3jBTq+wa3IzJmG0EriV8xCUmQf2L?=
 =?Windows-1252?Q?ncN55A2sJEE2Z2y87cdacmrsHaPwPgN8sz0jQDV5Fli4HnAmxzfifot4?=
 =?Windows-1252?Q?bzy8hIfZuNeB3EgTGe6fiMvQ1VnpvTN47ekV76Ww3asEk97KQ/KqqAQB?=
 =?Windows-1252?Q?bYEjsQe383lBVZIIDQn7H6Nh2GytAAbgXaZ6U296xmBHgK6xQ1TfmkuG?=
 =?Windows-1252?Q?KuctxFRBb4Ccb68VNlTOSLUWeNn69LgcjWgBgzNsnGCrMnMLB6IGyaU2?=
 =?Windows-1252?Q?yjl86fTh6a9PB/gOupcABiu8Yj2ZucRyBpZtmgFvJaJH/v2CnKzFJ6oD?=
 =?Windows-1252?Q?ej8Bc+ujtEhsLeK10hAnaM38oWwbv4Vb8M2aDD2jyawSXVyC6mDGBaGm?=
 =?Windows-1252?Q?SjiLJtGBZqrZwfomUdm0rTLamlkJqhm8VP+af6sJAaP4yGMTrUAtpM6n?=
 =?Windows-1252?Q?2zqd1X4eAqx70VTmKFU/9rpsfgBmozzaIQXGon4qa5Y2LqLoyoC6ynpP?=
 =?Windows-1252?Q?QQwE+NAkcCGL0l9QiPBuKWu8zqLu1jX1mHeKy2TqgAETFtrLVWA268eY?=
 =?Windows-1252?Q?Xgp9yqk+WHaXehfUuHL5d2he+Osnj7Wr+SrSUUqayaX92GpiYYK+EWsv?=
 =?Windows-1252?Q?PLLyTSwUZNDwiLjpJD488WF6IxyWqm0yc55dqXnCgrJbrOOGmUX0ww3J?=
 =?Windows-1252?Q?kta2AuDYluAV10SClYjZe3UGsbjKUnMjlpTd+PSNE2ZpIvJelVehYL25?=
 =?Windows-1252?Q?FOtqxUk0ceqfxz78rcVytiqbUtmdEyfxzsy+N4Aq6uUmB4KIHr2RXb85?=
 =?Windows-1252?Q?oFHJZ/seeAwpsUi9RD7FZH9/QNjuuQDCPnRvu2Ci7XY7GN5LELPfvVQ2?=
 =?Windows-1252?Q?3lFwNy7I6iqNHQ180nGJanvKkwKcJ6NvPrax2dX26cMqjnq3vDGiSRoe?=
 =?Windows-1252?Q?DuynkmyoQ8XpdlEfeTvAZRySlZ7jiLfxldkeWv0urtgd6fn2QolY3nqi?=
 =?Windows-1252?Q?v1uRcx06rcHBwAjA5Tg7vwke9DHj8oqgWvELgygDaOvs2rR9PW7tIZ8F?=
 =?Windows-1252?Q?7kWo3GpIeCf3H7oM/f92lONRd3O552QsFvO5NXcDQuf7F4SrpPbN0qwu?=
 =?Windows-1252?Q?VMEWNKznR7T56OMdEOuD7NTHQuzCrVZ+mqeOtgGPnCSx9obnlVTn5M0R?=
 =?Windows-1252?Q?t32Rwctp4Yj2AOFEUyBXR+m59tTm1WY3AwPuyYCjfFr09G6npQkvINMC?=
 =?Windows-1252?Q?B9cwWMuMBOOtp8Jkt4EalnSLPoqQQEevzfoSUjvkzYUc3VKDQmDLpheO?=
 =?Windows-1252?Q?wsNHfFmul0sEH93aIuYB9Tu1YU6tDYG5YZ2yrj8naqYN4yjOnd6BI29I?=
 =?Windows-1252?Q?bw6eLoL3SZF1X6n2AVzVmXO6Q75/I5ZHpHK2D9MPqlL0zAYsOOmlBE04?=
 =?Windows-1252?Q?ff6+gcWOgRnfBJYVnKFg56AhgjsZKDGzGwaaKcegoA5lAgsuKSx1vRL5?=
 =?Windows-1252?Q?7fB49612Ues7K8dwD4dAltbMbRBln543FJUhvfWxbPcZZ8XXtxqWEYa/?=
 =?Windows-1252?Q?/v8Cwxb3jWO20w=3D=3D?=
Content-Type: text/plain; charset="Windows-1252"
Content-ID: <D98443480C310A49ACE03F3D5528AF2A@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5549.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f15fa20d-c882-4e4d-de8c-08da27a5ff9f
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2022 16:58:33.7944
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Vr7MHfqvhCmiPHJFMQI8TlJoJ19ypCxU0RSip8SAm9vgB+RzVcJhhUBl3QpuSuKtePPKK97R2B/FWdC6CBcyDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB4163
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/26/22 3:53 PM, Jason Gunthorpe wrote:
> On Tue, Apr 26, 2022 at 07:58:59AM +0000, Wang, Zhi A wrote:
>> Hi folks:
>>
>> Here is the pull of gvt-next which fixs the compilation error when i915 =
debug
>> is open after the GVT-g refactor patches.
>>
>> Thanks so much for the efforts.
>>
>> Thanks,
>> Zhi.
>>
>> The following changes since commit 2917f53113be3b7a0f374e02cebe6d6b74936=
6b5:
>>
>>   vfio/mdev: Remove mdev drvdata (2022-04-21 07:36:56 -0400)
>>
>> are available in the Git repository at:
>>
>>   https://github.com/intel/gvt-linux tags/gvt-next-2022-04-26
>>
>> for you to fetch changes up to 2da299cee780ea797b3f72558687868072cf5eb5:
>>
>>   drm/i915/gvt: Add missing export of symbols. (2022-04-25 18:03:04 -040=
0)
>>
>> gvt-next-2022-04-26
>>
>> - Add two missing exports of symbols when i915 debug is enabled.
>>
>> Zhi Wang (1):
>>       drm/i915/gvt: Add missing export of symbols.
>>
>>  drivers/gpu/drm/i915/intel_gvt.c | 2 ++
>>  1 file changed, 2 insertions(+)
>=20
> This still has another compile problem:
>=20
> ERROR: modpost: "intel_runtime_pm_put" [vmlinux] is a static EXPORT_SYMBO=
L_GPL
>=20
> Because:
>=20
> #if IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
> void intel_runtime_pm_put(struct intel_runtime_pm *rpm, intel_wakeref_t w=
ref);
> #else
> static inline void
> intel_runtime_pm_put(struct intel_runtime_pm *rpm, intel_wakeref_t wref)
> {
>         intel_runtime_pm_put_unchecked(rpm);
> }
> #endif
>=20
> Looks like it happens if CONFIG_DRM_I915_DEBUG_RUNTIME_PM=3Dn
>=20
> I think you probably want to #ifdef the export in the same way:
>=20
> --- a/drivers/gpu/drm/i915/intel_gvt.c
> +++ b/drivers/gpu/drm/i915/intel_gvt.c
> @@ -309,7 +309,9 @@ EXPORT_SYMBOL_NS_GPL(__intel_context_do_pin, I915_GVT=
);
>  EXPORT_SYMBOL_NS_GPL(__intel_context_do_unpin, I915_GVT);
>  EXPORT_SYMBOL_NS_GPL(intel_ring_begin, I915_GVT);
>  EXPORT_SYMBOL_NS_GPL(intel_runtime_pm_get, I915_GVT);
> +#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
>  EXPORT_SYMBOL_NS_GPL(intel_runtime_pm_put, I915_GVT);
> +#endif
Sigh. That's tricky. Let me prepare another one.=20
>  EXPORT_SYMBOL_NS_GPL(intel_runtime_pm_put_unchecked, I915_GVT);
>  EXPORT_SYMBOL_NS_GPL(intel_uncore_forcewake_for_reg, I915_GVT);
>  EXPORT_SYMBOL_NS_GPL(intel_uncore_forcewake_get, I915_GVT);
>=20
> Jason
>=20