Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp4389765ioa; Wed, 27 Apr 2022 02:46:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzXBnSxi7BmMcyNfleB2J72u75OauAIaUrq5kWVWypc380iXT0A3eXlOxmmRxSUPqKwe93G X-Received: by 2002:a05:6a00:849:b0:50d:4069:60b with SMTP id q9-20020a056a00084900b0050d4069060bmr14845475pfk.76.1651052793667; Wed, 27 Apr 2022 02:46:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651052793; cv=none; d=google.com; s=arc-20160816; b=zacZ/ZO6mXQe/nlDohaOhgZLgzSLInFi4DZISBlYQ+KFhjFBZA/reLpHEmWlAxk/40 qgnBoRaZb1Fl7QX5SQSlZgwrEUIwwAFZQKKCCKv12jK/zmyTMdp+IPh1kMj4bJf+jjMc 5ARuvRxrRvHbGKWhntkO8gpDQbpzGRlljIneHgHxc8eYTGEfzJ8HEdQIlfvO2jsLNaWR mGDBasKVCD7YLQ7mT/lLLe/yiNF2dKwBQnmcOYUf/MKjwgLHefLQTODodypxqsoERkwI sbgDmr2kxZ8u6cDsfK162rTqCelITxyyaDrT4hBf0Tsurm9B1oyJbEwjfziwfaRMTPSt Ve9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=P6AZP1/2m8pT+a9dzTVEgZE4jBzSIW+8W+m3y0GnUgg=; b=Ybt7n5OhQvSn+yoZiSiUsmngMPm83eKEK1QejrGIpPiewzXeGm3ews9CIzVVmYVt8P UCUTsLLmFTp6WdKvT3QgU/J4xGd8xlezTRbClcwy1RxrHw+rWb9sN5oPdVnsXtrpiRcV t7Aoo0sz19+IjgCDfJB6aIHXEJ7mum4L5HZBakug9yebFFhAO5Imh0Fvvclq6JhcwIfp lLW6ynvhSNqkKLms9qhnGo5qjdZWAwenaOT3Wep31nuD8EALiOCuIXfw2an8xHVc5r6R W3JALORamyuPh+MS8OsNeYSCBp/XT/0xhfhpreRKc2CEDOLaUmxH0mpQyDMn4uF5bhrS QmHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=wYqYy5gJ; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id o64-20020a634143000000b003816043f15asi970807pga.847.2022.04.27.02.46.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 02:46:33 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=wYqYy5gJ; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9F52825C76; Wed, 27 Apr 2022 02:20:13 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236833AbiDZIql (ORCPT + 99 others); Tue, 26 Apr 2022 04:46:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345787AbiDZIjb (ORCPT ); Tue, 26 Apr 2022 04:39:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45DF34505A; Tue, 26 Apr 2022 01:31:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CC41061896; Tue, 26 Apr 2022 08:31:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA0DFC385A4; Tue, 26 Apr 2022 08:31:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650961861; bh=zlFNlgiWN8d/TLCRFsjLrNWeu1z43hW4bs5yotmPwKM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wYqYy5gJgdnLazyEUxQeSXMHcM4ZusDBzDw3ZeK1al7MVZsjybpv6HTdmqfYRhovN x5q6CudHGNcbUZzRX1Op5INFC0auwSqyJeh2yN5zTkDiMOiZS4X2k8IGckMLeDYSHt RR0hI+8g130pS3mBg42rPakUPfw3kN5ZdJhXizoQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Theodore Tso , stable@kernel.org Subject: [PATCH 5.4 56/62] ext4: fix overhead calculation to account for the reserved gdt blocks Date: Tue, 26 Apr 2022 10:21:36 +0200 Message-Id: <20220426081738.828053637@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220426081737.209637816@linuxfoundation.org> References: <20220426081737.209637816@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Theodore Ts'o commit 10b01ee92df52c8d7200afead4d5e5f55a5c58b1 upstream. The kernel calculation was underestimating the overhead by not taking into account the reserved gdt blocks. With this change, the overhead calculated by the kernel matches the overhead calculation in mke2fs. Signed-off-by: Theodore Ts'o Cc: stable@kernel.org Signed-off-by: Greg Kroah-Hartman --- fs/ext4/super.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -3485,9 +3485,11 @@ static int count_overhead(struct super_b ext4_fsblk_t first_block, last_block, b; ext4_group_t i, ngroups = ext4_get_groups_count(sb); int s, j, count = 0; + int has_super = ext4_bg_has_super(sb, grp); if (!ext4_has_feature_bigalloc(sb)) - return (ext4_bg_has_super(sb, grp) + ext4_bg_num_gdb(sb, grp) + + return (has_super + ext4_bg_num_gdb(sb, grp) + + (has_super ? le16_to_cpu(sbi->s_es->s_reserved_gdt_blocks) : 0) + sbi->s_itb_per_group + 2); first_block = le32_to_cpu(sbi->s_es->s_first_data_block) +