Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp4392825ioa; Wed, 27 Apr 2022 02:52:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwbfBs63wsZj6a0hHf2G16Z+rETgsmklGDVdZ/x7bq+SYbwipheDvWB2VOSwfo8TIzXu5Ls X-Received: by 2002:a63:8ac7:0:b0:3aa:fa62:5a28 with SMTP id y190-20020a638ac7000000b003aafa625a28mr17735016pgd.400.1651053129185; Wed, 27 Apr 2022 02:52:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651053129; cv=none; d=google.com; s=arc-20160816; b=RoXrINu1ATK88Nn04cVZdA0R9biFkuGJyQ6nIiNCE8tcIe73MDjk08a2qbfYDQMAun yMkmsNRbKV7r1QkV01+W/hgoPfAll3eU/H0w1eTEgHgk1R4wr5cIoMY2dnB6K61WHvYS zqBD9u5hGlQJNLUKvDEBBb4v1pOOjdi8WcwUWWsoWdZG5W/BaaXZiTqThk1idNUb6WTi AMI7ZgduHJhh+kCEu4vvd+KuruuX1C8TKvsGxd9hbH7o/S3Zo7x3SAHmTqNa1/8UWBy4 j96sVoziMxR3t73OW/2y0b8rctCpIFblzzTx2MrNUD1WdQnyP6dn6B7vrr/D+DdOlZxG W1WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/2D2D05qlpdRG2iSBjinIYqYXdRZE02C///nZ0U3a70=; b=DGqV8MnP55yIVmby3Ce+doXcSlqd9h2eSeADsUG3JahhxcPOq9e3pBijWfAcxH6ATF 8vmq8FzV7QQMeSDdXRH0QloqWDKW7UDH3mrOdUvx1/iA8V43BABi4pu6OdjdHGNTbVDI zKxepiiTHTZkbMkMSA0u44l0/npTbqipRIurrTIwS8MX68MkZmTxp/7nrPv5eWwHE+V5 Elsti2UGWi+cqYukhZ8KfqUTQDdrZ0CSx+y5obge6L6gqnZRj80w5/j7T05+Fwsu01AO aFU/mM/Q0fhVORQaFnxUiaogY+3S+hEHc5sCIsQC4bva6wQKIi6XOBbq8xdaYKpNzpo1 zQYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZSnrGhIm; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id b6-20020a170902bd4600b00153b2d164f4si1099341plx.252.2022.04.27.02.52.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 02:52:09 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZSnrGhIm; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5609B2421CF; Wed, 27 Apr 2022 02:23:12 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241090AbiDZKiG (ORCPT + 99 others); Tue, 26 Apr 2022 06:38:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349210AbiDZKh1 (ORCPT ); Tue, 26 Apr 2022 06:37:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9242B626F; Tue, 26 Apr 2022 03:21:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2CBA2615CF; Tue, 26 Apr 2022 10:21:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19E2BC385A0; Tue, 26 Apr 2022 10:21:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650968503; bh=KUUK6iT7bOMV0phgkRt5MLlicyQlmJrOnAGbU2zHWtM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZSnrGhImsoG4wKFKYyTBS2DRFndoo3/cCxgFlW7JzxYrjCnQJKFuPKn8CpcPvOmep 0ghcrkJT5LDWtQ9FVu3xSQQ6Q8P31KKrQj4UF+Iyq3N6ZLXW+uutspcwYe8bkXJrva Jd4ss0EfsKCPPtXKfQsnJrazsXugBBECakpj63qs= Date: Tue, 26 Apr 2022 12:21:40 +0200 From: Greg Kroah-Hartman To: Daehwan Jung Cc: Mathias Nyman , "open list:USB XHCI DRIVER" , open list , Howard Yen , Jack Pham , Puma Hsu , "J . Avila" , sc.suh@samsung.com, Krzysztof Kozlowski Subject: Re: [PATCH v4 5/5] usb: host: add xhci-exynos driver Message-ID: References: <1650964728-175347-1-git-send-email-dh10.jung@samsung.com> <1650964728-175347-6-git-send-email-dh10.jung@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1650964728-175347-6-git-send-email-dh10.jung@samsung.com> X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 26, 2022 at 06:18:48PM +0900, Daehwan Jung wrote: > +int xhci_check_trb_in_td_math(struct xhci_hcd *xhci); > +void xhci_segment_free(struct xhci_hcd *xhci, struct xhci_segment *seg); > +void xhci_link_segments(struct xhci_segment *prev, > + struct xhci_segment *next, > + enum xhci_ring_type type, bool chain_links); > +void xhci_initialize_ring_info(struct xhci_ring *ring, > + unsigned int cycle_state); > +void xhci_remove_stream_mapping(struct xhci_ring *ring); Why does your single driver have global functions? That should not be needed, right? And these are odd for a driver's namespace... thanks, greg k-h