Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <d43d9456-d2e4-2486-9970-8c358a599b6d@amd.com>
Date:   Tue, 26 Apr 2022 16:54:29 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 1/2] drm/amdkfd: Use bitmap_zalloc() when applicable
Content-Language: en-US
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        alexander.deucher@amd.com, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@linux.ie, daniel@ffwll.ch
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
References: <f12820f6c5fca9b10ac8f82b3689c50ccb6966aa.1638117878.git.christophe.jaillet@wanadoo.fr>
 <14268d5a-9a4a-2921-9961-d5d36fad47b2@amd.com>
 <80a426b3-ece2-129c-edca-03556e1ecbb6@wanadoo.fr>
From:   Felix Kuehling <felix.kuehling@amd.com>
In-Reply-To: <80a426b3-ece2-129c-edca-03556e1ecbb6@wanadoo.fr>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WmN1bTRqNTFTL2V4amJyZGJ4WmFpVXE2S2FZN2k4MU0vbnVLOGFHdTBuQjVa?=
 =?utf-8?B?bE9tZDdzUjJjTllPaW9ucXJIelUxZXd2R3Jpb2crcm1ta2Vpby9Eak9INUtS?=
 =?utf-8?B?WWF0MExaNmNoTWJFRXJZanNpRGttVW13bFRrUEsvOWFzYVhEaXJ4NysybW40?=
 =?utf-8?B?NWhCVTBlV2ovMU83RDQwdHFBZXNEdHFNa3RKVmxTWEFMbWNubzlQZ2FwRHg3?=
 =?utf-8?B?SGY1SnVwbDE0cU12OXVNYitBakEveW5mekxvN3R6S24vaGkyWnE1OGkvcmRB?=
 =?utf-8?B?VVI2a0RleVVrc2VvcUdnUjNmbTNEMnZtNHpJYzdyL1JZdG5xRFdDOEx1YjBJ?=
 =?utf-8?B?YVZBWDlsR2plS1RNZlJNN1VmS3pFbmkxUzUwWURncEYzamkwUXJEb0xjSWFE?=
 =?utf-8?B?VG9YVDk4Mng2anBkU2pIeTkrK1ZYaTNUYjZLaVNNSzlRQnRKWktYT3JQQ1Bq?=
 =?utf-8?B?alJTZURjMHlEUWE3c0NsSzhBMHBsRGJCZVEyRnFzdHlxOGM2ejdUaDh4THB0?=
 =?utf-8?B?VXZVeFZaMVh6eEc4QWVFekJvMjN4akQ2SGpWdjROWE0vYlJPalRhZjFjTUVZ?=
 =?utf-8?B?a0F4Q0VteUIyNm5UQnpvZWU1OW5NbzZYdU5kQmZUSDNCd0RHRERDQ3JwUkNP?=
 =?utf-8?B?U3VuUkxnVFZkODhFRFVJOUpKVEo0SldiVkZMaTBGZHlMaS95YnZQdmRQRjhZ?=
 =?utf-8?B?WlFRa0dMSWVCNmg2Ni9YWStqVUJ3UmxwSGcyQ3Zpa0JvTWVYaXBJK2t2QXdX?=
 =?utf-8?B?RkM2SHFRNUJneVliTDZqK2NvMGJMWDFBdm5lYlN4TVBlRHJBUjFwUEpDQWVk?=
 =?utf-8?B?Zm04YVRMODF6cXBSVzdGbXBXRnh4SzB5Nld1bWg0M0dNdHA2SVF5WS96OHY3?=
 =?utf-8?B?TzFlTjhTNFBqek5YRko0M1hOUng3VmNzTXBNMXQ0ZVJ5bi9QQ09lTzN5T0ps?=
 =?utf-8?B?M01LTkpPSXVlS2Jwd2xqa0FyREs1NGxISnVsNTBIejFrV085OVM2aVpKRjdW?=
 =?utf-8?B?RXFIUjJHL2ZyQmZNYWdnZ1FqZU5iZHJZVWlLeDg5dVowY1pEZEdGNjZNejdT?=
 =?utf-8?B?S1BIVzlxbndBdzF2MGNBMUtlWjV5V1R3QVlDS1BZV3I5L3lDenpycWhDaVda?=
 =?utf-8?B?Slh0eUZRWDA4SVpBenBROGJZWlBqMVdTREp3ZCtZNkZWbnVra3IreGhhd3ht?=
 =?utf-8?B?RjU0WFBGaVJvVWpVbHY2dE9ONmx3SEY1MHl0SDNoV2J2ODVwL2gzOWQ2REpz?=
 =?utf-8?B?UDZ3K25uWFNYeFZuWWpTV1NieGpCejNYeFFsU2dTaTQ3b3B6akZ4MVFPRjJR?=
 =?utf-8?B?cCtYRWtJbjdLM0xpWCtuM3dMMktkeFdpUkJtSkZQK3NqeTJWMENrTjlFRWZ3?=
 =?utf-8?B?UnBPWXZpUWxzSnorTG9vWUYvTU02ZmRQcDNZemhvaWJHODFQVm44c2Vlckkw?=
 =?utf-8?B?QjBLVzYwYk9qUFNKZ3NkQVE0YXdRdnBQa2tCdkk0LzV3ZVV4VTZsTEFYc29V?=
 =?utf-8?B?bFFBUmtCMm1xOEdOMHJnRkphSjBQYm8ycWlPK1RyN3JGU0pYYTFDVlE3aDI4?=
 =?utf-8?B?QkNTSnVMRDkzOEtwNitLR011L1dmU25QVk1YOHlxRW0xaUJ3ZU1BbmQ0YTAz?=
 =?utf-8?B?RnEvZzNyMXhDa1ZPSVh1a1RmZXhiMzFFUVdiZlBIeUtRTk5kcmMyRzYvY21E?=
 =?utf-8?B?dGFVNzZ3RGZ6VDR4QmNJVVVXSTdYbWZjdjlvdDdxQUdBNWZBZE1PSUVTN044?=
 =?utf-8?B?RDZtWTBoRFk0WUxQUWxZWTJhOVVIQzhuMU1ydCthdVIySE9qaXkzdFlWQmFh?=
 =?utf-8?B?eDdRZG5tWGo2OXFQOXAwS0lxS20wVWxEMXJ3cHEremdyT2NMYTF1dUNrekdH?=
 =?utf-8?B?WXRGaFZtRjNWc2lUTWpMNE5wRTlKMmJFVExFb2pDME1QQUo0WnN2TXV5Um9X?=
 =?utf-8?B?aUZ2bk9EUFZVTmh5eXBtREN6ZHp0VkszcC94MStjUkZBNmdSZXdiWEovU2xp?=
 =?utf-8?B?ZURHaE8zL1VKSlI1dmFCV2l3M2FwVm40MU1VS1U0OHZ6Sy9PVFhmS2xEbnNR?=
 =?utf-8?B?Wk5sMDNBZ3plT2c2VEd3QXY3dExkRnF5cGxGN29mZVpUbWMzbWw1cEhuWGZz?=
 =?utf-8?B?amdwVHlmdFAzTmxrdWRHSUZkRngxZmZLcGJLYkJTdjhtWmlLMzVnV3FBNHZT?=
 =?utf-8?B?RERGcU85dkFqWExUQVJrSVZYRks5dmhmNElQR0FMdGcweXRBaWFBdGhDY2tk?=
 =?utf-8?B?eG9NbEl2ejBaTGZ2bjlOdVNGZ0dlb1BEUDc1ckYwTTVURTQ5NlI5MGE0cWxF?=
 =?utf-8?B?ODY0TFB1ekF4UUNQOENyUDc2Myt6cXFKUVFpSlRXaVNOVHNxaHhRdz09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f25db84-b163-484e-0141-08da27c6f6f8
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5115.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 20:54:33.2114
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dAHKWWG4HQPlwKCNYK+EzYqsS6yic5bwg5Q8iACUkyf2GYA6qXm5jbQy0qTCBME8NTEDGrO/cgjDrMQrzQrK7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB2851
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Am 2022-04-26 um 14:47 schrieb Christophe JAILLET:
> Le 26/04/2022 à 20:01, Felix Kuehling a écrit :
>> Hi Christophe,
>>
>> I just stumbled over this patch series while cleaning up my inbox. 
>> Sorry for dropping it back in November. I'm about to apply it but I 
>> noticed that patch 1 is missing a Signed-off-by. Is it OK to add that 
>> in your name?
>
> Hi,
>
> No problem for me if you can add it. Thanks.
> But if you prefer a v2, it is also fine for me.

No need. I submitted the patches to amd-staging-drm-next.

Regards,
   Felix


>
> BTW sorry for missing the SoB tag. This definitively means that I 
> forgot the checkpatch.pl step for this patch, which is bad.
>
> CJ
>
>>
>> Thanks,
>>    Felix
>>
>>
>> Am 2021-11-28 um 11:45 schrieb Christophe JAILLET:
>>> 'kfd->gtt_sa_bitmap' is a bitmap. So use 'bitmap_zalloc()' to simplify
>>> code, improve the semantic and avoid some open-coded arithmetic in
>>> allocator arguments.
>>>
>>> Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
>>> consistency.
>>> ---
>>>   drivers/gpu/drm/amd/amdkfd/kfd_device.c | 12 +++---------
>>>   1 file changed, 3 insertions(+), 9 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c 
>>> b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
>>> index e1294fba0c26..c5a0ce44a295 100644
>>> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
>>> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
>>> @@ -1252,8 +1252,6 @@ int 
>>> kgd2kfd_schedule_evict_and_restore_process(struct mm_struct *mm,
>>>   static int kfd_gtt_sa_init(struct kfd_dev *kfd, unsigned int 
>>> buf_size,
>>>                   unsigned int chunk_size)
>>>   {
>>> -    unsigned int num_of_longs;
>>> -
>>>       if (WARN_ON(buf_size < chunk_size))
>>>           return -EINVAL;
>>>       if (WARN_ON(buf_size == 0))
>>> @@ -1264,11 +1262,8 @@ static int kfd_gtt_sa_init(struct kfd_dev 
>>> *kfd, unsigned int buf_size,
>>>       kfd->gtt_sa_chunk_size = chunk_size;
>>>       kfd->gtt_sa_num_of_chunks = buf_size / chunk_size;
>>> -    num_of_longs = (kfd->gtt_sa_num_of_chunks + BITS_PER_LONG - 1) /
>>> -        BITS_PER_LONG;
>>> -
>>> -    kfd->gtt_sa_bitmap = kcalloc(num_of_longs, sizeof(long), 
>>> GFP_KERNEL);
>>> -
>>> +    kfd->gtt_sa_bitmap = bitmap_zalloc(kfd->gtt_sa_num_of_chunks,
>>> +                       GFP_KERNEL);
>>>       if (!kfd->gtt_sa_bitmap)
>>>           return -ENOMEM;
>>> @@ -1278,13 +1273,12 @@ static int kfd_gtt_sa_init(struct kfd_dev 
>>> *kfd, unsigned int buf_size,
>>>       mutex_init(&kfd->gtt_sa_lock);
>>>       return 0;
>>> -
>>>   }
>>>   static void kfd_gtt_sa_fini(struct kfd_dev *kfd)
>>>   {
>>>       mutex_destroy(&kfd->gtt_sa_lock);
>>> -    kfree(kfd->gtt_sa_bitmap);
>>> +    bitmap_free(kfd->gtt_sa_bitmap);
>>>   }
>>>   static inline uint64_t kfd_gtt_sa_calc_gpu_addr(uint64_t start_addr,
>>
>