Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
IronPort-SDR: QcW53klpRCbgnlZV7JeePkIMA/V65J7xVx7xqC0m721XXjWcVwJXw702+vHDhswH14LWHAPYh1
 vnL09vrVx5oMlsu2tu0RqzVMownGuOp6yXguxlHejxtnjylZnfuIKvcxsIH1sxNk0PTQ6SsX0r
 s4tN176gvZe1WGNZxi2Y3uu7++nlHP+K1J8BHw3kgPXHBeV5P458Z0IpNz4HE3Ke5Q3dwaaU5d
 F59TfTGPPf/B1mhvN0fsbJU09/DLEZAJ9rybk2bSMoMGhfcEGf2OugSJIKNLYFab5IQeAULYpU
 qaAIlGwKIUvfACSdZzGTu78Z
IronPort-SDR: KPBvDM++ze8OKoJ8bDw0fvQ+LrqzsA9INpxJIttDqvnueXhAmPZtCXM1bQXGDaBCWhNuP9Dy+7
 Xj/3FkZHMpziGFJ4nAjXNEiACt/timFwPzElqGE195rH8k2n/aE9qVlkDumNAko62zk/z0MzXx
 O2AsQq/FT4ON1I0Qz26bktVj56IxjKprVnw85XUKzGpGausnRC9Rd0e2+y0TKmWQ9ntYDINrl1
 YEZqfisZ9KLQxCFdvY6o+aIqGjJxWcZ13N5sbWKuXEcXJ88hFfRXtYK6KGcpaOVBDKpBoy4Q7l
 NIk=
WDCIronportException: Internal
Message-ID: <513edc25-1c73-6c85-9a50-0e267a106ec0@opensource.wdc.com>
Date:   Wed, 27 Apr 2022 11:48:57 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v4 03/10] block: Introduce a new ioctl for copy
Content-Language: en-US
To:     Nitesh Shetty <nj.shetty@samsung.com>
Cc:     chaitanyak@nvidia.com, linux-block@vger.kernel.org,
        linux-scsi@vger.kernel.org, dm-devel@redhat.com,
        linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org,
        axboe@kernel.dk, msnitzer@redhat.com, bvanassche@acm.org,
        martin.petersen@oracle.com, hare@suse.de, kbusch@kernel.org,
        hch@lst.de, Frederick.Knight@netapp.com, osandov@fb.com,
        lsf-pc@lists.linux-foundation.org, djwong@kernel.org,
        josef@toxicpanda.com, clm@fb.com, dsterba@suse.com, tytso@mit.edu,
        jack@suse.com, nitheshshetty@gmail.com, gost.dev@samsung.com,
        =?UTF-8?Q?Javier_Gonz=c3=a1lez?= <javier.gonz@samsung.com>,
        Arnav Dawn <arnav.dawn@samsung.com>,
        Alasdair Kergon <agk@redhat.com>,
        Mike Snitzer <snitzer@kernel.org>,
        Sagi Grimberg <sagi@grimberg.me>,
        James Smart <james.smart@broadcom.com>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Naohiro Aota <naohiro.aota@wdc.com>,
        Johannes Thumshirn <jth@kernel.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        linux-kernel@vger.kernel.org
References: <20220426101241.30100-1-nj.shetty@samsung.com>
 <CGME20220426101938epcas5p291690dd1f0e931cd9f8139daaf3f9296@epcas5p2.samsung.com>
 <20220426101241.30100-4-nj.shetty@samsung.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220426101241.30100-4-nj.shetty@samsung.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 4/26/22 19:12, Nitesh Shetty wrote:
> Add new BLKCOPY ioctl that offloads copying of one or more sources rang=
es
> to one or more destination in a device. COPY ioctl accepts a 'copy_rang=
e'
> structure that contains no of range, a reserved field , followed by an
> array of ranges. Each source range is represented by 'range_entry' that
> contains source start offset, destination start offset and length of
> source ranges (in bytes)
>=20
> MAX_COPY_NR_RANGE, limits the number of entries for the IOCTL and
> MAX_COPY_TOTAL_LENGTH limits the total copy length, IOCTL can handle.
>=20
> Example code, to issue BLKCOPY:
> /* Sample example to copy three entries with [dest,src,len],
> * [32768, 0, 4096] [36864, 4096, 4096] [40960,8192,4096] on same device=
 */
>=20
> int main(void)
> {
> 	int i, ret, fd;
> 	unsigned long src =3D 0, dst =3D 32768, len =3D 4096;
> 	struct copy_range *cr;
> 	cr =3D (struct copy_range *)malloc(sizeof(*cr)+
> 					(sizeof(struct range_entry)*3));
> 	cr->nr_range =3D 3;
> 	cr->reserved =3D 0;
> 	for (i =3D 0; i< cr->nr_range; i++, src +=3D len, dst +=3D len) {
> 		cr->range_list[i].dst =3D dst;
> 		cr->range_list[i].src =3D src;
> 		cr->range_list[i].len =3D len;
> 		cr->range_list[i].comp_len =3D 0;
> 	}
> 	fd =3D open("/dev/nvme0n1", O_RDWR);
> 	if (fd < 0) return 1;
> 	ret =3D ioctl(fd, BLKCOPY, cr);
> 	if (ret !=3D 0)
> 	       printf("copy failed, ret=3D %d\n", ret);
> 	for (i=3D0; i< cr->nr_range; i++)
> 		if (cr->range_list[i].len !=3D cr->range_list[i].comp_len)
> 			printf("Partial copy for entry %d: requested %llu, completed %llu\n"=
,
> 								i, cr->range_list[i].len,
> 								cr->range_list[i].comp_len);
> 	close(fd);
> 	free(cr);
> 	return ret;
> }

Nice to have a code example. But please format it correctly.

>=20
> Signed-off-by: Nitesh Shetty <nj.shetty@samsung.com>
> Signed-off-by: Javier Gonz=C3=A1lez <javier.gonz@samsung.com>
> Signed-off-by: Arnav Dawn <arnav.dawn@samsung.com>
> ---
>  block/ioctl.c           | 32 ++++++++++++++++++++++++++++++++
>  include/uapi/linux/fs.h |  9 +++++++++
>  2 files changed, 41 insertions(+)
>=20
> diff --git a/block/ioctl.c b/block/ioctl.c
> index 46949f1b0dba..58d93c20ff30 100644
> --- a/block/ioctl.c
> +++ b/block/ioctl.c
> @@ -120,6 +120,36 @@ static int blk_ioctl_discard(struct block_device *=
bdev, fmode_t mode,
>  	return err;
>  }
> =20
> +static int blk_ioctl_copy(struct block_device *bdev, fmode_t mode,
> +		unsigned long arg)
> +{
> +	struct copy_range crange, *ranges =3D NULL;
> +	size_t payload_size =3D 0;
> +	int ret;
> +
> +	if (!(mode & FMODE_WRITE))
> +		return -EBADF;
> +
> +	if (copy_from_user(&crange, (void __user *)arg, sizeof(crange)))
> +		return -EFAULT;
> +
> +	if (unlikely(!crange.nr_range || crange.reserved || crange.nr_range >=
=3D MAX_COPY_NR_RANGE))
> +		return -EINVAL;
> +
> +	payload_size =3D (crange.nr_range * sizeof(struct range_entry)) + siz=
eof(crange);
> +
> +	ranges =3D memdup_user((void __user *)arg, payload_size);
> +	if (IS_ERR(ranges))
> +		return PTR_ERR(ranges);
> +
> +	ret =3D blkdev_issue_copy(bdev, ranges->nr_range, ranges->range_list,=
 bdev, GFP_KERNEL);
> +	if (copy_to_user((void __user *)arg, ranges, payload_size))
> +		ret =3D -EFAULT;
> +
> +	kfree(ranges);
> +	return ret;
> +}
> +
>  static int blk_ioctl_secure_erase(struct block_device *bdev, fmode_t m=
ode,
>  		void __user *argp)
>  {
> @@ -481,6 +511,8 @@ static int blkdev_common_ioctl(struct block_device =
*bdev, fmode_t mode,
>  		return blk_ioctl_discard(bdev, mode, arg);
>  	case BLKSECDISCARD:
>  		return blk_ioctl_secure_erase(bdev, mode, argp);
> +	case BLKCOPY:
> +		return blk_ioctl_copy(bdev, mode, arg);
>  	case BLKZEROOUT:
>  		return blk_ioctl_zeroout(bdev, mode, arg);
>  	case BLKGETDISKSEQ:
> diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
> index 822c28cebf3a..a3b13406ffb8 100644
> --- a/include/uapi/linux/fs.h
> +++ b/include/uapi/linux/fs.h
> @@ -78,6 +78,14 @@ struct range_entry {
>  	__u64 comp_len;
>  };
> =20
> +struct copy_range {
> +	__u64 nr_range;
> +	__u64 reserved;
> +
> +	/* Range_list always must be at the end */
> +	struct range_entry range_list[];
> +};
> +
>  /* extent-same (dedupe) ioctls; these MUST match the btrfs ioctl defin=
itions */
>  #define FILE_DEDUPE_RANGE_SAME		0
>  #define FILE_DEDUPE_RANGE_DIFFERS	1
> @@ -199,6 +207,7 @@ struct fsxattr {
>  #define BLKROTATIONAL _IO(0x12,126)
>  #define BLKZEROOUT _IO(0x12,127)
>  #define BLKGETDISKSEQ _IOR(0x12,128,__u64)
> +#define BLKCOPY _IOWR(0x12, 129, struct copy_range)
>  /*
>   * A jump here: 130-136 are reserved for zoned block devices
>   * (see uapi/linux/blkzoned.h)


--=20
Damien Le Moal
Western Digital Research