Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp4399253ioa; Wed, 27 Apr 2022 03:02:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy73BDnTB3fBttpfNfRgXTqE+rbitEt6F8qJbKtCxTR3Xz0rWriHjOyhmdhBWGTDiW6sUjR X-Received: by 2002:a17:902:8a8d:b0:157:ab0:a07 with SMTP id p13-20020a1709028a8d00b001570ab00a07mr27624948plo.77.1651053758537; Wed, 27 Apr 2022 03:02:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651053758; cv=none; d=google.com; s=arc-20160816; b=VvDvkowTkEa4bDjNr/Mzr2TLkVwaDz07YLQsKLXKklTpnnlg9I8yo5pVuFzAeb5bcn Yq3iGnqhUc6iiyJZF/n0iTFKMdPMwyefiyky4lCtLdHL0rW0P841M716lnj86iKcLqtM xjwjNDH4flKKwoFurLSYQNyOnNmH/5UuMYhnoEq8kQZSRvrJzC3B4uCbjtvrAfve2QUO SCstRHVTnypzH0dT/nlqpq+gVJnfhLJzXxywNPEOt8MVL22EBly5zlJfY45SGC2gscrk y56stT8Phn5CnV4Mm2ys1szPuB0i52wufBeLBwuydN1R4XaccMZM4UeqfNQd4WfdqoS/ Yg9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Ar82l8a5V0FQsztMr+fwfq4uru7ujk4Lz6TDfztwQaI=; b=TjY0B+y1eNnkpn25TeIQSV6WOAJ+x4bmvny9q5Y+NbLwJTWbgEwfsV4UrVFbB5agba TuohdcLlLaoaIKwob8/j2UV27zHF1gWmxA43RUySa9mILGWc4r/Omb2lD0CJLGo8amDW ujgBMHnGqAfiFuToJZW/lGauSbbGlgOZexX/RPK4lBNnp4NFCOC2Om8krO6fG+v856fE 8QjeHc0DyT/jIXcRFmy6K6LeiQxx1y+h5f8SkA91rPNrmvm0YjVzMfrpqR5aCudDV5e0 QE1IarZwEyXg7aZ/jwINrkNWWZnCENIPaukNuU7q7kxIlzeY/31aEz5JoDnwS2zD9bkv JvJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=A9PPhaws; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id p128-20020a634286000000b003816043f16fsi953464pga.868.2022.04.27.03.02.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 03:02:38 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=A9PPhaws; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C6A6A2DC2C2; Wed, 27 Apr 2022 02:29:04 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350506AbiDZNC0 (ORCPT + 99 others); Tue, 26 Apr 2022 09:02:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350380AbiDZNBc (ORCPT ); Tue, 26 Apr 2022 09:01:32 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3F0E17F11B; Tue, 26 Apr 2022 05:58:20 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: nicolas) with ESMTPSA id 61F8F1F43992 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1650977899; bh=gu3hWa9l9RwIqYfPgXJTq2hXyJdb/X3UYi37Vl+bXOc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A9PPhaws+0UJKFGVd1hph8rKqPW0f16roDicNJFfCdGnt2qPN466cQ22WLaQfg4U5 +Jxnnc1YkNht2e50RoYOjFvb/wNAKG1eu+UGyCbR/EhBVNTOiBmGazcu+7DO0/G5ql WnI0BtliPH3K5k0AyymLQZNm8otEZaMpTYQsCZo5HAI7ZBydI7UbBYsjEizKhU0c4c JTiYZEDPyYpzkw2cpXNWb1S/C+OrHDHktRpzO2Or1om6MilkX5eHtIzxOxPweZ9ioC WIyhM23PqBPJS0uf9kApXCI2runbW5D6iZ2Uyj/LxM4r2W/haPC6ILBcRTnprAIRMr u0V8WQkrdXY/Q== From: Nicolas Dufresne To: Ezequiel Garcia , Mauro Carvalho Chehab , Greg Kroah-Hartman , Hans Verkuil , Boris Brezillon Cc: nicolas@ndufresne.ca, linux-media@vger.kernel.org, Sebastian Fricke , Mauro Carvalho Chehab , linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 12/24] media: rkvdec: Stop overclocking the decoder Date: Tue, 26 Apr 2022 08:57:38 -0400 Message-Id: <20220426125751.108293-13-nicolas.dufresne@collabora.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426125751.108293-1-nicolas.dufresne@collabora.com> References: <20220426125751.108293-1-nicolas.dufresne@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While this overclock hack seems to work on some implementations (some ChromeBooks, RockPi4) it also causes instability on other implementations (notably LibreComputer Renegade, but there were more reports in the LibreELEC project, where this has been removed). While performance is indeed affected (tested with GStreamer), 4K playback still works as long as you don't operate in lock step and keep at least 1 frame ahead of time in the decode queue. After discussion with ChromeOS members, it would seem that their implementation indeed used to synchronously decode each frame, so this hack was simply compensating for their code being less efficient. In my opinion, this hack should not have been included upstream. Fixes: cd33c830448ba ("media: rkvdec: Add the rkvdec driver") Signed-off-by: Nicolas Dufresne Reviewed-by: Sebastian Fricke Reviewed-by: Ezequiel Garcia --- drivers/staging/media/rkvdec/rkvdec.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c index c0cf3488f970..2df8cf4883e2 100644 --- a/drivers/staging/media/rkvdec/rkvdec.c +++ b/drivers/staging/media/rkvdec/rkvdec.c @@ -1027,12 +1027,6 @@ static int rkvdec_probe(struct platform_device *pdev) if (ret) return ret; - /* - * Bump ACLK to max. possible freq. (500 MHz) to improve performance - * When 4k video playback. - */ - clk_set_rate(rkvdec->clocks[0].clk, 500 * 1000 * 1000); - rkvdec->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(rkvdec->regs)) return PTR_ERR(rkvdec->regs); -- 2.34.1