Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220419142859.380566-1-krzysztof.kozlowski@linaro.org> <20220419142859.380566-6-krzysztof.kozlowski@linaro.org>
In-Reply-To: <20220419142859.380566-6-krzysztof.kozlowski@linaro.org>
From:   Markus Mayer <mmayer@broadcom.com>
Date:   Tue, 26 Apr 2022 09:52:05 -0700
Message-ID: <CAGt4E5tyGQStKT3S=tUg8CLchzS3S3g8Byh2Kap9oids=jF-UQ@mail.gmail.com>
Subject: Re: [PATCH 6/7] memory: brcmstb_dpfe: simplify platform_get_resource_byname()
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Broadcom Kernel Team <bcm-kernel-feedback-list@broadcom.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Santosh Shilimkar <ssantosh@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Linux ARM Kernel <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        linux-tegra@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 19 Apr 2022 at 07:29, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Use devm_platform_ioremap_resource_byname() instead of
> platform_get_resource_byname() and devm_ioremap_resource().
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Thanks for the change.

Acked-by: Markus Mayer <mmayer@broadcom.com>

Regards,
-Markus

> ---
>  drivers/memory/brcmstb_dpfe.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c
> index 14412002775d..76c82e9c8fce 100644
> --- a/drivers/memory/brcmstb_dpfe.c
> +++ b/drivers/memory/brcmstb_dpfe.c
> @@ -857,7 +857,6 @@ static int brcmstb_dpfe_probe(struct platform_device *pdev)
>  {
>         struct device *dev = &pdev->dev;
>         struct brcmstb_dpfe_priv *priv;
> -       struct resource *res;
>         int ret;
>
>         priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> @@ -869,22 +868,19 @@ static int brcmstb_dpfe_probe(struct platform_device *pdev)
>         mutex_init(&priv->lock);
>         platform_set_drvdata(pdev, priv);
>
> -       res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dpfe-cpu");
> -       priv->regs = devm_ioremap_resource(dev, res);
> +       priv->regs = devm_platform_ioremap_resource_byname(pdev, "dpfe-cpu");
>         if (IS_ERR(priv->regs)) {
>                 dev_err(dev, "couldn't map DCPU registers\n");
>                 return -ENODEV;
>         }
>
> -       res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dpfe-dmem");
> -       priv->dmem = devm_ioremap_resource(dev, res);
> +       priv->dmem = devm_platform_ioremap_resource_byname(pdev, "dpfe-dmem");
>         if (IS_ERR(priv->dmem)) {
>                 dev_err(dev, "Couldn't map DCPU data memory\n");
>                 return -ENOENT;
>         }
>
> -       res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dpfe-imem");
> -       priv->imem = devm_ioremap_resource(dev, res);
> +       priv->imem = devm_platform_ioremap_resource_byname(pdev, "dpfe-imem");
>         if (IS_ERR(priv->imem)) {
>                 dev_err(dev, "Couldn't map DCPU instruction memory\n");
>                 return -ENOENT;
> --
> 2.32.0
>